From mboxrd@z Thu Jan 1 00:00:00 1970 From: Maxime Ripard Subject: Re: [PATCH 1/7] regulator: axp20x: Fix poly-phase bit offset for AXP803 DCDC5/6 Date: Fri, 29 Sep 2017 10:33:10 +0200 Message-ID: <20170929083310.eswbl6l5tac3vbwj@flea> References: <20170929032514.31727-1-wens@csie.org> <20170929032514.31727-2-wens@csie.org> Reply-To: maxime.ripard-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="ifjrczdqgjudhzq3" Return-path: Sender: linux-sunxi-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org Content-Disposition: inline In-Reply-To: <20170929032514.31727-2-wens-jdAy2FN1RRM@public.gmane.org> List-Post: , List-Help: , List-Archive: , List-Unsubscribe: , To: Chen-Yu Tsai Cc: Lee Jones , Mark Brown , linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-sunxi-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org, Quentin Schulz List-Id: devicetree@vger.kernel.org --ifjrczdqgjudhzq3 Content-Type: text/plain; charset="UTF-8" Content-Disposition: inline On Fri, Sep 29, 2017 at 03:25:08AM +0000, Chen-Yu Tsai wrote: > The bit offset used to check if DCDC5 and DCDC6 are tied together in > poly-phase output is wrong. It was checking against a reserved bit, > which is always false. > > In reality, neither the reference design layout nor actually produced > boards tie these two buck regulators together. But we should still > fix it, just in case. > > Fixes: 1dbe0ccb0631 ("regulator: axp20x-regulator: add support for AXP803") > Signed-off-by: Chen-Yu Tsai > Tested-by: Maxime Ripard Acked-by: Maxime Ripard -- Maxime Ripard, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com --ifjrczdqgjudhzq3--