Re: [PATCH v3 12/12] ARM: dtsi: axp81x: set pinmux for GPIO0/1 when used as LDOs

Maxime Ripard
2017-10-03T14:43:28Z

[-- Attachment #1: Type: text/plain, Size: 2482 bytes --]

On Tue, Oct 03, 2017 at 09:18:37AM +0000, Russell King - ARM Linux wrote:
> On Tue, Oct 03, 2017 at 10:06:29AM +0800, Chen-Yu Tsai wrote:
> > On Tue, Oct 3, 2017 at 4:42 AM, Maxime Ripard
> > <maxime.ripard-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org> wrote:
> > > On Mon, Oct 02, 2017 at 12:08:54PM +0000, Quentin Schulz wrote:
> > >> On AXP813/818, GPIO0 and GPIO1 can be used as LDO as (respectively)
> > >> ldo_io0 and ldo_io1.
> > >>
> > >> Let's add the pinctrl properties to the said regulators.
> > >>
> > >> Signed-off-by: Quentin Schulz <quentin.schulz-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org>
> > >> ---
> > >> arch/arm/boot/dts/axp81x.dtsi | 14 ++++++++++++++
> > >> 1 file changed, 14 insertions(+)
> > >>
> > >> diff --git a/arch/arm/boot/dts/axp81x.dtsi b/arch/arm/boot/dts/axp81x.dtsi
> > >> index f90f257130d5..099b0ddc1bbb 100644
> > >> --- a/arch/arm/boot/dts/axp81x.dtsi
> > >> +++ b/arch/arm/boot/dts/axp81x.dtsi
> > >> @@ -52,6 +52,16 @@
> > >> compatible = "x-powers,axp813-gpio";
> > >> gpio-controller;
> > >> #gpio-cells = <2>;
> > >> +
> > >> + gpio0_ldo: gpio0_ldo {
> > >> + pins = "GPIO0";
> > >> + function = "ldo";
> > >> + };
> > >> +
> > >> + gpio1_ldo: gpio1_ldo {
> > >> + pins = "GPIO1";
> > >> + function = "ldo";
> > >> + };
> > >
> > > The node names are not supposed to contain any hyphens.
> >
> > Hmm, I was under the impression that hyphens were preferred in
> > node names, and a warning would be added to dtc later on.
> > I might be wrong though.
>
> I think there's a terminology issue here.
>
> "-" is a hyphen or minus sign.
> "_" is an underscore.
>
> Underscores are not supposed to be used for node names, instead hyphens
> are preferred. I think Maxime means "underscore".
>
> Here's the list from dtc/checks.c:
>
> #define LOWERCASE "abcdefghijklmnopqrstuvwxyz"
> #define UPPERCASE "ABCDEFGHIJKLMNOPQRSTUVWXYZ"
> #define DIGITS "0123456789"
> #define PROPNODECHARS LOWERCASE UPPERCASE DIGITS ",._+*#?-"
> #define PROPNODECHARSSTRICT LOWERCASE UPPERCASE DIGITS ",-"
>
> If strict mode is enabled, use of any of "._+#?" in the node name will
> produce a warning.

Right, sorry, I meant underscores..

Maxime

--
Maxime Ripard, Free Electrons
Embedded Linux and Kernel engineering