From mboxrd@z Thu Jan 1 00:00:00 1970 From: Vignesh R Subject: [PATCH v4 5/6] mtd: spi-nor: cadence-quadspi: Fix error path in probe Date: Tue, 3 Oct 2017 10:49:24 +0530 Message-ID: <20171003051925.8821-6-vigneshr@ti.com> References: <20171003051925.8821-1-vigneshr@ti.com> Mime-Version: 1.0 Content-Type: text/plain Return-path: In-Reply-To: <20171003051925.8821-1-vigneshr@ti.com> Sender: linux-kernel-owner@vger.kernel.org To: Marek Vasut , Cyrille Pitchen Cc: David Woodhouse , Brian Norris , Boris Brezillon , Rob Herring , linux-mtd@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Vignesh R , linux-arm-kernel List-Id: devicetree@vger.kernel.org Fix the reversed goto labels, so that we disable cqspi controller only if its enabled previously. This is a minor cleanup. Signed-off-by: Vignesh R --- drivers/mtd/spi-nor/cadence-quadspi.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/mtd/spi-nor/cadence-quadspi.c b/drivers/mtd/spi-nor/cadence-quadspi.c index d9629e8f4798..60b557e00cfb 100644 --- a/drivers/mtd/spi-nor/cadence-quadspi.c +++ b/drivers/mtd/spi-nor/cadence-quadspi.c @@ -1255,9 +1255,9 @@ static int cqspi_probe(struct platform_device *pdev) } return ret; -probe_irq_failed: - cqspi_controller_enable(cqspi, 0); probe_setup_failed: + cqspi_controller_enable(cqspi, 0); +probe_irq_failed: clk_disable_unprepare(cqspi->clk); return ret; } -- 2.14.1