devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Simon Horman <horms@verge.net.au>
To: Geert Uytterhoeven <geert@linux-m68k.org>
Cc: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>,
	Rob Herring <robh+dt@kernel.org>,
	Catalin Marinas <catalin.marinas@arm.com>,
	Will Deacon <will.deacon@arm.com>,
	Linux-Renesas <linux-renesas-soc@vger.kernel.org>,
	"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
	Mark Rutland <mark.rutland@arm.com>,
	Magnus Damm <magnus.damm@gmail.com>,
	"linux-arm-kernel@lists.infradead.org"
	<linux-arm-kernel@lists.infradead.org>,
	Vladimir Barinov <vladimir.barinov@cogentembedded.com>
Subject: Re: [PATCH v2 8/8] arm64: dts: renesas: eagle: add EtherAVB support
Date: Thu, 5 Oct 2017 11:05:01 +0200	[thread overview]
Message-ID: <20171005090500.GC26369@verge.net.au> (raw)
In-Reply-To: <CAMuHMdVCTORpfKN+GTka_6pT1VWjOneV2GBhGo7Y8DsZYSxdvw@mail.gmail.com>

On Thu, Sep 21, 2017 at 06:09:34PM +0200, Geert Uytterhoeven wrote:
> Hi Sergei,
> 
> On Thu, Sep 21, 2017 at 6:03 PM, Sergei Shtylyov
> <sergei.shtylyov@cogentembedded.com> wrote:
> > On 9/21/2017 4:08 PM, Geert Uytterhoeven wrote:
> >>> Define the Eagle board  dependent part of the EtherAVB device node.
> >>> Enable DHCP  and NFS root for the kernel booting.
> >>>
> >>> Based  on the original (and large) patch by Vladimir Barinov.
> >>>
> >>> Signed-off-by: Vladimir Barinov <vladimir.barinov@cogentembedded.com>
> >>> Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
> >>
> >>
> >>> --- renesas.orig/arch/arm64/boot/dts/renesas/r8a77970-eagle.dts
> >>> +++ renesas/arch/arm64/boot/dts/renesas/r8a77970-eagle.dts
> >
> > [...]
> >>>
> >>> @@ -43,3 +44,14 @@
> >>>   &scif0 {
> >>>          status = "okay";
> >>>   };
> >>> +
> >>> +&avb {
> >>> +       renesas,no-ether-link;
> >>> +       phy-handle = <&phy0>;
> >>> +       status = "okay";
> >>> +
> >>> +       phy0: ethernet-phy@0 {
> >>> +               rxc-skew-ps = <1500>;
> >>> +               reg = <0>;
> >>
> >>
> >> Any specific reason why you don't want to wire up the interrupt?
> >>
> >>                  interrupt-parent = <&gpio2>;
> >
> >
> >    I thought it's quite obvious -- we don't have GPIOs yet, and GPIOs seem
> > to require PFC.
> 
> Of course. And these can be added later.
> 
> Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>

Thanks, applied.

  reply	other threads:[~2017-10-05  9:05 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-09-15 19:43 [PATCH v2 8/8] arm64: dts: renesas: eagle: add EtherAVB support Sergei Shtylyov
     [not found] ` <20170915194449.538504992-M4DtvfQ/ZS1MRgGoP+s0PdBPR1lH4CV8@public.gmane.org>
2017-09-21 13:08   ` Geert Uytterhoeven
     [not found]     ` <CAMuHMdXQXFuVzwW7G-U7XWZUEj8qFRjtfDQF1+TgyzO0Xb+eYg-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2017-09-21 16:03       ` Sergei Shtylyov
     [not found]         ` <c0390fc1-7da4-ac60-afee-97126d1fd372-M4DtvfQ/ZS1MRgGoP+s0PdBPR1lH4CV8@public.gmane.org>
2017-09-21 16:09           ` Geert Uytterhoeven
2017-10-05  9:05             ` Simon Horman [this message]
     [not found]               ` <20171005090500.GC26369-/R6kz+dDXgpPR4JQBCEnsQ@public.gmane.org>
2017-10-05 17:18                 ` Sergei Shtylyov
2017-10-06  9:31                   ` Simon Horman
2017-10-06  9:34                     ` Sergei Shtylyov
2017-10-09 17:57                 ` Sergei Shtylyov
     [not found]                   ` <d5940a12-3823-eebb-50d9-c0fd0fcf0fd1-M4DtvfQ/ZS1MRgGoP+s0PdBPR1lH4CV8@public.gmane.org>
2017-10-10  7:33                     ` Simon Horman
     [not found]                       ` <20171010073346.GL2518-/R6kz+dDXgpPR4JQBCEnsQ@public.gmane.org>
2017-10-10  7:48                         ` Simon Horman
     [not found]                           ` <20171010074842.GN2518-/R6kz+dDXgpPR4JQBCEnsQ@public.gmane.org>
2017-10-10  8:03                             ` Simon Horman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20171005090500.GC26369@verge.net.au \
    --to=horms@verge.net.au \
    --cc=catalin.marinas@arm.com \
    --cc=devicetree@vger.kernel.org \
    --cc=geert@linux-m68k.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-renesas-soc@vger.kernel.org \
    --cc=magnus.damm@gmail.com \
    --cc=mark.rutland@arm.com \
    --cc=robh+dt@kernel.org \
    --cc=sergei.shtylyov@cogentembedded.com \
    --cc=vladimir.barinov@cogentembedded.com \
    --cc=will.deacon@arm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).