From mboxrd@z Thu Jan 1 00:00:00 1970 From: Rob Herring Subject: Re: [PATCH 8/9] dt-bindings: usb: mtk-xhci: add a optional property to disable u3ports Date: Thu, 5 Oct 2017 17:16:50 -0500 Message-ID: <20171005221650.yfyh72op6azm2nri@rob-hp-laptop> References: <994382d16d6bdc0f3d7c11b22f1710252e056e34.1506503879.git.chunfeng.yun@mediatek.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: Sender: linux-usb-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Chunfeng Yun Cc: Mathias Nyman , Greg Kroah-Hartman , Felipe Balbi , Matthias Brugger , Mark Rutland , Ian Campbell , linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, linux-usb-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-mediatek-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-Id: devicetree@vger.kernel.org On Wed, Sep 27, 2017 at 05:23:04PM +0800, Chunfeng Yun wrote: > Add a new optional property to disable u3ports > > Signed-off-by: Chunfeng Yun > --- > .../devicetree/bindings/usb/mediatek,mtk-xhci.txt | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/Documentation/devicetree/bindings/usb/mediatek,mtk-xhci.txt b/Documentation/devicetree/bindings/usb/mediatek,mtk-xhci.txt > index 5611a2e..2d9b459 100644 > --- a/Documentation/devicetree/bindings/usb/mediatek,mtk-xhci.txt > +++ b/Documentation/devicetree/bindings/usb/mediatek,mtk-xhci.txt > @@ -38,6 +38,8 @@ Optional properties: > mode; > - mediatek,syscon-wakeup : phandle to syscon used to access USB wakeup > control register, it depends on "mediatek,wakeup-src". > + - mediatek,u3p-dis-msk : mask to disable u3ports, bit0 for u3port0, > + bit1 for u3port1, ... etc; I think you should have child nodes for ports and use "status" to disable them (or omit them). IIRC, the common USB bus binding already defines ports. > - vbus-supply : reference to the VBUS regulator; > - usb3-lpm-capable : supports USB3.0 LPM > - pinctrl-names : a pinctrl state named "default" must be defined > -- > 1.7.9.5 > -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html