From: Leo Yan <leo.yan@linaro.org>
To: Suzuki K Poulose <suzuki.poulose@arm.com>
Cc: linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, mark.rutland@arm.com,
robh@kernel.org, will.deacon@arm.com, sudeep.holla@arm.com,
frowand.list@gmail.com, devicetree@vger.kernel.org,
Jonathan.Cameron@huawei.com, marc.zyngier@arm.com,
peterz@infradead.org, mathieu.poirier@linaro.org
Subject: Re: [PATCH v7 3/6] coresight: of: Use of_cpu_node_to_id helper
Date: Mon, 9 Oct 2017 10:58:42 +0800 [thread overview]
Message-ID: <20171009025842.GA3146@leoy-linaro> (raw)
In-Reply-To: <20171006103610.11853-4-suzuki.poulose@arm.com>
Hi Suzuki,
On Fri, Oct 06, 2017 at 11:36:07AM +0100, Suzuki K Poulose wrote:
> Reuse the new generic helper, of_cpu_node_to_id() to map a
> given CPU phandle to a logical CPU number.
>
> Cc: Leo Yan <leo.yan@linaro.org>
> Acked-by: Mathieu Poirier <mathieu.poirier@linaro.org>
> Signed-off-by: Suzuki K Poulose <suzuki.poulose@arm.com>
Tested-by: Leo Yan <leo.yan@linaro.org>
BTW, I think the function get_cpu_for_node() in the file
arch/arm64/kernel/topology.c we also can refactor with the same
function, just reminding for this.
> ---
> Changes since V4:
> - Fix a regression introduced in v4, reported by bugrobot
> Changes since V3:
> - Reflect the renaming of the helper and return value changes
> ---
> drivers/hwtracing/coresight/of_coresight.c | 15 +++------------
> 1 file changed, 3 insertions(+), 12 deletions(-)
>
> diff --git a/drivers/hwtracing/coresight/of_coresight.c b/drivers/hwtracing/coresight/of_coresight.c
> index a18794128bf8..7c375443ede6 100644
> --- a/drivers/hwtracing/coresight/of_coresight.c
> +++ b/drivers/hwtracing/coresight/of_coresight.c
> @@ -104,26 +104,17 @@ static int of_coresight_alloc_memory(struct device *dev,
> int of_coresight_get_cpu(const struct device_node *node)
> {
> int cpu;
> - bool found;
> - struct device_node *dn, *np;
> + struct device_node *dn;
>
> dn = of_parse_phandle(node, "cpu", 0);
> -
> /* Affinity defaults to CPU0 */
> if (!dn)
> return 0;
> -
> - for_each_possible_cpu(cpu) {
> - np = of_cpu_device_node_get(cpu);
> - found = (dn == np);
> - of_node_put(np);
> - if (found)
> - break;
> - }
> + cpu = of_cpu_node_to_id(dn);
> of_node_put(dn);
>
> /* Affinity to CPU0 if no cpu nodes are found */
> - return found ? cpu : 0;
> + return (cpu < 0) ? 0 : cpu;
> }
> EXPORT_SYMBOL_GPL(of_coresight_get_cpu);
>
> --
> 2.13.6
>
next prev parent reply other threads:[~2017-10-09 2:58 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-06 10:36 [PATCH v7 0/6] perf: Support for ARM DynamIQ Shared Unit Suzuki K Poulose
2017-10-06 10:36 ` [PATCH v7 1/6] perf: Export perf_event_update_userpage Suzuki K Poulose
2017-10-06 10:36 ` [PATCH v7 2/6] of: Add helper for mapping device node to logical CPU number Suzuki K Poulose
2017-10-06 10:36 ` [PATCH v7 3/6] coresight: of: Use of_cpu_node_to_id helper Suzuki K Poulose
2017-10-09 2:58 ` Leo Yan [this message]
2017-10-10 9:38 ` Suzuki K Poulose
2017-10-06 10:36 ` [PATCH v7 4/6] irqchip: gic-v3: " Suzuki K Poulose
2017-10-06 10:36 ` [PATCH v7 5/6] dt-bindings: Document devicetree binding for ARM DSU PMU Suzuki K Poulose
2017-10-06 10:36 ` [PATCH v7 6/6] perf: ARM DynamIQ Shared Unit PMU support Suzuki K Poulose
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171009025842.GA3146@leoy-linaro \
--to=leo.yan@linaro.org \
--cc=Jonathan.Cameron@huawei.com \
--cc=devicetree@vger.kernel.org \
--cc=frowand.list@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marc.zyngier@arm.com \
--cc=mark.rutland@arm.com \
--cc=mathieu.poirier@linaro.org \
--cc=peterz@infradead.org \
--cc=robh@kernel.org \
--cc=sudeep.holla@arm.com \
--cc=suzuki.poulose@arm.com \
--cc=will.deacon@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).