From: Simon Horman <horms@verge.net.au>
To: Biju Das <biju.das@bp.renesas.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Felipe Balbi <balbi@kernel.org>,
Geert Uytterhoeven <geert@linux-m68k.org>,
Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>,
Rob Herring <robh+dt@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
Chris Paterson <chris.paterson2@renesas.com>,
Fabrizio Castro <fabrizio.castro@bp.renesas.com>,
devicetree@vger.kernel.org, linux-renesas-soc@vger.kernel.org,
linux-usb@vger.kernel.org
Subject: Re: [PATCH v2] usb: renesas_usbhs: Add compatible string for r8a7743/5
Date: Mon, 9 Oct 2017 07:59:37 +0200 [thread overview]
Message-ID: <20171009055937.GE31804@verge.net.au> (raw)
In-Reply-To: <1507308574-32047-1-git-send-email-biju.das@bp.renesas.com>
On Fri, Oct 06, 2017 at 05:49:34PM +0100, Biju Das wrote:
> This patch adds support for r8a7743/5 SoCs. The Renesas RZ/G1[ME]
> (R8A7743/5) usbhs is identical to the R-Car Gen2 family.
>
> No driver change is needed due to the fallback compatible value
> "renesas,rcar-gen2-usbhs".
> Adding the SoC-specific compatible values here has two purposes:
> 1. Document which SoCs have this hardware module,
> 2. Allow checkpatch to validate compatible values.
3. Allow the driver to support SoC specific implementations in future
as necessary.
Acked-by: Simon Horman <horms+renesas@verge.net.au>
> Signed-off-by: Biju Das <biju.das@bp.renesas.com>
> Signed-off-by: Chris Paterson <chris.paterson2@renesas.com>
> Reviewed-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>
> Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
> ---
> v1-->v2
> * Modified the patch description
> * Rebased on the below R-Car D3 patch
> https://patchwork.kernel.org/patch/9982267/
>
> This patch is tested against Linux next tag next-20170929 +
> https://patchwork.kernel.org/patch/9982267/
>
> Documentation/devicetree/bindings/usb/renesas_usbhs.txt | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/Documentation/devicetree/bindings/usb/renesas_usbhs.txt b/Documentation/devicetree/bindings/usb/renesas_usbhs.txt
> index e79f6e4..47394ab 100644
> --- a/Documentation/devicetree/bindings/usb/renesas_usbhs.txt
> +++ b/Documentation/devicetree/bindings/usb/renesas_usbhs.txt
> @@ -3,6 +3,8 @@ Renesas Electronics USBHS driver
> Required properties:
> - compatible: Must contain one or more of the following:
>
> + - "renesas,usbhs-r8a7743" for r8a7743 (RZ/G1M) compatible device
> + - "renesas,usbhs-r8a7745" for r8a7745 (RZ/G1E) compatible device
> - "renesas,usbhs-r8a7790" for r8a7790 (R-Car H2) compatible device
> - "renesas,usbhs-r8a7791" for r8a7791 (R-Car M2-W) compatible device
> - "renesas,usbhs-r8a7792" for r8a7792 (R-Car V2H) compatible device
> @@ -11,7 +13,7 @@ Required properties:
> - "renesas,usbhs-r8a7795" for r8a7795 (R-Car H3) compatible device
> - "renesas,usbhs-r8a7796" for r8a7796 (R-Car M3-W) compatible device
> - "renesas,usbhs-r8a77995" for r8a77995 (R-Car D3) compatible device
> - - "renesas,rcar-gen2-usbhs" for R-Car Gen2 compatible device
> + - "renesas,rcar-gen2-usbhs" for R-Car Gen2 or RZ/G1 compatible devices
> - "renesas,rcar-gen3-usbhs" for R-Car Gen3 compatible device
>
> When compatible with the generic version, nodes must list the
> --
> 1.9.1
>
next prev parent reply other threads:[~2017-10-09 5:59 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-06 16:49 [PATCH v2] usb: renesas_usbhs: Add compatible string for r8a7743/5 Biju Das
2017-10-09 5:59 ` Simon Horman [this message]
[not found] ` <20171009055937.GE31804-/R6kz+dDXgpPR4JQBCEnsQ@public.gmane.org>
2017-10-09 6:29 ` Geert Uytterhoeven
[not found] ` <1507308574-32047-1-git-send-email-biju.das-kTT6dE0pTRh9uiUsa/gSgQ@public.gmane.org>
2017-10-13 19:27 ` Rob Herring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171009055937.GE31804@verge.net.au \
--to=horms@verge.net.au \
--cc=balbi@kernel.org \
--cc=biju.das@bp.renesas.com \
--cc=chris.paterson2@renesas.com \
--cc=devicetree@vger.kernel.org \
--cc=fabrizio.castro@bp.renesas.com \
--cc=geert@linux-m68k.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=robh+dt@kernel.org \
--cc=yoshihiro.shimoda.uh@renesas.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).