* [PATCH] drm/tilcdc: Remove redundant OF_DETACHED flag setting
@ 2017-10-13 7:47 Stephen Boyd
2017-10-13 12:02 ` Jyri Sarha
0 siblings, 1 reply; 2+ messages in thread
From: Stephen Boyd @ 2017-10-13 7:47 UTC (permalink / raw)
To: Jyri Sarha, Tomi Valkeinen
Cc: linux-kernel, dri-devel, devicetree, Rob Herring, Frank Rowand
of_fdt_unflatten_tree() already sets the flag on this node to
OF_DETACHED, because of_fdt_unflatten_tree() calls
__unflatten_device_tree() with the detached bool set to true.
Cc: Rob Herring <robh+dt@kernel.org>
Cc: Frank Rowand <frowand.list@gmail.com>
Signed-off-by: Stephen Boyd <stephen.boyd@linaro.org>
---
drivers/gpu/drm/tilcdc/tilcdc_slave_compat.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/gpu/drm/tilcdc/tilcdc_slave_compat.c b/drivers/gpu/drm/tilcdc/tilcdc_slave_compat.c
index 623a9140493c..482299a6f3b0 100644
--- a/drivers/gpu/drm/tilcdc/tilcdc_slave_compat.c
+++ b/drivers/gpu/drm/tilcdc/tilcdc_slave_compat.c
@@ -163,7 +163,6 @@ static struct device_node * __init tilcdc_get_overlay(struct kfree_table *kft)
return NULL;
}
- of_node_set_flag(overlay, OF_DETACHED);
ret = of_resolve_phandles(overlay);
if (ret) {
pr_err("%s: Failed to resolve phandles: %d\n", __func__, ret);
--
2.14.GIT
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH] drm/tilcdc: Remove redundant OF_DETACHED flag setting
2017-10-13 7:47 [PATCH] drm/tilcdc: Remove redundant OF_DETACHED flag setting Stephen Boyd
@ 2017-10-13 12:02 ` Jyri Sarha
0 siblings, 0 replies; 2+ messages in thread
From: Jyri Sarha @ 2017-10-13 12:02 UTC (permalink / raw)
To: Stephen Boyd, Tomi Valkeinen
Cc: linux-kernel, dri-devel, devicetree, Rob Herring, Frank Rowand
Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki. Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki
On 10/13/17 10:47, Stephen Boyd wrote:
> of_fdt_unflatten_tree() already sets the flag on this node to
> OF_DETACHED, because of_fdt_unflatten_tree() calls
> __unflatten_device_tree() with the detached bool set to true.
>
> Cc: Rob Herring <robh+dt@kernel.org>
> Cc: Frank Rowand <frowand.list@gmail.com>
> Signed-off-by: Stephen Boyd <stephen.boyd@linaro.org>
> ---
> drivers/gpu/drm/tilcdc/tilcdc_slave_compat.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/tilcdc/tilcdc_slave_compat.c b/drivers/gpu/drm/tilcdc/tilcdc_slave_compat.c
> index 623a9140493c..482299a6f3b0 100644
> --- a/drivers/gpu/drm/tilcdc/tilcdc_slave_compat.c
> +++ b/drivers/gpu/drm/tilcdc/tilcdc_slave_compat.c
> @@ -163,7 +163,6 @@ static struct device_node * __init tilcdc_get_overlay(struct kfree_table *kft)
> return NULL;
> }
>
> - of_node_set_flag(overlay, OF_DETACHED);
> ret = of_resolve_phandles(overlay);
> if (ret) {
> pr_err("%s: Failed to resolve phandles: %d\n", __func__, ret);
>
Acked-by: Jyri Sarha <jsarha@gmail.com>
I'll pick this up for my next pull request.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2017-10-13 12:02 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-10-13 7:47 [PATCH] drm/tilcdc: Remove redundant OF_DETACHED flag setting Stephen Boyd
2017-10-13 12:02 ` Jyri Sarha
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).