From: Ladislav Michl <ladis-6z/3iImG2C8G8FEW9MqTrA@public.gmane.org>
To: Tony Lindgren <tony-4v6yS6AI5VpBDgjK7y7TUQ@public.gmane.org>
Cc: "Reizer, Eyal" <eyalr-l0cyMroinI0@public.gmane.org>,
"linux-omap-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
<linux-omap-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
"Benoît Cousson"
<bcousson-rdvid1DuHRBWk0Htik3J/w@public.gmane.org>,
"devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
<devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
"Gerlach, Dave" <d-gerlach-l0cyMroinI0@public.gmane.org>,
"Strashko,
Grygorii" <grygorii.strashko-l0cyMroinI0@public.gmane.org>,
"Kalle Valo" <kvalo-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>,
"Menon, Nishanth" <nm-l0cyMroinI0@public.gmane.org>,
"Kristo, Tero" <t-kristo-l0cyMroinI0@public.gmane.org>
Subject: Re: [PATCH] ARM: dts: Fix omap l4per idling with wlcore edge sensitive interrupt
Date: Mon, 16 Oct 2017 00:15:36 +0200 [thread overview]
Message-ID: <20171015221536.ybe7x52tenocel6c@lenoch> (raw)
In-Reply-To: <20171015162230.GU4394-4v6yS6AI5VpBDgjK7y7TUQ@public.gmane.org>
On Sun, Oct 15, 2017 at 09:22:31AM -0700, Tony Lindgren wrote:
> * Reizer, Eyal <eyalr-l0cyMroinI0@public.gmane.org> [171014 23:55]:
> > > From: Tony Lindgren [mailto:tony-4v6yS6AI5VpBDgjK7y7TUQ@public.gmane.org]
> > >
> > > On omaps, if the wlcore interrupt is configured as level instead of edge,
> > > L4PER will stop doing hardware based idling after ifconfig wlan0 down is
> > > done and the WL_EN line is pulled down.
> > >
> > Do we understand why omap is doing this? Is it a bug or a normal behavior?
> >
> > AFAIK way back edge interrupts have been used. On some omaps based boards.
> > They have used level interrupts instead due to occasional interrupts being missed
> > By the omap interrupts controller when using edge based interrupts which caused
> > Issues. This was the reason many boards are set to using level based interrupts which
> > Seemed much more robust.
>
> No idea yet why exactly the gpio modules won't idle after that. But for making
> edge interrupts behave, I suspect that Grygorii's patch "[RESEND PATCH] gpio:
> omap: Fix lost edge interrupts" fixes those issues.
Please note, that Grygorii's patch fixes occasional edge interrupts misses
only after your PM patch is applied. That said, edge interrupts are still
being missed in mainline.
ladis
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2017-10-15 22:15 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-15 6:53 [PATCH] ARM: dts: Fix omap l4per idling with wlcore edge sensitive interrupt Reizer, Eyal
[not found] ` <8665E2433BC68541A24DFFCA87B70F5B3646AF81-1tpBd5JUCm6IQmiDNMet8wC/G2K4zDHf@public.gmane.org>
2017-10-15 16:22 ` Tony Lindgren
[not found] ` <20171015162230.GU4394-4v6yS6AI5VpBDgjK7y7TUQ@public.gmane.org>
2017-10-15 22:15 ` Ladislav Michl [this message]
2017-10-16 14:01 ` Tony Lindgren
2018-09-07 17:35 ` Tony Lindgren
-- strict thread matches above, loose matches on Subject: below --
2017-10-13 19:32 Tony Lindgren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171015221536.ybe7x52tenocel6c@lenoch \
--to=ladis-6z/3iimg2c8g8few9mqtra@public.gmane.org \
--cc=bcousson-rdvid1DuHRBWk0Htik3J/w@public.gmane.org \
--cc=d-gerlach-l0cyMroinI0@public.gmane.org \
--cc=devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=eyalr-l0cyMroinI0@public.gmane.org \
--cc=grygorii.strashko-l0cyMroinI0@public.gmane.org \
--cc=kvalo-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org \
--cc=linux-omap-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=nm-l0cyMroinI0@public.gmane.org \
--cc=t-kristo-l0cyMroinI0@public.gmane.org \
--cc=tony-4v6yS6AI5VpBDgjK7y7TUQ@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).