From mboxrd@z Thu Jan 1 00:00:00 1970 From: Maxime Ripard Subject: Re: [PATCH 2/6] ARM: sun8i: r40: add USB host port nodes for R40 Date: Mon, 16 Oct 2017 11:32:29 +0200 Message-ID: <20171016093229.waizww2n4gwn4qpw@flea.lan> References: <20171008042906.46779-1-icenowy@aosc.io> <20171008042906.46779-3-icenowy@aosc.io> <20171009210340.ak6wo3vqnwj4gom4@flea.home> <55B35500-67FC-40AA-9A07-98C843DE55B3@aosc.io> Reply-To: maxime.ripard-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="veiddsuyse3zvzmb" Return-path: Sender: linux-sunxi-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org Content-Disposition: inline In-Reply-To: <55B35500-67FC-40AA-9A07-98C843DE55B3-h8G6r0blFSE@public.gmane.org> List-Post: , List-Help: , List-Archive: , List-Unsubscribe: , To: Icenowy Zheng Cc: Chen-Yu Tsai , Kishon Vijay Abraham I , devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-sunxi-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org, Icenowy Zheng List-Id: devicetree@vger.kernel.org --veiddsuyse3zvzmb Content-Type: text/plain; charset="UTF-8" Content-Disposition: inline On Tue, Oct 10, 2017 at 07:24:28AM +0800, Icenowy Zheng wrote: > >> + interrupts = ; > >> + clocks = <&ccu CLK_BUS_OHCI1>, > >> + <&ccu CLK_BUS_EHCI1>, > >> + <&ccu CLK_USB_OHCI1>; > >> + resets = <&ccu RST_BUS_OHCI1>, > >> + <&ccu RST_BUS_EHCI1>; > > > >Why do you need to take the OHCI resources too? > > AW's strange design -- without OHCI resources taken EHCI > won't work. How has this been tested? Thanks! Maxime -- Maxime Ripard, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com --veiddsuyse3zvzmb--