From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tony Lindgren Subject: Re: [PATCH] ARM: dts: Fix omap l4per idling with wlcore edge sensitive interrupt Date: Mon, 16 Oct 2017 07:01:47 -0700 Message-ID: <20171016140147.GV4394@atomide.com> References: <8665E2433BC68541A24DFFCA87B70F5B3646AF81@DFRE01.ent.ti.com> <20171015162230.GU4394@atomide.com> <20171015221536.ybe7x52tenocel6c@lenoch> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <20171015221536.ybe7x52tenocel6c@lenoch> Sender: devicetree-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Ladislav Michl Cc: "Reizer, Eyal" , "linux-omap-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , =?utf-8?Q?Beno=C3=AEt?= Cousson , "devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , "Gerlach, Dave" , "Strashko, Grygorii" , Kalle Valo , "Menon, Nishanth" , "Kristo, Tero" List-Id: devicetree@vger.kernel.org * Ladislav Michl [171015 15:16]: > On Sun, Oct 15, 2017 at 09:22:31AM -0700, Tony Lindgren wrote: > > * Reizer, Eyal [171014 23:55]: > > > > From: Tony Lindgren [mailto:tony-4v6yS6AI5VpBDgjK7y7TUQ@public.gmane.org] > > > > > > > > On omaps, if the wlcore interrupt is configured as level instead of edge, > > > > L4PER will stop doing hardware based idling after ifconfig wlan0 down is > > > > done and the WL_EN line is pulled down. > > > > > > > Do we understand why omap is doing this? Is it a bug or a normal behavior? > > > > > > AFAIK way back edge interrupts have been used. On some omaps based boards. > > > They have used level interrupts instead due to occasional interrupts being missed > > > By the omap interrupts controller when using edge based interrupts which caused > > > Issues. This was the reason many boards are set to using level based interrupts which > > > Seemed much more robust. > > > > No idea yet why exactly the gpio modules won't idle after that. But for making > > edge interrupts behave, I suspect that Grygorii's patch "[RESEND PATCH] gpio: > > omap: Fix lost edge interrupts" fixes those issues. > > Please note, that Grygorii's patch fixes occasional edge interrupts misses > only after your PM patch is applied. That said, edge interrupts are still > being missed in mainline. I think that's for omap2 and 3 based boards. Sounds like we may have a generic test case here on omap3 for that issue. I'll do some ping tests against wl12xx on omap3-evm today while it's idling. Regards, Tony -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html