From mboxrd@z Thu Jan 1 00:00:00 1970 From: Christoph Hellwig Subject: Re: [PATCH 08/10] PCI: dwc: artpec6: add support for endpoint mode Date: Thu, 19 Oct 2017 00:59:12 -0700 Message-ID: <20171019075912.GA10089@infradead.org> References: <20171013160914.3220-1-niklas.cassel@axis.com> <20171013160914.3220-9-niklas.cassel@axis.com> <20171016234326.GM25517@bhelgaas-glaptop.roam.corp.google.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Return-path: Content-Disposition: inline In-Reply-To: <20171016234326.GM25517-1RhO1Y9PlrlHTL0Zs8A6p5iNqAH0jzoTYJqu5kTmcBRl57MIdRCFDg@public.gmane.org> Sender: devicetree-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Bjorn Helgaas Cc: Niklas Cassel , Niklas Cassel , Jesper Nilsson , Bjorn Helgaas , Rob Herring , Mark Rutland , Kishon Vijay Abraham I , Jingoo Han , Xiaowei Song , Peter Robinson , Tomasz Nowicki , Gabriele Paoloni , Duc Dang , linux-arm-kernel-VrBV9hrLPhE@public.gmane.org, linux-pci-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-Id: devicetree@vger.kernel.org On Mon, Oct 16, 2017 at 06:43:26PM -0500, Bjorn Helgaas wrote: > understand it. I guess the idea is to build pcie-artpec6.o if either > CONFIG_PCIE_ARTPEC6_HOST or CONFIG_PCIE_ARTPEC6_EP is set (or both). > > Is this really the simplest way to express that in Kconfig? Both the > "if PCIE_ARTPEC6" and this ifneq thing are complicated and relatively > unusual. I thijnk the right style is to make PCIE_ARTPEC6 a hidden kconfig symbol without help text, and then have PCIE_ARTPEC6_HOST and PCIE_ARTPEC6_EP select it. -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html