From: Thierry Reding <thierry.reding@gmail.com>
To: Lucas Stach <l.stach@pengutronix.de>, Rob Herring <robh@kernel.org>
Cc: devicetree@vger.kernel.org, kernel@pengutronix.de,
dri-devel@lists.freedesktop.org, patchwork-lst@pengutronix.de
Subject: Re: [PATCH v2] drm: panel: simple: add Toshiba LT089AC19000
Date: Thu, 19 Oct 2017 10:32:53 +0200 [thread overview]
Message-ID: <20171019083253.GB9005@ulmo> (raw)
In-Reply-To: <1508401639.11773.5.camel@pengutronix.de>
[-- Attachment #1.1: Type: text/plain, Size: 1457 bytes --]
On Thu, Oct 19, 2017 at 10:27:19AM +0200, Lucas Stach wrote:
> Am Donnerstag, den 19.10.2017, 10:17 +0200 schrieb Thierry Reding:
> > On Wed, Oct 18, 2017 at 07:22:40PM +0200, Lucas Stach wrote:
> > > Only exposes a single mode and not a complete display timing, as
> > > the datasheet is rather vague about the minimum/maximum values.
> > >
> > > > > Signed-off-by: Lucas Stach <l.stach@pengutronix.de>
> > > > > Acked-by: Rob Herring <robh@kernel.org>
> > > ---
> > > v2:
> > > - fix display size in documentation
> > > - add bus flags
> > > ---
> > > .../display/panel/toshiba,lt089ac29000.txt | 8 +++++++
> > > drivers/gpu/drm/panel/panel-simple.c | 27 ++++++++++++++++++++++
> > > 2 files changed, 35 insertions(+)
> > > create mode 100644 Documentation/devicetree/bindings/display/panel/toshiba,lt089ac29000.txt
> >
> > Separate patches are preferred for bindings and driver.
>
> This is news to me. At least in simple-panel land, I've always only
> split out additions of new vendor prefixes and kept the bindings
> together with the driver.
>
> I'll change that in the future if you prefer otherwise.
I don't mind too much either way, but I've seen Rob say he prefers
separate patches. I guess ultimately that makes it easier to move the DT
bindings outside of the kernel tree, but maybe there are other reasons,
too.
Rob, care to educate us?
Thierry
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
[-- Attachment #2: Type: text/plain, Size: 160 bytes --]
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
prev parent reply other threads:[~2017-10-19 8:32 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-18 17:22 [PATCH v2] drm: panel: simple: add Toshiba LT089AC19000 Lucas Stach
[not found] ` <20171018172240.8772-1-l.stach-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
2017-10-19 8:17 ` Thierry Reding
2017-10-19 8:27 ` Lucas Stach
2017-10-19 8:32 ` Thierry Reding [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171019083253.GB9005@ulmo \
--to=thierry.reding@gmail.com \
--cc=devicetree@vger.kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=kernel@pengutronix.de \
--cc=l.stach@pengutronix.de \
--cc=patchwork-lst@pengutronix.de \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).