devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Tony Lindgren <tony@atomide.com>
To: Rob Herring <robh@kernel.org>
Cc: Benoit Parrot <bparrot@ti.com>, Tero Kristo <t-kristo@ti.com>,
	"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	linux-omap <linux-omap@vger.kernel.org>,
	"linux-media@vger.kernel.org" <linux-media@vger.kernel.org>
Subject: Re: [Patch 4/6] dt-bindings: media: ti-vpe: Document VPE driver
Date: Thu, 19 Oct 2017 14:20:32 -0700	[thread overview]
Message-ID: <20171019212031.GI4394@atomide.com> (raw)
In-Reply-To: <CAL_Jsq+jy-JN=ppfkyexFqJsbQVw3UGdNrNBVUvmGPHBdoLGkg@mail.gmail.com>

* Rob Herring <robh@kernel.org> [171019 14:07]:
> On Wed, Oct 18, 2017 at 8:02 AM, Benoit Parrot <bparrot@ti.com> wrote:
> >> > +Example:
> >> > +   vpe {
> >> > +           compatible = "ti,vpe";
> >> > +           ti,hwmods = "vpe";
> >> > +           clocks = <&dpll_core_h23x2_ck>;
> >> > +           clock-names = "fck";
> >> > +           reg =   <0x489d0000 0x120>,
> >> > +                   <0x489d0300 0x20>,
> >> > +                   <0x489d0400 0x20>,
> >> > +                   <0x489d0500 0x20>,
> >> > +                   <0x489d0600 0x3c>,
> >> > +                   <0x489d0700 0x80>,
> >>
> >> Is there other stuff between these regions?
> >
> > No, they listed separately because each sub-region/module is
> > individually mapped and accessed using a starting 0 offset.
> 
> So you are going to use 48KB of virtual memory to map 2KB of
> registers? Because each ioremap uses 8KB (1 page plus 1 guard page)
> last time i looked (which has been a while).
> 
> But it's your platform.

We should have cached regions for all interconnects so this should
not be a problem. Worth checking that the areas are listed in
dra7xx_io_desc[] and for other SoCs too to avoid this issue.

Regards,

Tony

  reply	other threads:[~2017-10-19 21:20 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-10-12 19:27 [Patch 0/6] ARM: dts/hwmod: Add CAL and VPE nodes Benoit Parrot
2017-10-12 19:27 ` [Patch 1/6] ARM: dts: DRA72: Add CAL dtsi node Benoit Parrot
2017-10-13 16:54   ` Tony Lindgren
     [not found]     ` <20171013165408.GJ4394-4v6yS6AI5VpBDgjK7y7TUQ@public.gmane.org>
2017-10-13 16:55       ` Benoit Parrot
2017-10-12 19:27 ` [Patch 2/6] ARM: DRA7: hwmod: Add CAL nodes Benoit Parrot
     [not found]   ` <20171012192719.15193-3-bparrot-l0cyMroinI0@public.gmane.org>
2017-10-13 16:56     ` Tony Lindgren
2017-10-13 17:58       ` Benoit Parrot
2017-10-12 19:27 ` [Patch 3/6] ARM: OMAP: DRA7xx: Make CAM clock domain SWSUP only Benoit Parrot
2017-10-13 17:01   ` Tony Lindgren
     [not found]     ` <20171013170113.GL4394-4v6yS6AI5VpBDgjK7y7TUQ@public.gmane.org>
2017-10-13 17:59       ` Benoit Parrot
2017-10-13 18:03         ` Tony Lindgren
2017-10-12 19:27 ` [Patch 4/6] dt-bindings: media: ti-vpe: Document VPE driver Benoit Parrot
     [not found]   ` <20171012192719.15193-5-bparrot-l0cyMroinI0@public.gmane.org>
2017-10-17 21:00     ` Rob Herring
2017-10-18 13:02       ` Benoit Parrot
2017-10-19 21:06         ` Rob Herring
2017-10-19 21:20           ` Tony Lindgren [this message]
2017-10-12 19:27 ` [Patch 5/6] ARM: DRA7: hwmod: Add VPE nodes Benoit Parrot
2017-10-13 17:05   ` Tony Lindgren
     [not found]     ` <20171013170513.GM4394-4v6yS6AI5VpBDgjK7y7TUQ@public.gmane.org>
2017-10-13 18:05       ` Benoit Parrot
     [not found]         ` <20171013180534.GI25400-l0cyMroinI0@public.gmane.org>
2017-10-13 19:01           ` Tony Lindgren
2017-10-12 19:27 ` [Patch 6/6] ARM: dts: dra7: Add VPE dtsi node Benoit Parrot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20171019212031.GI4394@atomide.com \
    --to=tony@atomide.com \
    --cc=bparrot@ti.com \
    --cc=devicetree@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-media@vger.kernel.org \
    --cc=linux-omap@vger.kernel.org \
    --cc=robh@kernel.org \
    --cc=t-kristo@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).