From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tony Lindgren Subject: Re: [Patch 4/6] dt-bindings: media: ti-vpe: Document VPE driver Date: Thu, 19 Oct 2017 14:20:32 -0700 Message-ID: <20171019212031.GI4394@atomide.com> References: <20171012192719.15193-1-bparrot@ti.com> <20171012192719.15193-5-bparrot@ti.com> <20171017210051.6ap3yg7b7viav6cy@rob-hp-laptop> <20171018130227.GO25400@ti.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: Sender: linux-kernel-owner@vger.kernel.org To: Rob Herring Cc: Benoit Parrot , Tero Kristo , "devicetree@vger.kernel.org" , "linux-kernel@vger.kernel.org" , linux-omap , "linux-media@vger.kernel.org" List-Id: devicetree@vger.kernel.org * Rob Herring [171019 14:07]: > On Wed, Oct 18, 2017 at 8:02 AM, Benoit Parrot wrote: > >> > +Example: > >> > + vpe { > >> > + compatible = "ti,vpe"; > >> > + ti,hwmods = "vpe"; > >> > + clocks = <&dpll_core_h23x2_ck>; > >> > + clock-names = "fck"; > >> > + reg = <0x489d0000 0x120>, > >> > + <0x489d0300 0x20>, > >> > + <0x489d0400 0x20>, > >> > + <0x489d0500 0x20>, > >> > + <0x489d0600 0x3c>, > >> > + <0x489d0700 0x80>, > >> > >> Is there other stuff between these regions? > > > > No, they listed separately because each sub-region/module is > > individually mapped and accessed using a starting 0 offset. > > So you are going to use 48KB of virtual memory to map 2KB of > registers? Because each ioremap uses 8KB (1 page plus 1 guard page) > last time i looked (which has been a while). > > But it's your platform. We should have cached regions for all interconnects so this should not be a problem. Worth checking that the areas are listed in dra7xx_io_desc[] and for other SoCs too to avoid this issue. Regards, Tony