* [PATCH 0/4] ARM: dts: imx28: Update Ka-Ro TX28 dts file
@ 2017-10-11 11:05 Lothar Waßmann
2017-10-11 11:05 ` [PATCH 1/4] ARM: dts: imx28-tx28: Relicense the TX28 dts file under GPLv2/X11 Lothar Waßmann
` (4 more replies)
0 siblings, 5 replies; 13+ messages in thread
From: Lothar Waßmann @ 2017-10-11 11:05 UTC (permalink / raw)
To: Fabio Estevam, Mark Rutland, Rob Herring, Russell King,
Sascha Hauer, Shawn Guo, devicetree, linux-arm-kernel,
linux-kernel
This patch set brings the Ka-Ro electronics GmbH TX28 board support up
to date.
^ permalink raw reply [flat|nested] 13+ messages in thread* [PATCH 1/4] ARM: dts: imx28-tx28: Relicense the TX28 dts file under GPLv2/X11 2017-10-11 11:05 [PATCH 0/4] ARM: dts: imx28: Update Ka-Ro TX28 dts file Lothar Waßmann @ 2017-10-11 11:05 ` Lothar Waßmann 2017-10-11 11:05 ` [PATCH 2/4] ARM: dts: imx28-tx28: remove the regulators bus Lothar Waßmann ` (3 subsequent siblings) 4 siblings, 0 replies; 13+ messages in thread From: Lothar Waßmann @ 2017-10-11 11:05 UTC (permalink / raw) To: Fabio Estevam, Mark Rutland, Rob Herring, Russell King, Sascha Hauer, Shawn Guo, devicetree, linux-arm-kernel, linux-kernel Cc: Lothar Waßmann The current GPL only licensing on the dts file makes it very impractical for other software components licensed under another license. In order to make it easier for them to reuse our device trees, relicense our dts files first under a GPL/X11 dual-license. Signed-off-by: Lothar Waßmann <LW@KARO-electronics.de> --- arch/arm/boot/dts/imx28-tx28.dts | 42 ++++++++++++++++++++++++++++++++++------ 1 file changed, 36 insertions(+), 6 deletions(-) diff --git a/arch/arm/boot/dts/imx28-tx28.dts b/arch/arm/boot/dts/imx28-tx28.dts index 0ebbc83..319cf17 100644 --- a/arch/arm/boot/dts/imx28-tx28.dts +++ b/arch/arm/boot/dts/imx28-tx28.dts @@ -1,13 +1,43 @@ /* * Copyright 2012 Shawn Guo <shawn.guo@linaro.org> - * Copyright 2013 Lothar Waßmann <LW@KARO-electronics.de> + * Copyright 2013-2017 Lothar Waßmann <LW@KARO-electronics.de> * - * The code contained herein is licensed under the GNU General Public - * License. You may obtain a copy of the GNU General Public License - * Version 2 at the following locations: + * This file is dual-licensed: you can use it either under the terms + * of the GPL or the X11 license, at your option. Note that this dual + * licensing only applies to this file, and not this project as a + * whole. * - * http://www.opensource.org/licenses/gpl-license.html - * http://www.gnu.org/copyleft/gpl.html + * a) This file is free software; you can redistribute it and/or + * modify it under the terms of the GNU General Public License + * version 2 as published by the Free Software Foundation. + * + * This file is distributed in the hope that it will be useful, + * but WITHOUT ANY WARRANTY; without even the implied warranty of + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the + * GNU General Public License for more details. + * + * Or, alternatively, + * + * b) Permission is hereby granted, free of charge, to any person + * obtaining a copy of this software and associated documentation + * files (the "Software"), to deal in the Software without + * restriction, including without limitation the rights to use, + * copy, modify, merge, publish, distribute, sublicense, and/or + * sell copies of the Software, and to permit persons to whom the + * Software is furnished to do so, subject to the following + * conditions: + * + * The above copyright notice and this permission notice shall be + * included in all copies or substantial portions of the Software. + * + * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, + * EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES + * OF MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND + * NONINFRINGEMENT. IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT + * HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY, + * WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING + * FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR + * OTHER DEALINGS IN THE SOFTWARE. */ /dts-v1/; -- 2.1.4 _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel ^ permalink raw reply related [flat|nested] 13+ messages in thread
* [PATCH 2/4] ARM: dts: imx28-tx28: remove the regulators bus 2017-10-11 11:05 [PATCH 0/4] ARM: dts: imx28: Update Ka-Ro TX28 dts file Lothar Waßmann 2017-10-11 11:05 ` [PATCH 1/4] ARM: dts: imx28-tx28: Relicense the TX28 dts file under GPLv2/X11 Lothar Waßmann @ 2017-10-11 11:05 ` Lothar Waßmann 2017-10-11 11:05 ` [PATCH 3/4] ARM: dts: imx28-tx28: fix interrupt flags and use interrupts-extended property Lothar Waßmann ` (2 subsequent siblings) 4 siblings, 0 replies; 13+ messages in thread From: Lothar Waßmann @ 2017-10-11 11:05 UTC (permalink / raw) To: Fabio Estevam, Mark Rutland, Rob Herring, Russell King, Sascha Hauer, Shawn Guo, devicetree, linux-arm-kernel, linux-kernel Cc: Lothar Waßmann It is not recommended to place the regulator nodes inside 'simple-bus', so adjust them accordingly. The motivation for rearranging this is to make it easier to add new regulator nodes in the future. Signed-off-by: Lothar Waßmann <LW@KARO-electronics.de> --- arch/arm/boot/dts/imx28-tx28.dts | 127 ++++++++++++++++++--------------------- 1 file changed, 57 insertions(+), 70 deletions(-) diff --git a/arch/arm/boot/dts/imx28-tx28.dts b/arch/arm/boot/dts/imx28-tx28.dts index 319cf17..211e67d 100644 --- a/arch/arm/boot/dts/imx28-tx28.dts +++ b/arch/arm/boot/dts/imx28-tx28.dts @@ -75,82 +75,69 @@ status = "disabled"; }; - regulators { - compatible = "simple-bus"; - #address-cells = <1>; - #size-cells = <0>; - - reg_usb0_vbus: regulator@0 { - compatible = "regulator-fixed"; - reg = <0>; - regulator-name = "usb0_vbus"; - regulator-min-microvolt = <5000000>; - regulator-max-microvolt = <5000000>; - gpio = <&gpio0 18 GPIO_ACTIVE_HIGH>; - enable-active-high; - }; + reg_usb0_vbus: regulator-usb0-vbus { + compatible = "regulator-fixed"; + regulator-name = "usb0_vbus"; + regulator-min-microvolt = <5000000>; + regulator-max-microvolt = <5000000>; + gpio = <&gpio0 18 GPIO_ACTIVE_HIGH>; + enable-active-high; + }; - reg_usb1_vbus: regulator@1 { - compatible = "regulator-fixed"; - reg = <1>; - regulator-name = "usb1_vbus"; - regulator-min-microvolt = <5000000>; - regulator-max-microvolt = <5000000>; - gpio = <&gpio3 27 GPIO_ACTIVE_HIGH>; - enable-active-high; - }; + reg_usb1_vbus: regulator-usb1-vbus { + compatible = "regulator-fixed"; + regulator-name = "usb1_vbus"; + regulator-min-microvolt = <5000000>; + regulator-max-microvolt = <5000000>; + gpio = <&gpio3 27 GPIO_ACTIVE_HIGH>; + enable-active-high; + }; - reg_2p5v: regulator@2 { - compatible = "regulator-fixed"; - reg = <2>; - regulator-name = "2P5V"; - regulator-min-microvolt = <2500000>; - regulator-max-microvolt = <2500000>; - regulator-always-on; - }; + reg_2p5v: regulator-2p5v { + compatible = "regulator-fixed"; + regulator-name = "2P5V"; + regulator-min-microvolt = <2500000>; + regulator-max-microvolt = <2500000>; + regulator-always-on; + }; - reg_3p3v: regulator@3 { - compatible = "regulator-fixed"; - reg = <3>; - regulator-name = "3P3V"; - regulator-min-microvolt = <3300000>; - regulator-max-microvolt = <3300000>; - regulator-always-on; - }; + reg_3p3v: regulator-3p3v { + compatible = "regulator-fixed"; + regulator-name = "3P3V"; + regulator-min-microvolt = <3300000>; + regulator-max-microvolt = <3300000>; + regulator-always-on; + }; - reg_can_xcvr: regulator@4 { - compatible = "regulator-fixed"; - reg = <4>; - regulator-name = "CAN XCVR"; - regulator-min-microvolt = <3300000>; - regulator-max-microvolt = <3300000>; - gpio = <&gpio1 0 GPIO_ACTIVE_HIGH>; - pinctrl-names = "default"; - pinctrl-0 = <&tx28_flexcan_xcvr_pins>; - }; + reg_can_xcvr: regulator-can-xcvr { + compatible = "regulator-fixed"; + regulator-name = "CAN XCVR"; + regulator-min-microvolt = <3300000>; + regulator-max-microvolt = <3300000>; + gpio = <&gpio1 0 GPIO_ACTIVE_HIGH>; + pinctrl-names = "default"; + pinctrl-0 = <&tx28_flexcan_xcvr_pins>; + }; - reg_lcd: regulator@5 { - compatible = "regulator-fixed"; - reg = <5>; - regulator-name = "LCD POWER"; - regulator-min-microvolt = <3300000>; - regulator-max-microvolt = <3300000>; - gpio = <&gpio1 31 GPIO_ACTIVE_HIGH>; - enable-active-high; - }; + reg_lcd: regulator-lcd-power { + compatible = "regulator-fixed"; + regulator-name = "LCD POWER"; + regulator-min-microvolt = <3300000>; + regulator-max-microvolt = <3300000>; + gpio = <&gpio1 31 GPIO_ACTIVE_HIGH>; + enable-active-high; + }; - reg_lcd_reset: regulator@6 { - compatible = "regulator-fixed"; - reg = <6>; - regulator-name = "LCD RESET"; - regulator-min-microvolt = <3300000>; - regulator-max-microvolt = <3300000>; - gpio = <&gpio3 30 GPIO_ACTIVE_HIGH>; - startup-delay-us = <300000>; - enable-active-high; - regulator-always-on; - regulator-boot-on; - }; + reg_lcd_reset: regulator-lcd-reset { + compatible = "regulator-fixed"; + regulator-name = "LCD RESET"; + regulator-min-microvolt = <3300000>; + regulator-max-microvolt = <3300000>; + gpio = <&gpio3 30 GPIO_ACTIVE_HIGH>; + startup-delay-us = <300000>; + enable-active-high; + regulator-always-on; + regulator-boot-on; }; clocks { -- 2.1.4 _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel ^ permalink raw reply related [flat|nested] 13+ messages in thread
* [PATCH 3/4] ARM: dts: imx28-tx28: fix interrupt flags and use interrupts-extended property 2017-10-11 11:05 [PATCH 0/4] ARM: dts: imx28: Update Ka-Ro TX28 dts file Lothar Waßmann 2017-10-11 11:05 ` [PATCH 1/4] ARM: dts: imx28-tx28: Relicense the TX28 dts file under GPLv2/X11 Lothar Waßmann 2017-10-11 11:05 ` [PATCH 2/4] ARM: dts: imx28-tx28: remove the regulators bus Lothar Waßmann @ 2017-10-11 11:05 ` Lothar Waßmann [not found] ` <1507719939-27250-4-git-send-email-LW-bxm8fMRDkQLDiMYJYoSAnRvVK+yQ3ZXh@public.gmane.org> 2017-10-11 11:05 ` [PATCH 4/4] ARM: dts: imx28-tx28: add trickle-charge config for DS1339 Lothar Waßmann [not found] ` <1507719939-27250-1-git-send-email-LW-bxm8fMRDkQLDiMYJYoSAnRvVK+yQ3ZXh@public.gmane.org> 4 siblings, 1 reply; 13+ messages in thread From: Lothar Waßmann @ 2017-10-11 11:05 UTC (permalink / raw) To: Fabio Estevam, Mark Rutland, Rob Herring, Russell King, Sascha Hauer, Shawn Guo, devicetree, linux-arm-kernel, linux-kernel Cc: Lothar Waßmann Use the correct interrupt flags and change the 'interrupt-parent', 'interrupts' property pairs to 'interrupts-extended'. Signed-off-by: Lothar Waßmann <LW@KARO-electronics.de> --- arch/arm/boot/dts/imx28-tx28.dts | 9 +++------ 1 file changed, 3 insertions(+), 6 deletions(-) diff --git a/arch/arm/boot/dts/imx28-tx28.dts b/arch/arm/boot/dts/imx28-tx28.dts index 211e67d..3c852f7 100644 --- a/arch/arm/boot/dts/imx28-tx28.dts +++ b/arch/arm/boot/dts/imx28-tx28.dts @@ -328,8 +328,7 @@ reg = <0x20>; pinctrl-names = "default"; pinctrl-0 = <&tx28_pca9554_pins>; - interrupt-parent = <&gpio3>; - interrupts = <28 0>; + interrupts-extended = <&gpio3 28 IRQ_TYPE_NONE>; gpio-controller; #gpio-cells = <2>; interrupt-controller; @@ -341,8 +340,7 @@ reg = <0x38>; pinctrl-names = "default"; pinctrl-0 = <&tx28_edt_ft5x06_pins>; - interrupt-parent = <&gpio2>; - interrupts = <5 IRQ_TYPE_EDGE_FALLING>; + interrupts-extended = <&gpio2 5 IRQ_TYPE_EDGE_FALLING>; reset-gpios = <&gpio2 6 GPIO_ACTIVE_LOW>; wake-gpios = <&gpio4 9 GPIO_ACTIVE_HIGH>; }; @@ -352,8 +350,7 @@ reg = <0x48>; pinctrl-names = "default"; pinctrl-0 = <&tx28_tsc2007_pins>; - interrupt-parent = <&gpio3>; - interrupts = <20 0>; + interrupts-extended = <&gpio3 20 IRQ_TYPE_EDGE_FALLING>; pendown-gpio = <&gpio3 20 GPIO_ACTIVE_LOW>; ti,x-plate-ohms = /bits/ 16 <660>; }; -- 2.1.4 _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel ^ permalink raw reply related [flat|nested] 13+ messages in thread
[parent not found: <1507719939-27250-4-git-send-email-LW-bxm8fMRDkQLDiMYJYoSAnRvVK+yQ3ZXh@public.gmane.org>]
* Re: [PATCH 3/4] ARM: dts: imx28-tx28: fix interrupt flags and use interrupts-extended property [not found] ` <1507719939-27250-4-git-send-email-LW-bxm8fMRDkQLDiMYJYoSAnRvVK+yQ3ZXh@public.gmane.org> @ 2017-10-16 7:17 ` Uwe Kleine-König 2017-10-16 8:56 ` Lothar Waßmann 0 siblings, 1 reply; 13+ messages in thread From: Uwe Kleine-König @ 2017-10-16 7:17 UTC (permalink / raw) To: Lothar Waßmann Cc: Fabio Estevam, Mark Rutland, Rob Herring, Russell King, Sascha Hauer, Shawn Guo, devicetree-u79uwXL29TY76Z2rM5mHXA, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r, linux-kernel-u79uwXL29TY76Z2rM5mHXA Hello, On Wed, Oct 11, 2017 at 01:05:38PM +0200, Lothar Waßmann wrote: > diff --git a/arch/arm/boot/dts/imx28-tx28.dts b/arch/arm/boot/dts/imx28-tx28.dts > index 211e67d..3c852f7 100644 > --- a/arch/arm/boot/dts/imx28-tx28.dts > +++ b/arch/arm/boot/dts/imx28-tx28.dts > @@ -328,8 +328,7 @@ > reg = <0x20>; > pinctrl-names = "default"; > pinctrl-0 = <&tx28_pca9554_pins>; > - interrupt-parent = <&gpio3>; > - interrupts = <28 0>; > + interrupts-extended = <&gpio3 28 IRQ_TYPE_NONE>; > gpio-controller; > #gpio-cells = <2>; > interrupt-controller; While interrupts-extended looks nice, Documentation/devicetree/bindings/interrupt-controller/interrupts.txt has: "interrupts-extended" should only be used when a device has multiple interrupt parents. If this is still true, this patch is wrong. Best regards Uwe -- Pengutronix e.K. | Uwe Kleine-König | Industrial Linux Solutions | http://www.pengutronix.de/ | -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html ^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [PATCH 3/4] ARM: dts: imx28-tx28: fix interrupt flags and use interrupts-extended property 2017-10-16 7:17 ` Uwe Kleine-König @ 2017-10-16 8:56 ` Lothar Waßmann [not found] ` <20171016105632.709e653c-AvR2QvxeiV7DiMYJYoSAnRvVK+yQ3ZXh@public.gmane.org> 2017-10-18 2:13 ` [PATCH 3/4] ARM: dts: imx28-tx28: fix interrupt flags and use interrupts-extended property Shawn Guo 0 siblings, 2 replies; 13+ messages in thread From: Lothar Waßmann @ 2017-10-16 8:56 UTC (permalink / raw) To: Uwe Kleine-König Cc: Fabio Estevam, Mark Rutland, Rob Herring, Russell King, Sascha Hauer, Shawn Guo, devicetree, linux-arm-kernel, linux-kernel Hi, On Mon, 16 Oct 2017 09:17:26 +0200 Uwe Kleine-König wrote: > Hello, > > On Wed, Oct 11, 2017 at 01:05:38PM +0200, Lothar Waßmann wrote: > > diff --git a/arch/arm/boot/dts/imx28-tx28.dts b/arch/arm/boot/dts/imx28-tx28.dts > > index 211e67d..3c852f7 100644 > > --- a/arch/arm/boot/dts/imx28-tx28.dts > > +++ b/arch/arm/boot/dts/imx28-tx28.dts > > @@ -328,8 +328,7 @@ > > reg = <0x20>; > > pinctrl-names = "default"; > > pinctrl-0 = <&tx28_pca9554_pins>; > > - interrupt-parent = <&gpio3>; > > - interrupts = <28 0>; > > + interrupts-extended = <&gpio3 28 IRQ_TYPE_NONE>; > > gpio-controller; > > #gpio-cells = <2>; > > interrupt-controller; > > While interrupts-extended looks nice, > Documentation/devicetree/bindings/interrupt-controller/interrupts.txt > has: > > "interrupts-extended" should only be used when a device has > multiple interrupt parents. > > If this is still true, this patch is wrong. > Thanks for the hint. It really helps to read the documentation sometimes, rahter than relying on existing code only... A quick check shows, that more than 100 of the 130 uses of interrupts-extended are wrong. :( Lothar Waßmann ^ permalink raw reply [flat|nested] 13+ messages in thread
[parent not found: <20171016105632.709e653c-AvR2QvxeiV7DiMYJYoSAnRvVK+yQ3ZXh@public.gmane.org>]
* interrupts-extended only allowed with different parents? [Was: Re: [PATCH 3/4] ARM: dts: imx28-tx28: fix interrupt flags and use interrupts-extended property] [not found] ` <20171016105632.709e653c-AvR2QvxeiV7DiMYJYoSAnRvVK+yQ3ZXh@public.gmane.org> @ 2017-10-16 9:03 ` Uwe Kleine-König 2017-10-16 21:29 ` Rob Herring 0 siblings, 1 reply; 13+ messages in thread From: Uwe Kleine-König @ 2017-10-16 9:03 UTC (permalink / raw) To: Lothar Waßmann Cc: Fabio Estevam, Mark Rutland, Rob Herring, Russell King, Sascha Hauer, Shawn Guo, devicetree-u79uwXL29TY76Z2rM5mHXA, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r, linux-kernel-u79uwXL29TY76Z2rM5mHXA On Mon, Oct 16, 2017 at 10:56:32AM +0200, Lothar Waßmann wrote: > Hi, > > On Mon, 16 Oct 2017 09:17:26 +0200 Uwe Kleine-König wrote: > > Hello, > > > > On Wed, Oct 11, 2017 at 01:05:38PM +0200, Lothar Waßmann wrote: > > > diff --git a/arch/arm/boot/dts/imx28-tx28.dts b/arch/arm/boot/dts/imx28-tx28.dts > > > index 211e67d..3c852f7 100644 > > > --- a/arch/arm/boot/dts/imx28-tx28.dts > > > +++ b/arch/arm/boot/dts/imx28-tx28.dts > > > @@ -328,8 +328,7 @@ > > > reg = <0x20>; > > > pinctrl-names = "default"; > > > pinctrl-0 = <&tx28_pca9554_pins>; > > > - interrupt-parent = <&gpio3>; > > > - interrupts = <28 0>; > > > + interrupts-extended = <&gpio3 28 IRQ_TYPE_NONE>; > > > gpio-controller; > > > #gpio-cells = <2>; > > > interrupt-controller; > > > > While interrupts-extended looks nice, > > Documentation/devicetree/bindings/interrupt-controller/interrupts.txt > > has: > > > > "interrupts-extended" should only be used when a device has > > multiple interrupt parents. > > > > If this is still true, this patch is wrong. > > > Thanks for the hint. It really helps to read the documentation > sometimes, rahter than relying on existing code only... > > A quick check shows, that more than 100 of the 130 uses of > interrupts-extended are wrong. :( That's why I honestly consider that these documentation bits are stale. I adapted the Subject to maybe catch the attention of the devicetree guys. (BTW: The current wording is likely imprecise. I'd expect that it really should mean "Use interrupt-parent + interrupts if possible", but the following still fulfills the documented condition: interrupts-extended = <&gpio3 28 IRQ_TYPE_NONE &gpio3 29 IRQ_TYPE_NONE> while it can be expressed without interrupts-extended.) Best regards Uwe -- Pengutronix e.K. | Uwe Kleine-König | Industrial Linux Solutions | http://www.pengutronix.de/ | -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html ^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: interrupts-extended only allowed with different parents? [Was: Re: [PATCH 3/4] ARM: dts: imx28-tx28: fix interrupt flags and use interrupts-extended property] 2017-10-16 9:03 ` interrupts-extended only allowed with different parents? [Was: Re: [PATCH 3/4] ARM: dts: imx28-tx28: fix interrupt flags and use interrupts-extended property] Uwe Kleine-König @ 2017-10-16 21:29 ` Rob Herring 0 siblings, 0 replies; 13+ messages in thread From: Rob Herring @ 2017-10-16 21:29 UTC (permalink / raw) To: Uwe Kleine-König Cc: Lothar Waßmann, Fabio Estevam, Mark Rutland, Russell King, Sascha Hauer, Shawn Guo, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org On Mon, Oct 16, 2017 at 4:03 AM, Uwe Kleine-König <u.kleine-koenig@pengutronix.de> wrote: > On Mon, Oct 16, 2017 at 10:56:32AM +0200, Lothar Waßmann wrote: >> Hi, >> >> On Mon, 16 Oct 2017 09:17:26 +0200 Uwe Kleine-König wrote: >> > Hello, >> > >> > On Wed, Oct 11, 2017 at 01:05:38PM +0200, Lothar Waßmann wrote: >> > > diff --git a/arch/arm/boot/dts/imx28-tx28.dts b/arch/arm/boot/dts/imx28-tx28.dts >> > > index 211e67d..3c852f7 100644 >> > > --- a/arch/arm/boot/dts/imx28-tx28.dts >> > > +++ b/arch/arm/boot/dts/imx28-tx28.dts >> > > @@ -328,8 +328,7 @@ >> > > reg = <0x20>; >> > > pinctrl-names = "default"; >> > > pinctrl-0 = <&tx28_pca9554_pins>; >> > > - interrupt-parent = <&gpio3>; >> > > - interrupts = <28 0>; >> > > + interrupts-extended = <&gpio3 28 IRQ_TYPE_NONE>; >> > > gpio-controller; >> > > #gpio-cells = <2>; >> > > interrupt-controller; >> > >> > While interrupts-extended looks nice, >> > Documentation/devicetree/bindings/interrupt-controller/interrupts.txt >> > has: >> > >> > "interrupts-extended" should only be used when a device has >> > multiple interrupt parents. >> > >> > If this is still true, this patch is wrong. >> > >> Thanks for the hint. It really helps to read the documentation >> sometimes, rahter than relying on existing code only... >> >> A quick check shows, that more than 100 of the 130 uses of >> interrupts-extended are wrong. :( > > That's why I honestly consider that these documentation bits are stale. > I adapted the Subject to maybe catch the attention of the devicetree > guys. The documentation is correct as that is recommended practice IMO. I wouldn't go fixing the 100 cases found either. > (BTW: The current wording is likely imprecise. I'd expect that it really > should mean "Use interrupt-parent + interrupts if possible", but the > following still fulfills the documented condition: "should" is pretty standard to mean recommended vs. "shall" or "must" meaning required. Rob ^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [PATCH 3/4] ARM: dts: imx28-tx28: fix interrupt flags and use interrupts-extended property 2017-10-16 8:56 ` Lothar Waßmann [not found] ` <20171016105632.709e653c-AvR2QvxeiV7DiMYJYoSAnRvVK+yQ3ZXh@public.gmane.org> @ 2017-10-18 2:13 ` Shawn Guo 2017-10-18 6:40 ` Lothar Waßmann 1 sibling, 1 reply; 13+ messages in thread From: Shawn Guo @ 2017-10-18 2:13 UTC (permalink / raw) To: Lothar Waßmann Cc: Uwe Kleine-König, Fabio Estevam, Mark Rutland, Rob Herring, Russell King, Sascha Hauer, devicetree, linux-arm-kernel, linux-kernel On Mon, Oct 16, 2017 at 10:56:32AM +0200, Lothar Waßmann wrote: > Hi, > > On Mon, 16 Oct 2017 09:17:26 +0200 Uwe Kleine-König wrote: > > Hello, > > > > On Wed, Oct 11, 2017 at 01:05:38PM +0200, Lothar Waßmann wrote: > > > diff --git a/arch/arm/boot/dts/imx28-tx28.dts b/arch/arm/boot/dts/imx28-tx28.dts > > > index 211e67d..3c852f7 100644 > > > --- a/arch/arm/boot/dts/imx28-tx28.dts > > > +++ b/arch/arm/boot/dts/imx28-tx28.dts > > > @@ -328,8 +328,7 @@ > > > reg = <0x20>; > > > pinctrl-names = "default"; > > > pinctrl-0 = <&tx28_pca9554_pins>; > > > - interrupt-parent = <&gpio3>; > > > - interrupts = <28 0>; > > > + interrupts-extended = <&gpio3 28 IRQ_TYPE_NONE>; > > > gpio-controller; > > > #gpio-cells = <2>; > > > interrupt-controller; > > > > While interrupts-extended looks nice, > > Documentation/devicetree/bindings/interrupt-controller/interrupts.txt > > has: > > > > "interrupts-extended" should only be used when a device has > > multiple interrupt parents. > > > > If this is still true, this patch is wrong. > > > Thanks for the hint. It really helps to read the documentation > sometimes, rahter than relying on existing code only... > > A quick check shows, that more than 100 of the 130 uses of > interrupts-extended are wrong. :( So should I drop all interrupts-extended patches from you? Shawn ^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [PATCH 3/4] ARM: dts: imx28-tx28: fix interrupt flags and use interrupts-extended property 2017-10-18 2:13 ` [PATCH 3/4] ARM: dts: imx28-tx28: fix interrupt flags and use interrupts-extended property Shawn Guo @ 2017-10-18 6:40 ` Lothar Waßmann 2017-10-23 0:20 ` Shawn Guo 0 siblings, 1 reply; 13+ messages in thread From: Lothar Waßmann @ 2017-10-18 6:40 UTC (permalink / raw) To: Shawn Guo Cc: Uwe Kleine-König, Fabio Estevam, Mark Rutland, Rob Herring, Russell King, Sascha Hauer, devicetree-u79uwXL29TY76Z2rM5mHXA, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r, linux-kernel-u79uwXL29TY76Z2rM5mHXA Hi, On Wed, 18 Oct 2017 10:13:32 +0800 Shawn Guo wrote: > On Mon, Oct 16, 2017 at 10:56:32AM +0200, Lothar Waßmann wrote: > > Hi, > > > > On Mon, 16 Oct 2017 09:17:26 +0200 Uwe Kleine-König wrote: > > > Hello, > > > > > > On Wed, Oct 11, 2017 at 01:05:38PM +0200, Lothar Waßmann wrote: > > > > diff --git a/arch/arm/boot/dts/imx28-tx28.dts b/arch/arm/boot/dts/imx28-tx28.dts > > > > index 211e67d..3c852f7 100644 > > > > --- a/arch/arm/boot/dts/imx28-tx28.dts > > > > +++ b/arch/arm/boot/dts/imx28-tx28.dts > > > > @@ -328,8 +328,7 @@ > > > > reg = <0x20>; > > > > pinctrl-names = "default"; > > > > pinctrl-0 = <&tx28_pca9554_pins>; > > > > - interrupt-parent = <&gpio3>; > > > > - interrupts = <28 0>; > > > > + interrupts-extended = <&gpio3 28 IRQ_TYPE_NONE>; > > > > gpio-controller; > > > > #gpio-cells = <2>; > > > > interrupt-controller; > > > > > > While interrupts-extended looks nice, > > > Documentation/devicetree/bindings/interrupt-controller/interrupts.txt > > > has: > > > > > > "interrupts-extended" should only be used when a device has > > > multiple interrupt parents. > > > > > > If this is still true, this patch is wrong. > > > > > Thanks for the hint. It really helps to read the documentation > > sometimes, rahter than relying on existing code only... > > > > A quick check shows, that more than 100 of the 130 uses of > > interrupts-extended are wrong. :( > > So should I drop all interrupts-extended patches from you? > Yes, please. Since this patch, and the corresponding patch for tx53 also fixed the interrupt flags, I will send new patches to only fix the interrupt flags. Lothar Waßmann -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html ^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [PATCH 3/4] ARM: dts: imx28-tx28: fix interrupt flags and use interrupts-extended property 2017-10-18 6:40 ` Lothar Waßmann @ 2017-10-23 0:20 ` Shawn Guo 0 siblings, 0 replies; 13+ messages in thread From: Shawn Guo @ 2017-10-23 0:20 UTC (permalink / raw) To: Lothar Waßmann Cc: Uwe Kleine-König, Fabio Estevam, Mark Rutland, Rob Herring, Russell King, Sascha Hauer, devicetree, linux-arm-kernel, linux-kernel On Wed, Oct 18, 2017 at 08:40:59AM +0200, Lothar Waßmann wrote: > > So should I drop all interrupts-extended patches from you? > > > Yes, please. Since this patch, and the corresponding patch for tx53 > also fixed the interrupt flags, I will send new patches to only fix > the interrupt flags. Okay, the following two got dropped from imx/dt branch. ARM: dts: imx28-tx28: fix interrupt flags and use interrupts-extended property ARM: dts: imx53-tx53: fix interrupt flags and use interrupts-extended property Shawn ^ permalink raw reply [flat|nested] 13+ messages in thread
* [PATCH 4/4] ARM: dts: imx28-tx28: add trickle-charge config for DS1339 2017-10-11 11:05 [PATCH 0/4] ARM: dts: imx28: Update Ka-Ro TX28 dts file Lothar Waßmann ` (2 preceding siblings ...) 2017-10-11 11:05 ` [PATCH 3/4] ARM: dts: imx28-tx28: fix interrupt flags and use interrupts-extended property Lothar Waßmann @ 2017-10-11 11:05 ` Lothar Waßmann [not found] ` <1507719939-27250-1-git-send-email-LW-bxm8fMRDkQLDiMYJYoSAnRvVK+yQ3ZXh@public.gmane.org> 4 siblings, 0 replies; 13+ messages in thread From: Lothar Waßmann @ 2017-10-11 11:05 UTC (permalink / raw) To: Fabio Estevam, Mark Rutland, Rob Herring, Russell King, Sascha Hauer, Shawn Guo, devicetree, linux-arm-kernel, linux-kernel Cc: Lothar Waßmann As the DS1339 driver now supports enabling the trickle charge feature via DTB, add the appropriate properties to utilize this feature. Signed-off-by: Lothar Waßmann <LW@KARO-electronics.de> --- arch/arm/boot/dts/imx28-tx28.dts | 2 ++ 1 file changed, 2 insertions(+) diff --git a/arch/arm/boot/dts/imx28-tx28.dts b/arch/arm/boot/dts/imx28-tx28.dts index 3c852f7..4684d2f 100644 --- a/arch/arm/boot/dts/imx28-tx28.dts +++ b/arch/arm/boot/dts/imx28-tx28.dts @@ -358,6 +358,8 @@ ds1339: rtc@68 { compatible = "mxim,ds1339"; reg = <0x68>; + trickle-resistor-ohms = <250>; + trickle-diode-disable; }; }; -- 2.1.4 _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel ^ permalink raw reply related [flat|nested] 13+ messages in thread
[parent not found: <1507719939-27250-1-git-send-email-LW-bxm8fMRDkQLDiMYJYoSAnRvVK+yQ3ZXh@public.gmane.org>]
* Re: [PATCH 0/4] ARM: dts: imx28: Update Ka-Ro TX28 dts file [not found] ` <1507719939-27250-1-git-send-email-LW-bxm8fMRDkQLDiMYJYoSAnRvVK+yQ3ZXh@public.gmane.org> @ 2017-10-14 15:08 ` Shawn Guo 0 siblings, 0 replies; 13+ messages in thread From: Shawn Guo @ 2017-10-14 15:08 UTC (permalink / raw) To: Lothar Waßmann Cc: Fabio Estevam, Mark Rutland, Rob Herring, Russell King, Sascha Hauer, devicetree-u79uwXL29TY76Z2rM5mHXA, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r, linux-kernel-u79uwXL29TY76Z2rM5mHXA On Wed, Oct 11, 2017 at 01:05:35PM +0200, Lothar Waßmann wrote: > This patch set brings the Ka-Ro electronics GmbH TX28 board support up > to date. Applied all, thanks. -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html ^ permalink raw reply [flat|nested] 13+ messages in thread
end of thread, other threads:[~2017-10-23 0:20 UTC | newest]
Thread overview: 13+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-10-11 11:05 [PATCH 0/4] ARM: dts: imx28: Update Ka-Ro TX28 dts file Lothar Waßmann
2017-10-11 11:05 ` [PATCH 1/4] ARM: dts: imx28-tx28: Relicense the TX28 dts file under GPLv2/X11 Lothar Waßmann
2017-10-11 11:05 ` [PATCH 2/4] ARM: dts: imx28-tx28: remove the regulators bus Lothar Waßmann
2017-10-11 11:05 ` [PATCH 3/4] ARM: dts: imx28-tx28: fix interrupt flags and use interrupts-extended property Lothar Waßmann
[not found] ` <1507719939-27250-4-git-send-email-LW-bxm8fMRDkQLDiMYJYoSAnRvVK+yQ3ZXh@public.gmane.org>
2017-10-16 7:17 ` Uwe Kleine-König
2017-10-16 8:56 ` Lothar Waßmann
[not found] ` <20171016105632.709e653c-AvR2QvxeiV7DiMYJYoSAnRvVK+yQ3ZXh@public.gmane.org>
2017-10-16 9:03 ` interrupts-extended only allowed with different parents? [Was: Re: [PATCH 3/4] ARM: dts: imx28-tx28: fix interrupt flags and use interrupts-extended property] Uwe Kleine-König
2017-10-16 21:29 ` Rob Herring
2017-10-18 2:13 ` [PATCH 3/4] ARM: dts: imx28-tx28: fix interrupt flags and use interrupts-extended property Shawn Guo
2017-10-18 6:40 ` Lothar Waßmann
2017-10-23 0:20 ` Shawn Guo
2017-10-11 11:05 ` [PATCH 4/4] ARM: dts: imx28-tx28: add trickle-charge config for DS1339 Lothar Waßmann
[not found] ` <1507719939-27250-1-git-send-email-LW-bxm8fMRDkQLDiMYJYoSAnRvVK+yQ3ZXh@public.gmane.org>
2017-10-14 15:08 ` [PATCH 0/4] ARM: dts: imx28: Update Ka-Ro TX28 dts file Shawn Guo
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).