From: Maxime Ripard <maxime.ripard@free-electrons.com>
To: Corentin Labbe <clabbe.montjoie@gmail.com>
Cc: robh+dt@kernel.org, mark.rutland@arm.com, wens@csie.org,
linux@armlinux.org.uk, catalin.marinas@arm.com,
will.deacon@arm.com, netdev@vger.kernel.org,
devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v10 0/8] net: stmmac: dwmac-sun8i: Handle integrated PHY
Date: Tue, 31 Oct 2017 14:33:15 +0100 [thread overview]
Message-ID: <20171031133315.qe74frvm6gt3qsta@flea> (raw)
In-Reply-To: <20171031081915.18960-1-clabbe.montjoie@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 1690 bytes --]
On Tue, Oct 31, 2017 at 09:19:07AM +0100, Corentin Labbe wrote:
> Hello
>
> The current way to find if the PHY is internal is to compare DT phy-mode
> and emac_variant/internal_phy.
> But it will negate a possible future SoC where an external PHY use the
> same phy mode than the integrated one.
>
> This patchs series adds a new way to handle this problem via a mdio-mux.
>
> The first try was to create a new MDIO mux "mdio-mux-syscon".
> mdio-mux-syscon working the same way than mdio-mux-mmioreg with the exception
> that the register is used via syscon/regmap.
> But this solution does not work for two reason:
> - changing the MDIO selection need the reset of MAC which cannot be done by the
> mdio-mux-syscon driver
> - There were driver loading order problem:
> - mdio-mux-syscon needing that stmmac register the parent MDIO
> - stmmac needing that child MDIO was registered just after registering parent MDIO
>
> So we cannot use any external MDIO-mux.
>
> The final solution was to represent the mdio-mux in MAC node and let
> the MAC handle all things.
>
> Since DT bits was reverted in 4.13, this patch series include the
> revert of the revert.
>
> I have let patch splited for easy review. (for seeing what's new)
> But the final serie could have some patch squashed if someone want.
> Like squashing patch and 1 and 2 (documentation)
Applied the patches, and I'll send a PR for it tomorrow after one
linux-next run.
Hopefully it will be merged in time for 4.15.
Thanks for your persistence,
Maxime
--
Maxime Ripard, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 801 bytes --]
prev parent reply other threads:[~2017-10-31 13:33 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-31 8:19 [PATCH v10 0/8] net: stmmac: dwmac-sun8i: Handle integrated PHY Corentin Labbe
2017-10-31 8:19 ` [PATCH v10 1/8] dt-bindings: net: Restore sun8i dwmac binding Corentin Labbe
2017-10-31 8:19 ` [PATCH v10 2/8] dt-bindings: net: dwmac-sun8i: update documentation about integrated PHY Corentin Labbe
[not found] ` <20171031081915.18960-3-clabbe.montjoie-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2017-11-01 20:09 ` Rob Herring
2017-10-31 8:19 ` [PATCH v10 3/8] arm: dts: sunxi: h3/h5: Restore EMAC changes Corentin Labbe
2017-10-31 8:19 ` [PATCH v10 4/8] ARM: dts: sunxi: h3/h5: represent the mdio switch used by sun8i-h3-emac Corentin Labbe
2017-10-31 8:19 ` [PATCH v10 5/8] ARM: dts: sunxi: Restore EMAC changes (boards) Corentin Labbe
2017-11-17 19:45 ` Philipp Rossak
2017-11-17 19:56 ` Philipp Rossak
[not found] ` <20171031081915.18960-6-clabbe.montjoie-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2017-11-17 20:05 ` Philipp Rossak
2017-10-31 8:19 ` [PATCH v10 6/8] arm64: dts: allwinner: A64: Restore EMAC changes Corentin Labbe
2017-10-31 8:19 ` [PATCH v10 7/8] arm64: dts: allwinner: H5: " Corentin Labbe
2017-10-31 8:19 ` [PATCH v10 8/8] arm64: dts: allwinner: add snps,dwmac-mdio compatible to emac/mdio Corentin Labbe
2017-10-31 13:33 ` Maxime Ripard [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171031133315.qe74frvm6gt3qsta@flea \
--to=maxime.ripard@free-electrons.com \
--cc=catalin.marinas@arm.com \
--cc=clabbe.montjoie@gmail.com \
--cc=devicetree@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=mark.rutland@arm.com \
--cc=netdev@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=wens@csie.org \
--cc=will.deacon@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).