From: Lee Jones <lee.jones@linaro.org>
To: Baolin Wang <baolin.wang@spreadtrum.com>
Cc: robh+dt@kernel.org, mark.rutland@arm.com,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
broonie@kernel.org, baolin.wang@linaro.org
Subject: Re: [PATCH v4 2/2] mfd: Add Spreadtrum SC27xx series PMICs driver
Date: Wed, 1 Nov 2017 09:27:03 +0000 [thread overview]
Message-ID: <20171101092703.i5t7ejuhcs45cchw@dell> (raw)
In-Reply-To: <0806380ab2674f78f925b9015e558ffb634f11f1.1509503569.git.baolin.wang@spreadtrum.com>
On Wed, 01 Nov 2017, Baolin Wang wrote:
> This patch adds support for Spreadtrum SC27xx series PMIC MFD core, and It
> provides communication through the SPI interfaces. The SC27xx series PMICs
> contains the following 6 major components:
> - DCDCs
> - LDOs
> - Battery management system
> - Audio codec
> - User interface function, such as indicator, flash LED
> - IC level function, such as power on/off, type-c
>
> Signed-off-by: Baolin Wang <baolin.wang@spreadtrum.com>
> ---
> Changes since v3:
> - Use memcpy() to copy register offset address into SPI buffer.
>
> Changes since v2:
> - Add more help information.
> - Define macros for irq base and irq number.
> - Use devm_mfd_add_devices() instead of mfd_add_devices(), which means
> we can remove sprd_pmic_remove().
> - Rename local variables in sprd_pmic_probe().
>
> Changes since v1:
> - Add more documentation to introduce Spreadtrum SC27xx series PMICs.
> - Modify compatile string property.
> - Modify reg property.
> - Remove redundant 'pmic' label.
> - Change 'should be' to 'must be' for cells properties.
> ---
> drivers/mfd/Kconfig | 16 +++
> drivers/mfd/Makefile | 1 +
> drivers/mfd/sprd-sc27xx-spi.c | 259 +++++++++++++++++++++++++++++++++++++++++
> 3 files changed, 276 insertions(+)
> create mode 100644 drivers/mfd/sprd-sc27xx-spi.c
Applied, thanks.
--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
next prev parent reply other threads:[~2017-11-01 9:27 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-01 2:32 [PATCH v4 1/2] dt-bindings: mfd: Add Spreadtrum SC27xx PMIC documentation Baolin Wang
[not found] ` <c92b97145628e5f8db410d1916da46a4c9fecf8c.1509503569.git.baolin.wang-lxIno14LUO0EEoCn2XhGlw@public.gmane.org>
2017-11-01 2:32 ` [PATCH v4 2/2] mfd: Add Spreadtrum SC27xx series PMICs driver Baolin Wang
2017-11-01 9:27 ` Lee Jones [this message]
2017-11-01 9:33 ` Baolin Wang
2017-11-01 9:26 ` [PATCH v4 1/2] dt-bindings: mfd: Add Spreadtrum SC27xx PMIC documentation Lee Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171101092703.i5t7ejuhcs45cchw@dell \
--to=lee.jones@linaro.org \
--cc=baolin.wang@linaro.org \
--cc=baolin.wang@spreadtrum.com \
--cc=broonie@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).