devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Joel Stanley <joel@jms.id.au>
To: Guenter Roeck <linux@roeck-us.net>, Rob Herring <robh+dt@kernel.org>
Cc: Philipp Zabel <philipp.zabel@gmail.com>,
	Mykola Kostenok <c_mykolak@mellanox.com>,
	Jaghathiswari Rankappagounder Natarajan <jaghu@google.com>,
	Patrick Venture <venture@google.com>,
	Andrew Jeffery <andrew@aj.id.au>,
	devicetree@vger.kernel.org, linux-hwmon@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: [PATCH v2 3/3] dt-bindings: hwmon: aspeed-pwm-tacho: Add reset node
Date: Thu,  2 Nov 2017 14:53:49 +1100	[thread overview]
Message-ID: <20171102035349.1902-4-joel@jms.id.au> (raw)
In-Reply-To: <20171102035349.1902-1-joel@jms.id.au>

The device tree bindings are updated to document the resets phandle, and
the example is updated to match what is expected for both the reset and
clock phandle.

Note that the bindings should have always had the reset controller, as
the hardware is unusable without it.

Signed-off-by: Joel Stanley <joel@jms.id.au>
---
 .../devicetree/bindings/hwmon/aspeed-pwm-tacho.txt         | 14 +++++---------
 1 file changed, 5 insertions(+), 9 deletions(-)

diff --git a/Documentation/devicetree/bindings/hwmon/aspeed-pwm-tacho.txt b/Documentation/devicetree/bindings/hwmon/aspeed-pwm-tacho.txt
index 367c8203213b..3ac02988a1a5 100644
--- a/Documentation/devicetree/bindings/hwmon/aspeed-pwm-tacho.txt
+++ b/Documentation/devicetree/bindings/hwmon/aspeed-pwm-tacho.txt
@@ -22,8 +22,9 @@ Required properties for pwm-tacho node:
 - compatible : should be "aspeed,ast2400-pwm-tacho" for AST2400 and
 	       "aspeed,ast2500-pwm-tacho" for AST2500.
 
-- clocks : a fixed clock providing input clock frequency(PWM
-	   and Fan Tach clock)
+- clocks : phandle to clock provider with the clock number in the second cell
+
+- resets : phandle to reset controller with the reset number in the second cell
 
 fan subnode format:
 ===================
@@ -48,19 +49,14 @@ Required properties for each child node:
 
 Examples:
 
-pwm_tacho_fixed_clk: fixedclk {
-	compatible = "fixed-clock";
-	#clock-cells = <0>;
-	clock-frequency = <24000000>;
-};
-
 pwm_tacho: pwmtachocontroller@1e786000 {
 	#address-cells = <1>;
 	#size-cells = <1>;
 	#cooling-cells = <2>;
 	reg = <0x1E786000 0x1000>;
 	compatible = "aspeed,ast2500-pwm-tacho";
-	clocks = <&pwm_tacho_fixed_clk>;
+	clocks = <&syscon ASPEED_CLK_APB>;
+	resets = <&syscon ASPEED_RESET_PWM>;
 	pinctrl-names = "default";
 	pinctrl-0 = <&pinctrl_pwm0_default &pinctrl_pwm1_default>;
 
-- 
2.14.1

  parent reply	other threads:[~2017-11-02  3:53 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-11-02  3:53 [PATCH v2 0/3] hwmon: Add reset support to aspeed-pwm-tach Joel Stanley
2017-11-02  3:53 ` [PATCH v2 1/3] hwmon: (aspeed-pwm-tacho) Sort headers Joel Stanley
2017-11-04 18:09   ` [v2,1/3] " Guenter Roeck
     [not found] ` <20171102035349.1902-1-joel-U3u1mxZcP9KHXe+LvDLADg@public.gmane.org>
2017-11-02  3:53   ` [PATCH v2 2/3] hwmon: (aspeed-pwm-tacho) Deassert reset in probe Joel Stanley
2017-11-02 14:54     ` Guenter Roeck
     [not found]       ` <20171102145406.GA9240-0h96xk9xTtrk1uMJSBkQmQ@public.gmane.org>
2017-11-03  2:32         ` Joel Stanley
     [not found]           ` <CACPK8Xc3Hsj9TD8L2A6e-iCMZp5=HG9aan5m0YsWV-CZHFPo5A-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2017-11-03 10:11             ` Guenter Roeck
     [not found]     ` <20171102035349.1902-3-joel-U3u1mxZcP9KHXe+LvDLADg@public.gmane.org>
2017-12-03 18:58       ` [v2,2/3] " Guenter Roeck
2017-11-02  3:53 ` Joel Stanley [this message]
     [not found]   ` <20171102035349.1902-4-joel-U3u1mxZcP9KHXe+LvDLADg@public.gmane.org>
2017-11-06 21:42     ` [PATCH v2 3/3] dt-bindings: hwmon: aspeed-pwm-tacho: Add reset node Rob Herring

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20171102035349.1902-4-joel@jms.id.au \
    --to=joel@jms.id.au \
    --cc=andrew@aj.id.au \
    --cc=c_mykolak@mellanox.com \
    --cc=devicetree@vger.kernel.org \
    --cc=jaghu@google.com \
    --cc=linux-hwmon@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@roeck-us.net \
    --cc=philipp.zabel@gmail.com \
    --cc=robh+dt@kernel.org \
    --cc=venture@google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).