From mboxrd@z Thu Jan 1 00:00:00 1970 From: Viresh Kumar Subject: Re: [RFC V7 2/2] OPP: Allow "opp-hz" and "opp-microvolt" to contain magic values Date: Thu, 2 Nov 2017 14:30:33 +0530 Message-ID: <20171102090033.GZ4240@vireshk-i7> References: <23ba51eaa6b52117458165dccc00a95cf8e86e1d.1509453284.git.viresh.kumar@linaro.org> <20171101214333.GG30645@codeaurora.org> <20171102045155.GX4240@vireshk-i7> <20171102071533.GM30645@codeaurora.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <20171102071533.GM30645@codeaurora.org> Sender: linux-pm-owner@vger.kernel.org To: Stephen Boyd Cc: Rob Herring , Ulf Hansson , Kevin Hilman , Viresh Kumar , Nishanth Menon , Rafael Wysocki , "linux-pm@vger.kernel.org" , Vincent Guittot , Rajendra Nayak , Sudeep Holla , "devicetree@vger.kernel.org" , "linux-kernel@vger.kernel.org" List-Id: devicetree@vger.kernel.org On 02-11-17, 00:15, Stephen Boyd wrote: > Sorry I'm not following. We're going to need to have platform > specific code that understands platform specific bindings that > aren't shoved into the generic OPP bindings. At least I am not targeting any platform specific binding right now. The way I see this to work is: - We will reuse earlier bindings and allow opp-hz and opp-microvolt to contain special values (this patch). - Platform specific DT entries will put corner numbers in opp-hz (or opp-microvolt) fields. - Some platform specific driver (in OPP or genpd) will be used to convert OPP into a performance state (corner) value. Now that can simply read opp-hz (or opp-microvolt) and return its value. - OPP core will request for a performance state (code is already merged for that). And so there is no platform specific binding here. Do you want to do this differently ? -- viresh