* [PATCH] of: Document exactly what of_find_node_by_name() puts @ 2017-11-11 1:45 Stephen Boyd 2017-11-11 2:12 ` Randy Dunlap 0 siblings, 1 reply; 4+ messages in thread From: Stephen Boyd @ 2017-11-11 1:45 UTC (permalink / raw) To: Rob Herring, Frank Rowand Cc: linux-kernel-u79uwXL29TY76Z2rM5mHXA, devicetree-u79uwXL29TY76Z2rM5mHXA, linux-doc-u79uwXL29TY76Z2rM5mHXA It isn't clear if this function of_node_put()s the 'from' argument, or the node it finds in the search. Clearly indicate which variable is touched. Signed-off-by: Stephen Boyd <sboyd-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org> --- drivers/of/base.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/of/base.c b/drivers/of/base.c index 63897531cd75..602c5d65734a 100644 --- a/drivers/of/base.c +++ b/drivers/of/base.c @@ -866,7 +866,7 @@ EXPORT_SYMBOL(of_find_node_opts_by_path); * @from: The node to start searching from or NULL, the node * you pass will not be searched, only the next one * will; typically, you pass what the previous call - * returned. of_node_put() will be called on it + * returned. of_node_put() will be called on @from. * @name: The name string to match against * * Returns a node pointer with refcount incremented, use -- The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, a Linux Foundation Collaborative Project -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html ^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] of: Document exactly what of_find_node_by_name() puts 2017-11-11 1:45 [PATCH] of: Document exactly what of_find_node_by_name() puts Stephen Boyd @ 2017-11-11 2:12 ` Randy Dunlap [not found] ` <0ef4b415-801c-cb58-5de1-01bcfba1c778-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org> 0 siblings, 1 reply; 4+ messages in thread From: Randy Dunlap @ 2017-11-11 2:12 UTC (permalink / raw) To: Stephen Boyd, Rob Herring, Frank Rowand Cc: linux-kernel, devicetree, linux-doc On 11/10/2017 05:45 PM, Stephen Boyd wrote: > It isn't clear if this function of_node_put()s the 'from' > argument, or the node it finds in the search. Clearly indicate > which variable is touched. > > Signed-off-by: Stephen Boyd <sboyd@codeaurora.org> > --- > drivers/of/base.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/of/base.c b/drivers/of/base.c > index 63897531cd75..602c5d65734a 100644 > --- a/drivers/of/base.c > +++ b/drivers/of/base.c > @@ -866,7 +866,7 @@ EXPORT_SYMBOL(of_find_node_opts_by_path);> * @from: The node to start searching from or NULL, the node * @from: The node to start searching from or %NULL; the node > * you pass will not be searched, only the next one > * will; typically, you pass what the previous call * will. Typically, you pass what the previous call > - * returned. of_node_put() will be called on it > + * returned. of_node_put() will be called on @from. > * @name: The name string to match against > * > * Returns a node pointer with refcount incremented, use > -- ~Randy ^ permalink raw reply [flat|nested] 4+ messages in thread
[parent not found: <0ef4b415-801c-cb58-5de1-01bcfba1c778-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org>]
* Re: [PATCH] of: Document exactly what of_find_node_by_name() puts [not found] ` <0ef4b415-801c-cb58-5de1-01bcfba1c778-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org> @ 2017-11-17 2:44 ` Stephen Boyd [not found] ` <20171117024404.GV11955-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org> 0 siblings, 1 reply; 4+ messages in thread From: Stephen Boyd @ 2017-11-17 2:44 UTC (permalink / raw) To: Randy Dunlap Cc: Rob Herring, Frank Rowand, linux-kernel-u79uwXL29TY76Z2rM5mHXA, devicetree-u79uwXL29TY76Z2rM5mHXA, linux-doc-u79uwXL29TY76Z2rM5mHXA On 11/10, Randy Dunlap wrote: > On 11/10/2017 05:45 PM, Stephen Boyd wrote: > > It isn't clear if this function of_node_put()s the 'from' > > argument, or the node it finds in the search. Clearly indicate > > which variable is touched. > > > > Signed-off-by: Stephen Boyd <sboyd-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org> > > --- > > drivers/of/base.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/drivers/of/base.c b/drivers/of/base.c > > index 63897531cd75..602c5d65734a 100644 > > --- a/drivers/of/base.c > > +++ b/drivers/of/base.c > > @@ -866,7 +866,7 @@ EXPORT_SYMBOL(of_find_node_opts_by_path);> * @from: The node to start searching from or NULL, the node > > * @from: The node to start searching from or %NULL; the node > > > * you pass will not be searched, only the next one > > * will; typically, you pass what the previous call > > * will. Typically, you pass what the previous call > Rob, do you want me to fold this in? -- Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html ^ permalink raw reply [flat|nested] 4+ messages in thread
[parent not found: <20171117024404.GV11955-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>]
* Re: [PATCH] of: Document exactly what of_find_node_by_name() puts [not found] ` <20171117024404.GV11955-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org> @ 2017-11-17 14:08 ` Rob Herring 0 siblings, 0 replies; 4+ messages in thread From: Rob Herring @ 2017-11-17 14:08 UTC (permalink / raw) To: Stephen Boyd Cc: Randy Dunlap, Frank Rowand, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-doc-u79uwXL29TY76Z2rM5mHXA@public.gmane.org On Thu, Nov 16, 2017 at 8:44 PM, Stephen Boyd <sboyd-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org> wrote: > On 11/10, Randy Dunlap wrote: >> On 11/10/2017 05:45 PM, Stephen Boyd wrote: >> > It isn't clear if this function of_node_put()s the 'from' >> > argument, or the node it finds in the search. Clearly indicate >> > which variable is touched. >> > >> > Signed-off-by: Stephen Boyd <sboyd-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org> >> > --- >> > drivers/of/base.c | 2 +- >> > 1 file changed, 1 insertion(+), 1 deletion(-) >> > >> > diff --git a/drivers/of/base.c b/drivers/of/base.c >> > index 63897531cd75..602c5d65734a 100644 >> > --- a/drivers/of/base.c >> > +++ b/drivers/of/base.c >> > @@ -866,7 +866,7 @@ EXPORT_SYMBOL(of_find_node_opts_by_path);> * @from: The node to start searching from or NULL, the node >> >> * @from: The node to start searching from or %NULL; the node >> >> > * you pass will not be searched, only the next one >> > * will; typically, you pass what the previous call >> >> * will. Typically, you pass what the previous call >> > > Rob, do you want me to fold this in? Yes, please. Rob -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html ^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2017-11-17 14:08 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-11-11 1:45 [PATCH] of: Document exactly what of_find_node_by_name() puts Stephen Boyd
2017-11-11 2:12 ` Randy Dunlap
[not found] ` <0ef4b415-801c-cb58-5de1-01bcfba1c778-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org>
2017-11-17 2:44 ` Stephen Boyd
[not found] ` <20171117024404.GV11955-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>
2017-11-17 14:08 ` Rob Herring
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).