[PATCH 1/2] ARM: dts: Add the support for display5 equipped with Mitsubishi (800x480) display

[PATCH 1/2] ARM: dts: Add the support for display5 equipped with Mitsubishi (800x480) display

[Lukasz Majewski]

This is the support for aa070mc01-ca1 Mitsubishi display.

Signed-off-by: Lukasz Majewski <lukma-ynQEQJNshbs@public.gmane.org>
---
 arch/arm/boot/dts/Makefile                         |  1 +
 .../imx6q-display5-mitsubishi-aa070-800x480.dts    | 51 ++++++++++++++++++++++
 2 files changed, 52 insertions(+)
 create mode 100644 arch/arm/boot/dts/imx6q-display5-mitsubishi-aa070-800x480.dts

diff --git a/arch/arm/boot/dts/Makefile b/arch/arm/boot/dts/Makefile
index d9d0c82e7d20..10b3ad078dea 100644
--- a/arch/arm/boot/dts/Makefile
+++ b/arch/arm/boot/dts/Makefile
@@ -407,6 +407,7 @@ dtb-$(CONFIG_SOC_IMX6Q) += \
 	imx6q-cm-fx6.dtb \
 	imx6q-cubox-i.dtb \
 	imx6q-dfi-fs700-m60.dtb \
+	imx6q-display5-mitsubishi-aa070-800x480.dtb \
 	imx6q-display5-tianma-tm070-1280x768.dtb \
 	imx6q-dmo-edmqmx6.dtb \
 	imx6q-evi.dtb \
diff --git a/arch/arm/boot/dts/imx6q-display5-mitsubishi-aa070-800x480.dts b/arch/arm/boot/dts/imx6q-display5-mitsubishi-aa070-800x480.dts
new file mode 100644
index 000000000000..ea4c292cb74b
--- /dev/null
+++ b/arch/arm/boot/dts/imx6q-display5-mitsubishi-aa070-800x480.dts
@@ -0,0 +1,51 @@
+/*
+ * Copyright 2017
+ * Lukasz Majewski, DENX Software Engineering, lukma-ynQEQJNshbs@public.gmane.org
+ *
+ * This file is dual-licensed: you can use it either under the terms
+ * of the GPL or the X11 license, at your option. Note that this dual
+ * licensing only applies to this file, and not this project as a
+ * whole.
+ *
+ *  a) This file is licensed under the terms of the GNU General Public
+ *     License version 2.  This program is licensed "as is" without
+ *     any warranty of any kind, whether express or implied.
+ *
+ * Or, alternatively,
+ *
+ *  b) Permission is hereby granted, free of charge, to any person
+ *     obtaining a copy of this software and associated documentation
+ *     files (the "Software"), to deal in the Software without
+ *     restriction, including without limitation the rights to use,
+ *     copy, modify, merge, publish, distribute, sublicense, and/or
+ *     sell copies of the Software, and to permit persons to whom the
+ *     Software is furnished to do so, subject to the following
+ *     conditions:
+ *
+ *     The above copyright notice and this permission notice shall be
+ *     included in all copies or substantial portions of the Software.
+ *
+ *     THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND,
+ *     EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES
+ *     OF MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND
+ *     NONINFRINGEMENT. IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT
+ *     HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY,
+ *     WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING
+ *     FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR
+ *     OTHER DEALINGS IN THE SOFTWARE.
+ */
+
+/dts-v1/;
+
+#include "imx6q-display5.dtsi"
+
+&panel {
+	compatible = "mitsubishi,aa070mc01-ca1";
+};
+
+&ldb {
+	lvds0: lvds-channel@0 {
+		fsl,data-mapping = "spwg";
+		fsl,data-width = <24>;
+	};
+};
-- 
2.11.0

--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[PATCH 2/2] ARM: dts: Add the support for display5 equipped with Tianma (800x480) display

[Lukasz Majewski]

Signed-off-by: Lukasz Majewski <lukma-ynQEQJNshbs@public.gmane.org>
---
 arch/arm/boot/dts/Makefile                         |  1 +
 .../dts/imx6q-display5-tianma-tm070-800x480.dts    | 51 ++++++++++++++++++++++
 2 files changed, 52 insertions(+)
 create mode 100644 arch/arm/boot/dts/imx6q-display5-tianma-tm070-800x480.dts

diff --git a/arch/arm/boot/dts/Makefile b/arch/arm/boot/dts/Makefile
index 10b3ad078dea..699c23b83b7f 100644
--- a/arch/arm/boot/dts/Makefile
+++ b/arch/arm/boot/dts/Makefile
@@ -409,6 +409,7 @@ dtb-$(CONFIG_SOC_IMX6Q) += \
 	imx6q-dfi-fs700-m60.dtb \
 	imx6q-display5-mitsubishi-aa070-800x480.dtb \
 	imx6q-display5-tianma-tm070-1280x768.dtb \
+	imx6q-display5-tianma-tm070-800x480.dtb \
 	imx6q-dmo-edmqmx6.dtb \
 	imx6q-evi.dtb \
 	imx6q-gk802.dtb \
diff --git a/arch/arm/boot/dts/imx6q-display5-tianma-tm070-800x480.dts b/arch/arm/boot/dts/imx6q-display5-tianma-tm070-800x480.dts
new file mode 100644
index 000000000000..0c5655a08f3b
--- /dev/null
+++ b/arch/arm/boot/dts/imx6q-display5-tianma-tm070-800x480.dts
@@ -0,0 +1,51 @@
+/*
+ * Copyright 2017
+ * Lukasz Majewski, DENX Software Engineering, lukma-ynQEQJNshbs@public.gmane.org
+ *
+ * This file is dual-licensed: you can use it either under the terms
+ * of the GPL or the X11 license, at your option. Note that this dual
+ * licensing only applies to this file, and not this project as a
+ * whole.
+ *
+ *  a) This file is licensed under the terms of the GNU General Public
+ *     License version 2.  This program is licensed "as is" without
+ *     any warranty of any kind, whether express or implied.
+ *
+ * Or, alternatively,
+ *
+ *  b) Permission is hereby granted, free of charge, to any person
+ *     obtaining a copy of this software and associated documentation
+ *     files (the "Software"), to deal in the Software without
+ *     restriction, including without limitation the rights to use,
+ *     copy, modify, merge, publish, distribute, sublicense, and/or
+ *     sell copies of the Software, and to permit persons to whom the
+ *     Software is furnished to do so, subject to the following
+ *     conditions:
+ *
+ *     The above copyright notice and this permission notice shall be
+ *     included in all copies or substantial portions of the Software.
+ *
+ *     THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND,
+ *     EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES
+ *     OF MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND
+ *     NONINFRINGEMENT. IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT
+ *     HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY,
+ *     WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING
+ *     FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR
+ *     OTHER DEALINGS IN THE SOFTWARE
+ */
+
+/dts-v1/;
+
+#include "imx6q-display5.dtsi"
+
+&panel {
+	compatible = "tianma,tm070rvhg71";
+};
+
+&ldb {
+	lvds0: lvds-channel@0 {
+		fsl,data-mapping = "spwg";
+		fsl,data-width = <24>;
+	};
+};
-- 
2.11.0

--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH 1/2] ARM: dts: Add the support for display5 equipped with Mitsubishi (800x480) display

[Shawn Guo]

On Fri, Nov 17, 2017 at 11:24:03AM +0100, Lukasz Majewski wrote:
> This is the support for aa070mc01-ca1 Mitsubishi display.
> 
> Signed-off-by: Lukasz Majewski <lukma-ynQEQJNshbs@public.gmane.org>
> ---
>  arch/arm/boot/dts/Makefile                         |  1 +
>  .../imx6q-display5-mitsubishi-aa070-800x480.dts    | 51 ++++++++++++++++++++++
>  2 files changed, 52 insertions(+)
>  create mode 100644 arch/arm/boot/dts/imx6q-display5-mitsubishi-aa070-800x480.dts
> 
> diff --git a/arch/arm/boot/dts/Makefile b/arch/arm/boot/dts/Makefile
> index d9d0c82e7d20..10b3ad078dea 100644
> --- a/arch/arm/boot/dts/Makefile
> +++ b/arch/arm/boot/dts/Makefile
> @@ -407,6 +407,7 @@ dtb-$(CONFIG_SOC_IMX6Q) += \
>  	imx6q-cm-fx6.dtb \
>  	imx6q-cubox-i.dtb \
>  	imx6q-dfi-fs700-m60.dtb \
> +	imx6q-display5-mitsubishi-aa070-800x480.dtb \
>  	imx6q-display5-tianma-tm070-1280x768.dtb \
>  	imx6q-dmo-edmqmx6.dtb \
>  	imx6q-evi.dtb \

<snip>

> +#include "imx6q-display5.dtsi"
> +
> +&panel {
> +	compatible = "mitsubishi,aa070mc01-ca1";
> +};

How many DTB files do you want to add for this display5 board?  It's
obvious no fun to maintain a bunch of DTB files for all the panels this
board can support.  Let's stop right here.

Shawn

> +
> +&ldb {
> +	lvds0: lvds-channel@0 {
> +		fsl,data-mapping = "spwg";
> +		fsl,data-width = <24>;
> +	};
> +};
> -- 
> 2.11.0
> 
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH 1/2] ARM: dts: Add the support for display5 equipped with Mitsubishi (800x480) display

[Lukasz Majewski]

[-- Attachment #1: Type: text/plain, Size: 2287 bytes --]

Hi Shawn,

> On Fri, Nov 17, 2017 at 11:24:03AM +0100, Lukasz Majewski wrote:
> > This is the support for aa070mc01-ca1 Mitsubishi display.
> > 
> > Signed-off-by: Lukasz Majewski <lukma-ynQEQJNshbs@public.gmane.org>
> > ---
> >  arch/arm/boot/dts/Makefile                         |  1 +
> >  .../imx6q-display5-mitsubishi-aa070-800x480.dts    | 51
> > ++++++++++++++++++++++ 2 files changed, 52 insertions(+)
> >  create mode 100644
> > arch/arm/boot/dts/imx6q-display5-mitsubishi-aa070-800x480.dts
> > 
> > diff --git a/arch/arm/boot/dts/Makefile b/arch/arm/boot/dts/Makefile
> > index d9d0c82e7d20..10b3ad078dea 100644
> > --- a/arch/arm/boot/dts/Makefile
> > +++ b/arch/arm/boot/dts/Makefile
> > @@ -407,6 +407,7 @@ dtb-$(CONFIG_SOC_IMX6Q) += \
> >  	imx6q-cm-fx6.dtb \
> >  	imx6q-cubox-i.dtb \
> >  	imx6q-dfi-fs700-m60.dtb \
> > +	imx6q-display5-mitsubishi-aa070-800x480.dtb \
> >  	imx6q-display5-tianma-tm070-1280x768.dtb \
> >  	imx6q-dmo-edmqmx6.dtb \
> >  	imx6q-evi.dtb \  
> 
> <snip>
> 
> > +#include "imx6q-display5.dtsi"
> > +
> > +&panel {
> > +	compatible = "mitsubishi,aa070mc01-ca1";
> > +};  
> 
> How many DTB files do you want to add for this display5 board?  

This is a single board, which can support panels which I've posted.

Those dtbs I do pack to u-boot' FIT image and don't need to worry that
some display is not working (after setting bootloader env variable).

> It's
> obvious no fun to maintain a bunch of DTB files for all the panels
> this board can support.

Please note that those files excessively use #include directive, and
there is not so much code added (the longest part is license and
comments).

>  Let's stop right here.

If I may ask - how shall I proceed? What would be your suggestion to
move on (dtb overlays) ?


> 
> Shawn
> 
> > +
> > +&ldb {
> > +	lvds0: lvds-channel@0 {
> > +		fsl,data-mapping = "spwg";
> > +		fsl,data-width = <24>;
> > +	};
> > +};
> > -- 
> > 2.11.0
> >   



Best regards,

Lukasz Majewski

--

DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd-ynQEQJNshbs@public.gmane.org

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: [PATCH 1/2] ARM: dts: Add the support for display5 equipped with Mitsubishi (800x480) display

[Lucas Stach]

Am Freitag, den 17.11.2017, 15:13 +0100 schrieb Lukasz Majewski:
> Hi Shawn,
> 
> > On Fri, Nov 17, 2017 at 11:24:03AM +0100, Lukasz Majewski wrote:
> > > This is the support for aa070mc01-ca1 Mitsubishi display.
> > > 
> > > Signed-off-by: Lukasz Majewski <lukma-ynQEQJNshbs@public.gmane.org>
> > > ---
> > >  arch/arm/boot/dts/Makefile                         |  1 +
> > >  .../imx6q-display5-mitsubishi-aa070-800x480.dts    | 51
> > > ++++++++++++++++++++++ 2 files changed, 52 insertions(+)
> > >  create mode 100644
> > > arch/arm/boot/dts/imx6q-display5-mitsubishi-aa070-800x480.dts
> > > 
> > > diff --git a/arch/arm/boot/dts/Makefile
> > > b/arch/arm/boot/dts/Makefile
> > > index d9d0c82e7d20..10b3ad078dea 100644
> > > --- a/arch/arm/boot/dts/Makefile
> > > +++ b/arch/arm/boot/dts/Makefile
> > > @@ -407,6 +407,7 @@ dtb-$(CONFIG_SOC_IMX6Q) += \
> > >  	imx6q-cm-fx6.dtb \
> > >  	imx6q-cubox-i.dtb \
> > >  	imx6q-dfi-fs700-m60.dtb \
> > > +	imx6q-display5-mitsubishi-aa070-800x480.dtb \
> > >  	imx6q-display5-tianma-tm070-1280x768.dtb \
> > >  	imx6q-dmo-edmqmx6.dtb \
> > >  	imx6q-evi.dtb \  
> > 
> > <snip>
> > 
> > > +#include "imx6q-display5.dtsi"
> > > +
> > > +&panel {
> > > +	compatible = "mitsubishi,aa070mc01-ca1";
> > > +};  
> > 
> > How many DTB files do you want to add for this display5 board?  
> 
> This is a single board, which can support panels which I've posted.
> 
> Those dtbs I do pack to u-boot' FIT image and don't need to worry
> that
> some display is not working (after setting bootloader env variable).
> 
> > It's
> > obvious no fun to maintain a bunch of DTB files for all the panels
> > this board can support.
> 
> Please note that those files excessively use #include directive, and
> there is not so much code added (the longest part is license and
> comments).
> 
> >  Let's stop right here.
> 
> If I may ask - how shall I proceed? What would be your suggestion to
> move on (dtb overlays) ?

The solution we use for the ZII RDU1 and RDU2 boards is to have the
bootloader patch in the correct panel compatible strings. This is quite
a bit simpler than using overlays and if you already have a environment
variable for this it should be easy to do.

> > 
> > Shawn
> > 
> > > +
> > > +&ldb {
> > > +	lvds0: lvds-channel@0 {
> > > +		fsl,data-mapping = "spwg";
> > > +		fsl,data-width = <24>;
> > > +	};
> > > +};

This isn't needed. The panel compatible implies the data mapping and
bus width (at least if you properly filled in this information in the
panel driver).

Regards,
Lucas
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH 1/2] ARM: dts: Add the support for display5 equipped with Mitsubishi (800x480) display

[Lukasz Majewski]

[-- Attachment #1: Type: text/plain, Size: 3268 bytes --]

Hi Lucas,

> Am Freitag, den 17.11.2017, 15:13 +0100 schrieb Lukasz Majewski:
> > Hi Shawn,
> >   
> > > On Fri, Nov 17, 2017 at 11:24:03AM +0100, Lukasz Majewski wrote:  
> > > > This is the support for aa070mc01-ca1 Mitsubishi display.
> > > > 
> > > > Signed-off-by: Lukasz Majewski <lukma-ynQEQJNshbs@public.gmane.org>
> > > > ---
> > > >  arch/arm/boot/dts/Makefile                         |  1 +
> > > >  .../imx6q-display5-mitsubishi-aa070-800x480.dts    | 51
> > > > ++++++++++++++++++++++ 2 files changed, 52 insertions(+)
> > > >  create mode 100644
> > > > arch/arm/boot/dts/imx6q-display5-mitsubishi-aa070-800x480.dts
> > > > 
> > > > diff --git a/arch/arm/boot/dts/Makefile
> > > > b/arch/arm/boot/dts/Makefile
> > > > index d9d0c82e7d20..10b3ad078dea 100644
> > > > --- a/arch/arm/boot/dts/Makefile
> > > > +++ b/arch/arm/boot/dts/Makefile
> > > > @@ -407,6 +407,7 @@ dtb-$(CONFIG_SOC_IMX6Q) += \
> > > >  	imx6q-cm-fx6.dtb \
> > > >  	imx6q-cubox-i.dtb \
> > > >  	imx6q-dfi-fs700-m60.dtb \
> > > > +	imx6q-display5-mitsubishi-aa070-800x480.dtb \
> > > >  	imx6q-display5-tianma-tm070-1280x768.dtb \
> > > >  	imx6q-dmo-edmqmx6.dtb \
> > > >  	imx6q-evi.dtb \    
> > > 
> > > <snip>
> > >   
> > > > +#include "imx6q-display5.dtsi"
> > > > +
> > > > +&panel {
> > > > +	compatible = "mitsubishi,aa070mc01-ca1";
> > > > +};    
> > > 
> > > How many DTB files do you want to add for this display5 board?    
> > 
> > This is a single board, which can support panels which I've posted.
> > 
> > Those dtbs I do pack to u-boot' FIT image and don't need to worry
> > that
> > some display is not working (after setting bootloader env variable).
> >   
> > > It's
> > > obvious no fun to maintain a bunch of DTB files for all the panels
> > > this board can support.  
> > 
> > Please note that those files excessively use #include directive, and
> > there is not so much code added (the longest part is license and
> > comments).
> >   
> > >  Let's stop right here.  
> > 
> > If I may ask - how shall I proceed? What would be your suggestion to
> > move on (dtb overlays) ?  
> 
> The solution we use for the ZII RDU1 and RDU2 boards is to have the
> bootloader patch in the correct panel compatible strings. 

Do you mean adjusting the DTB accordingly in u-boot for each display -
change panel/compatible to new display name ?

> This is
> quite a bit simpler than using overlays and if you already have a
> environment variable for this it should be easy to do.
> 
> > > 
> > > Shawn
> > >   
> > > > +
> > > > +&ldb {
> > > > +	lvds0: lvds-channel@0 {
> > > > +		fsl,data-mapping = "spwg";
> > > > +		fsl,data-width = <24>;
> > > > +	};
> > > > +};  
> 
> This isn't needed. The panel compatible implies the data mapping and
> bus width (at least if you properly filled in this information in the
> panel driver).
> 
> Regards,
> Lucas



Best regards,

Lukasz Majewski

--

DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd-ynQEQJNshbs@public.gmane.org

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: [PATCH 1/2] ARM: dts: Add the support for display5 equipped with Mitsubishi (800x480) display

[Lucas Stach]

Am Freitag, den 17.11.2017, 16:03 +0100 schrieb Lukasz Majewski:
> Hi Lucas,
> 
> > Am Freitag, den 17.11.2017, 15:13 +0100 schrieb Lukasz Majewski:
> > > Hi Shawn,
> > >   
> > > > On Fri, Nov 17, 2017 at 11:24:03AM +0100, Lukasz Majewski wrote:  
> > > > > This is the support for aa070mc01-ca1 Mitsubishi display.
> > > > > 
> > > > > > > > > > Signed-off-by: Lukasz Majewski <lukma-ynQEQJNshbs@public.gmane.org>
> > > > > ---
> > > > >  arch/arm/boot/dts/Makefile                         |  1 +
> > > > >  .../imx6q-display5-mitsubishi-aa070-800x480.dts    | 51
> > > > > ++++++++++++++++++++++ 2 files changed, 52 insertions(+)
> > > > >  create mode 100644
> > > > > arch/arm/boot/dts/imx6q-display5-mitsubishi-aa070-800x480.dts
> > > > > 
> > > > > diff --git a/arch/arm/boot/dts/Makefile
> > > > > b/arch/arm/boot/dts/Makefile
> > > > > index d9d0c82e7d20..10b3ad078dea 100644
> > > > > --- a/arch/arm/boot/dts/Makefile
> > > > > +++ b/arch/arm/boot/dts/Makefile
> > > > > @@ -407,6 +407,7 @@ dtb-$(CONFIG_SOC_IMX6Q) += \
> > > > > > > > > >  	imx6q-cm-fx6.dtb \
> > > > > > > > > >  	imx6q-cubox-i.dtb \
> > > > > > > > > >  	imx6q-dfi-fs700-m60.dtb \
> > > > > > > > > > +	imx6q-display5-mitsubishi-aa070-800x480.dtb \
> > > > > > > > > >  	imx6q-display5-tianma-tm070-1280x768.dtb \
> > > > > > > > > >  	imx6q-dmo-edmqmx6.dtb \
> > > > >  	imx6q-evi.dtb \    
> > > > 
> > > > <snip>
> > > >   
> > > > > +#include "imx6q-display5.dtsi"
> > > > > +
> > > > > +&panel {
> > > > > > > > > > +	compatible = "mitsubishi,aa070mc01-ca1";
> > > > > +};    
> > > > 
> > > > How many DTB files do you want to add for this display5 board?    
> > > 
> > > This is a single board, which can support panels which I've posted.
> > > 
> > > Those dtbs I do pack to u-boot' FIT image and don't need to worry
> > > that
> > > some display is not working (after setting bootloader env variable).
> > >   
> > > > It's
> > > > obvious no fun to maintain a bunch of DTB files for all the panels
> > > > this board can support.  
> > > 
> > > Please note that those files excessively use #include directive, and
> > > there is not so much code added (the longest part is license and
> > > comments).
> > >   
> > > >  Let's stop right here.  
> > > 
> > > If I may ask - how shall I proceed? What would be your suggestion to
> > > move on (dtb overlays) ?  
> > 
> > The solution we use for the ZII RDU1 and RDU2 boards is to have the
> > bootloader patch in the correct panel compatible strings. 
> 
> Do you mean adjusting the DTB accordingly in u-boot for each display -
> change panel/compatible to new display name ?

Exactly. Simply let the bootloader insert the correct panel compatible
string into the DTB.

Regards,
Lucas
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH 1/2] ARM: dts: Add the support for display5 equipped with Mitsubishi (800x480) display

[Lukasz Majewski]

[-- Attachment #1: Type: text/plain, Size: 3664 bytes --]

On Fri, 17 Nov 2017 16:07:18 +0100
Lucas Stach <l.stach-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org> wrote:

> Am Freitag, den 17.11.2017, 16:03 +0100 schrieb Lukasz Majewski:
> > Hi Lucas,
> >   
> > > Am Freitag, den 17.11.2017, 15:13 +0100 schrieb Lukasz Majewski:  
> > > > Hi Shawn,
> > > >     
> > > > > On Fri, Nov 17, 2017 at 11:24:03AM +0100, Lukasz Majewski
> > > > > wrote:    
> > > > > > This is the support for aa070mc01-ca1 Mitsubishi display.
> > > > > >   
> > > > > > > > > > > Signed-off-by: Lukasz Majewski <lukma-ynQEQJNshbs@public.gmane.org>  
> > > > > > ---
> > > > > >  arch/arm/boot/dts/Makefile                         |  1 +
> > > > > >  .../imx6q-display5-mitsubishi-aa070-800x480.dts    | 51
> > > > > > ++++++++++++++++++++++ 2 files changed, 52 insertions(+)
> > > > > >  create mode 100644
> > > > > > arch/arm/boot/dts/imx6q-display5-mitsubishi-aa070-800x480.dts
> > > > > > 
> > > > > > diff --git a/arch/arm/boot/dts/Makefile
> > > > > > b/arch/arm/boot/dts/Makefile
> > > > > > index d9d0c82e7d20..10b3ad078dea 100644
> > > > > > --- a/arch/arm/boot/dts/Makefile
> > > > > > +++ b/arch/arm/boot/dts/Makefile
> > > > > > @@ -407,6 +407,7 @@ dtb-$(CONFIG_SOC_IMX6Q) += \  
> > > > > > > > > > >  	imx6q-cm-fx6.dtb \
> > > > > > > > > > >  	imx6q-cubox-i.dtb \
> > > > > > > > > > >  	imx6q-dfi-fs700-m60.dtb \
> > > > > > > > > > > +
> > > > > > > > > > > imx6q-display5-mitsubishi-aa070-800x480.dtb \
> > > > > > > > > > > imx6q-display5-tianma-tm070-1280x768.dtb \
> > > > > > > > > > > imx6q-dmo-edmqmx6.dtb \  
> > > > > >  	imx6q-evi.dtb \      
> > > > > 
> > > > > <snip>
> > > > >     
> > > > > > +#include "imx6q-display5.dtsi"
> > > > > > +
> > > > > > +&panel {  
> > > > > > > > > > > +	compatible =
> > > > > > > > > > > "mitsubishi,aa070mc01-ca1";  
> > > > > > +};      
> > > > > 
> > > > > How many DTB files do you want to add for this display5
> > > > > board?      
> > > > 
> > > > This is a single board, which can support panels which I've
> > > > posted.
> > > > 
> > > > Those dtbs I do pack to u-boot' FIT image and don't need to
> > > > worry that
> > > > some display is not working (after setting bootloader env
> > > > variable). 
> > > > > It's
> > > > > obvious no fun to maintain a bunch of DTB files for all the
> > > > > panels this board can support.    
> > > > 
> > > > Please note that those files excessively use #include
> > > > directive, and there is not so much code added (the longest
> > > > part is license and comments).
> > > >     
> > > > >  Let's stop right here.    
> > > > 
> > > > If I may ask - how shall I proceed? What would be your
> > > > suggestion to move on (dtb overlays) ?    
> > > 
> > > The solution we use for the ZII RDU1 and RDU2 boards is to have
> > > the bootloader patch in the correct panel compatible strings.   
> > 
> > Do you mean adjusting the DTB accordingly in u-boot for each
> > display - change panel/compatible to new display name ?  
> 
> Exactly. Simply let the bootloader insert the correct panel compatible
> string into the DTB.

This would complicate a few other things :-),

but yes, this seems to be a technically better idea (in terms of final
binary size).

Thanks for help.

> 
> Regards,
> Lucas



Best regards,

Lukasz Majewski

--

DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd-ynQEQJNshbs@public.gmane.org

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]