From: Simon Horman <horms@verge.net.au>
To: Geert Uytterhoeven <geert+renesas@glider.be>
Cc: Magnus Damm <magnus.damm@gmail.com>,
Arnd Bergmann <arnd@arndb.de>,
linux-renesas-soc@vger.kernel.org, devicetree@vger.kernel.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] ARM: dts: r8a779x: Add '#reset-cells' in cpg-mssr
Date: Mon, 20 Nov 2017 10:49:58 +0100 [thread overview]
Message-ID: <20171120094957.2seep3qw4j274zrv@verge.net.au> (raw)
In-Reply-To: <1510839357-11450-1-git-send-email-geert+renesas@glider.be>
On Thu, Nov 16, 2017 at 02:35:57PM +0100, Geert Uytterhoeven wrote:
> From: Arnd Bergmann <arnd@arndb.de>
>
> With the latest dtc, we get many warnings about the missing
> '#reset-cells' property in these controllers, e.g.:
>
> arch/arm/boot/dts/r8a7790-lager.dtb: Warning (resets_property): Missing property '#reset-cells' in node /clock-controller@e6150000 or bad phandle (referred from /can@e6e80000:resets[0])
> arch/arm/boot/dts/r8a7792-blanche.dtb: Warning (resets_property): Missing property '#reset-cells' in node /soc/clock-controller@e6150000 or bad phandle (referred from /soc/dma-controller@e6700000:resets[0])
> arch/arm/boot/dts/r8a7792-wheat.dtb: Warning (resets_property): Missing property '#reset-cells' in node /soc/clock-controller@e6150000 or bad phandle (referred from /soc/ethernet@e6800000:resets[0])
> arch/arm/boot/dts/r8a7793-gose.dtb: Warning (resets_property): Missing property '#reset-cells' in node /clock-controller@e6150000 or bad phandle (referred from /gpio@e6050000:resets[0])
> arch/arm/boot/dts/r8a7794-alt.dtb: Warning (resets_property): Missing property '#reset-cells' in node /clock-controller@e6150000 or bad phandle (referred from /i2c@e6500000:resets[0])
> arch/arm/boot/dts/r8a7794-silk.dtb: Warning (resets_property): Missing property '#reset-cells' in node /clock-controller@e6150000 or bad phandle (referred from /interrupt-controller@e61c0000:resets[0])
>
> This adds it for the three r8a779x chips that were lacking it. The
> binding mandates this as <1>, so this is the value I use.
>
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> [geert: Add fix for r8a7793.dtsi]
> Fixes: 34fbd2b12761d111 ("ARM: dts: r8a7790: Add reset control properties")
> Fixes: 6e11a322f1d7505d ("ARM: dts: r8a7792: Add reset control properties")
> Fixes: 84fb19e1d201ba86 ("ARM: dts: r8a7793: Add reset control properties")
> Fixes: 615beb759ca494a4 ("ARM: dts: r8a7794: Add reset control properties")
> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
Thanks for following up on this, its been fouling up my todo list for a
while now. Applied for v4.16.
next prev parent reply other threads:[~2017-11-20 9:49 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-16 13:35 [PATCH] ARM: dts: r8a779x: Add '#reset-cells' in cpg-mssr Geert Uytterhoeven
2017-11-20 9:49 ` Simon Horman [this message]
[not found] ` <20171120094957.2seep3qw4j274zrv-/R6kz+dDXgpPR4JQBCEnsQ@public.gmane.org>
2017-11-20 9:57 ` Geert Uytterhoeven
2017-11-20 10:26 ` Simon Horman
2017-11-20 10:30 ` Arnd Bergmann
[not found] ` <CAK8P3a345J8JfVu4g+refG+y8r8VmMsjKPkUnYen4kMhQYvtEg-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2017-11-20 10:34 ` Simon Horman
-- strict thread matches above, loose matches on Subject: below --
2017-10-10 8:45 [PATCH] ARM: dts: r8a779x: add " Arnd Bergmann
2017-10-10 9:07 ` Arnd Bergmann
[not found] ` <CAK8P3a0h0xGb3r=SdmyzNVGu5LmTG6GzvvxEsqmubBWJDFbG3A-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2017-10-10 9:28 ` Geert Uytterhoeven
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171120094957.2seep3qw4j274zrv@verge.net.au \
--to=horms@verge.net.au \
--cc=arnd@arndb.de \
--cc=devicetree@vger.kernel.org \
--cc=geert+renesas@glider.be \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=magnus.damm@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).