Re: [PATCH 1/5] checks: add a string checks for label, bootargs and stdout-path

[David Gibson <david-xT8FGy+AXnRB3Ne2BGzF6laj5H9X9Tb+@public.gmane.org>]

[-- Attachment #1: Type: text/plain, Size: 1793 bytes --]

On Mon, Nov 20, 2017 at 11:26:49AM -0600, Rob Herring wrote:
> On Sun, Nov 19, 2017 at 6:09 PM, David Gibson
> <david-xT8FGy+AXnRB3Ne2BGzF6laj5H9X9Tb+@public.gmane.org> wrote:
> > On Fri, Nov 17, 2017 at 08:45:11AM -0600, Rob Herring wrote:
> >> Add more string property checks for label, bootargs, and stdout-path.
> >
> > Where does 'label' appear?  I'm not immediately recalling it as a
> > property with global meaning.
> 
> It's documented in DT spec/ePAPR. It can be anywhere. It's the
> property for the human readable identifiers such as the label on
> ethernet ports, serial ports, LEDs, etc.

Ah, ok.  I'd completely forgotten about that one.  Ok, that's a fine
check then.

> > bootargs and stdout-path are from /chosen of course.  I have some
> > mixed feelings about whether it's reasonable to check it's a string
> > everywhere, rather than specifically just in /chosen.
> 
> We don't really want to see the same property names with different
> meanings.

Hm.  As a rule of thumb, yes, but I don't know that it's super
important for properties that aren't very common.  Even then /chosen
is really special.

> I think checking the location is a separate check. You've
> generally suggested splitting up tests rather than have all in one
> tests. Not sure if we should check known properties only appear in
> chosen or that chosen only has known properties (assuming we can
> enumerate that list. Maybe we allow things like "linux,*").

I think for now a better approach would be to add one or more checks
specifically to validate the /chosen node.

-- 
David Gibson			| I'll have my music baroque, and my code
david AT gibson.dropbear.id.au	| minimalist, thank you.  NOT _the_ _other_
				| _way_ _around_!
http://www.ozlabs.org/~dgibson

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]