* [PATCH][RESEND] Documentation: binding: Update endianness usage
@ 2017-11-29 11:31 Prabhakar Kushwaha
[not found] ` <1511955071-8770-1-git-send-email-prabhakar.kushwaha-3arQi8VN3Tc@public.gmane.org>
0 siblings, 1 reply; 3+ messages in thread
From: Prabhakar Kushwaha @ 2017-11-29 11:31 UTC (permalink / raw)
To: devicetree-u79uwXL29TY76Z2rM5mHXA, robh-DgEjT+Ai2ygdnm+yROfE0A,
mark.rutland-5wv7dgnIgG8, shawnguo-DgEjT+Ai2ygdnm+yROfE0A
Cc: linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r,
Prabhakar Kushwaha
IFC controller version < 2.0 support IFC register access as
big endian. These controller version also require IFC NOR signals to
be connected in reverse order with NOR flash.
IFC >= 2.0 is other way around.
So updating IFC binding to take care of both using endianness field.
Signed-off-by: Prabhakar Kushwaha <prabhakar.kushwaha-3arQi8VN3Tc@public.gmane.org>
---
Documentation/devicetree/bindings/memory-controllers/fsl/ifc.txt | 6 ++++--
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/Documentation/devicetree/bindings/memory-controllers/fsl/ifc.txt b/Documentation/devicetree/bindings/memory-controllers/fsl/ifc.txt
index 89427b0..824a2ca 100644
--- a/Documentation/devicetree/bindings/memory-controllers/fsl/ifc.txt
+++ b/Documentation/devicetree/bindings/memory-controllers/fsl/ifc.txt
@@ -18,8 +18,10 @@ Properties:
interrupt (NAND_EVTER_STAT). If there is only one,
that interrupt reports both types of event.
-- little-endian : If this property is absent, the big-endian mode will
- be in use as default for registers.
+- little-endian or big-endin : It represents how IFC registers to be accessed.
+ It also represents connection between controller and
+ NOR flash. If this property is absent, the big-endian
+ mode will be in use as default.
- ranges : Each range corresponds to a single chipselect, and covers
the entire access window as configured.
--
1.9.1
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply related [flat|nested] 3+ messages in thread[parent not found: <1511955071-8770-1-git-send-email-prabhakar.kushwaha-3arQi8VN3Tc@public.gmane.org>]
* Re: [PATCH][RESEND] Documentation: binding: Update endianness usage [not found] ` <1511955071-8770-1-git-send-email-prabhakar.kushwaha-3arQi8VN3Tc@public.gmane.org> @ 2017-11-30 0:51 ` Shawn Guo 2017-12-01 2:15 ` Rob Herring 0 siblings, 1 reply; 3+ messages in thread From: Shawn Guo @ 2017-11-30 0:51 UTC (permalink / raw) To: Prabhakar Kushwaha Cc: devicetree-u79uwXL29TY76Z2rM5mHXA, robh-DgEjT+Ai2ygdnm+yROfE0A, mark.rutland-5wv7dgnIgG8, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r On Wed, Nov 29, 2017 at 05:01:11PM +0530, Prabhakar Kushwaha wrote: > IFC controller version < 2.0 support IFC register access as > big endian. These controller version also require IFC NOR signals to > be connected in reverse order with NOR flash. > > IFC >= 2.0 is other way around. > > So updating IFC binding to take care of both using endianness field. > > Signed-off-by: Prabhakar Kushwaha <prabhakar.kushwaha-3arQi8VN3Tc@public.gmane.org> I would suggest something like 'dt-bindings: ifc: ...' to be the prefix. Shawn > --- > Documentation/devicetree/bindings/memory-controllers/fsl/ifc.txt | 6 ++++-- > 1 file changed, 4 insertions(+), 2 deletions(-) > > diff --git a/Documentation/devicetree/bindings/memory-controllers/fsl/ifc.txt b/Documentation/devicetree/bindings/memory-controllers/fsl/ifc.txt > index 89427b0..824a2ca 100644 > --- a/Documentation/devicetree/bindings/memory-controllers/fsl/ifc.txt > +++ b/Documentation/devicetree/bindings/memory-controllers/fsl/ifc.txt > @@ -18,8 +18,10 @@ Properties: > interrupt (NAND_EVTER_STAT). If there is only one, > that interrupt reports both types of event. > > -- little-endian : If this property is absent, the big-endian mode will > - be in use as default for registers. > +- little-endian or big-endin : It represents how IFC registers to be accessed. > + It also represents connection between controller and > + NOR flash. If this property is absent, the big-endian > + mode will be in use as default. > > - ranges : Each range corresponds to a single chipselect, and covers > the entire access window as configured. > -- > 1.9.1 > > > _______________________________________________ > linux-arm-kernel mailing list > linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org > http://lists.infradead.org/mailman/listinfo/linux-arm-kernel -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html ^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH][RESEND] Documentation: binding: Update endianness usage 2017-11-30 0:51 ` Shawn Guo @ 2017-12-01 2:15 ` Rob Herring 0 siblings, 0 replies; 3+ messages in thread From: Rob Herring @ 2017-12-01 2:15 UTC (permalink / raw) To: Shawn Guo Cc: Prabhakar Kushwaha, devicetree-u79uwXL29TY76Z2rM5mHXA, mark.rutland-5wv7dgnIgG8, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r On Thu, Nov 30, 2017 at 08:51:09AM +0800, Shawn Guo wrote: > On Wed, Nov 29, 2017 at 05:01:11PM +0530, Prabhakar Kushwaha wrote: > > IFC controller version < 2.0 support IFC register access as > > big endian. These controller version also require IFC NOR signals to > > be connected in reverse order with NOR flash. > > > > IFC >= 2.0 is other way around. > > > > So updating IFC binding to take care of both using endianness field. > > > > Signed-off-by: Prabhakar Kushwaha <prabhakar.kushwaha-3arQi8VN3Tc@public.gmane.org> > > I would suggest something like 'dt-bindings: ifc: ...' to be the prefix. Yes > Shawn > > > --- > > Documentation/devicetree/bindings/memory-controllers/fsl/ifc.txt | 6 ++++-- > > 1 file changed, 4 insertions(+), 2 deletions(-) > > > > diff --git a/Documentation/devicetree/bindings/memory-controllers/fsl/ifc.txt b/Documentation/devicetree/bindings/memory-controllers/fsl/ifc.txt > > index 89427b0..824a2ca 100644 > > --- a/Documentation/devicetree/bindings/memory-controllers/fsl/ifc.txt > > +++ b/Documentation/devicetree/bindings/memory-controllers/fsl/ifc.txt > > @@ -18,8 +18,10 @@ Properties: > > interrupt (NAND_EVTER_STAT). If there is only one, > > that interrupt reports both types of event. > > > > -- little-endian : If this property is absent, the big-endian mode will > > - be in use as default for registers. > > +- little-endian or big-endin : It represents how IFC registers to be accessed. s/endin/endian/ > > + It also represents connection between controller and > > + NOR flash. If this property is absent, the big-endian > > + mode will be in use as default. How you wire up the NOR to the controller would be independent of the register endianness. Are you sure this is not just because the data register(s) is BE? > > > > - ranges : Each range corresponds to a single chipselect, and covers > > the entire access window as configured. > > -- > > 1.9.1 > > > > > > _______________________________________________ > > linux-arm-kernel mailing list > > linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org > > http://lists.infradead.org/mailman/listinfo/linux-arm-kernel -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html ^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2017-12-01 2:15 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-11-29 11:31 [PATCH][RESEND] Documentation: binding: Update endianness usage Prabhakar Kushwaha
[not found] ` <1511955071-8770-1-git-send-email-prabhakar.kushwaha-3arQi8VN3Tc@public.gmane.org>
2017-11-30 0:51 ` Shawn Guo
2017-12-01 2:15 ` Rob Herring
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).