* [PATCH net-next 1/2 v6] net: ethernet: Add DT bindings for the Gemini ethernet
@ 2017-12-02 11:06 Linus Walleij
[not found] ` <20171202110640.5284-1-linus.walleij-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
0 siblings, 1 reply; 3+ messages in thread
From: Linus Walleij @ 2017-12-02 11:06 UTC (permalink / raw)
To: netdev-u79uwXL29TY76Z2rM5mHXA, David S . Miller,
Michał Mirosław
Cc: Janos Laube, Paulius Zaleckas,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r,
Hans Ulli Kroll, Florian Fainelli, Linus Walleij,
devicetree-u79uwXL29TY76Z2rM5mHXA, Tobias Waldvogel
This adds the device tree bindings for the Gemini ethernet
controller. It is pretty straight-forward, using standard
bindings and modelling the two child ports as child devices
under the parent ethernet controller device.
Cc: devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Cc: Tobias Waldvogel <tobias.waldvogel-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
Cc: Michał Mirosław <mirq-linux-CoA6ZxLDdyEEUmgCuDUIdw@public.gmane.org>
Signed-off-by: Linus Walleij <linus.walleij-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
---
.../bindings/net/cortina,gemini-ethernet.txt | 92 ++++++++++++++++++++++
1 file changed, 92 insertions(+)
create mode 100644 Documentation/devicetree/bindings/net/cortina,gemini-ethernet.txt
diff --git a/Documentation/devicetree/bindings/net/cortina,gemini-ethernet.txt b/Documentation/devicetree/bindings/net/cortina,gemini-ethernet.txt
new file mode 100644
index 000000000000..35fa3abd1c73
--- /dev/null
+++ b/Documentation/devicetree/bindings/net/cortina,gemini-ethernet.txt
@@ -0,0 +1,92 @@
+Cortina Systems Gemini Ethernet Controller
+==========================================
+
+This ethernet controller is found in the Gemini SoC family:
+StorLink SL3512 and SL3516, also known as Cortina Systems
+CS3512 and CS3516.
+
+Required properties:
+- compatible: must be "cortina,gemini-ethernet"
+- reg: must contain the global registers and the V-bit and A-bit
+ memory areas, in total three register sets.
+- syscon: a phandle to the system controller
+- #address-cells: must be specified, must be <1>
+- #size-cells: must be specified, must be <1>
+- ranges: should be state like this giving a 1:1 address translation
+ for the subnodes
+
+The subnodes represents the two ethernet ports in this device.
+They are not independent of each other since they share resources
+in the parent node, and are thus children.
+
+Required subnodes:
+- port0: contains the resources for ethernet port 0
+- port1: contains the resources for ethernet port 1
+
+Required subnode properties:
+- compatible: must be "cortina,gemini-ethernet-port"
+- reg: must contain two register areas: the DMA/TOE memory and
+ the GMAC memory area of the port
+- interrupts: should contain the interrupt line of the port.
+ this is nominally a level interrupt active high.
+- resets: this must provide an SoC-integrated reset line for
+ the port.
+- clocks: this should contain a handle to the PCLK clock for
+ clocking the silicon in this port
+- clock-names: must be "PCLK"
+
+Optional subnode properties:
+- phy-mode: see ethernet.txt
+- phy-handle: see ethernet.txt
+
+Example:
+
+mdio-bus {
+ (...)
+ phy0: ethernet-phy@1 {
+ reg = <1>;
+ device_type = "ethernet-phy";
+ };
+ phy1: ethernet-phy@3 {
+ reg = <3>;
+ device_type = "ethernet-phy";
+ };
+};
+
+
+ethernet@60000000 {
+ compatible = "cortina,gemini-ethernet";
+ reg = <0x60000000 0x4000>, /* Global registers, queue */
+ <0x60004000 0x2000>, /* V-bit */
+ <0x60006000 0x2000>; /* A-bit */
+ syscon = <&syscon>;
+ #address-cells = <1>;
+ #size-cells = <1>;
+ ranges;
+
+ gmac0: port0 {
+ compatible = "cortina,gemini-ethernet-port";
+ reg = <0x60008000 0x2000>, /* Port 0 DMA/TOE */
+ <0x6000a000 0x2000>; /* Port 0 GMAC */
+ interrupt-parent = <&intcon>;
+ interrupts = <1 IRQ_TYPE_LEVEL_HIGH>;
+ resets = <&syscon GEMINI_RESET_GMAC0>;
+ clocks = <&syscon GEMINI_CLK_GATE_GMAC0>;
+ clock-names = "PCLK";
+ phy-mode = "rgmii";
+ phy-handle = <&phy0>;
+ };
+
+ gmac1: port1 {
+ compatible = "cortina,gemini-ethernet-port";
+ reg = <0x6000c000 0x2000>, /* Port 1 DMA/TOE */
+ <0x6000e000 0x2000>; /* Port 1 GMAC */
+ interrupt-parent = <&intcon>;
+ interrupts = <2 IRQ_TYPE_LEVEL_HIGH>;
+ resets = <&syscon GEMINI_RESET_GMAC1>;
+ clocks = <&syscon GEMINI_CLK_GATE_GMAC1>;
+ clock-names = "PCLK";
+ phy-mode = "rgmii";
+ phy-handle = <&phy1>;
+ };
+};
--
2.14.3
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply related [flat|nested] 3+ messages in thread[parent not found: <20171202110640.5284-1-linus.walleij-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>]
* Re: [PATCH net-next 1/2 v6] net: ethernet: Add DT bindings for the Gemini ethernet [not found] ` <20171202110640.5284-1-linus.walleij-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org> @ 2017-12-04 18:06 ` Hans Ulli Kroll 2017-12-04 22:30 ` Rob Herring 1 sibling, 0 replies; 3+ messages in thread From: Hans Ulli Kroll @ 2017-12-04 18:06 UTC (permalink / raw) To: Linus Walleij Cc: netdev-u79uwXL29TY76Z2rM5mHXA, David S . Miller, Michał Mirosław, Janos Laube, Paulius Zaleckas, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r, Hans Ulli Kroll, Florian Fainelli, devicetree-u79uwXL29TY76Z2rM5mHXA, Tobias Waldvogel [-- Attachment #1: Type: TEXT/PLAIN, Size: 900 bytes --] Hi Linus On Sat, 2 Dec 2017, Linus Walleij wrote: > This adds the device tree bindings for the Gemini ethernet > controller. It is pretty straight-forward, using standard > bindings and modelling the two child ports as child devices > under the parent ethernet controller device. > > Cc: devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org > Cc: Tobias Waldvogel <tobias.waldvogel-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> > Cc: Michał Mirosław <mirq-linux-CoA6ZxLDdyEEUmgCuDUIdw@public.gmane.org> > Signed-off-by: Linus Walleij <linus.walleij-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org> > --- > .../bindings/net/cortina,gemini-ethernet.txt | 92 ++++++++++++++++++++++ > 1 file changed, 92 insertions(+) > create mode 100644 Documentation/devicetree/bindings/net/cortina,gemini-ethernet.txt > Acked-by: Hans Ulli Kroll <ulli.kroll-gM/Ye1E23mwN+BqQ9rBEUg@public.gmane.org> ^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH net-next 1/2 v6] net: ethernet: Add DT bindings for the Gemini ethernet [not found] ` <20171202110640.5284-1-linus.walleij-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org> 2017-12-04 18:06 ` Hans Ulli Kroll @ 2017-12-04 22:30 ` Rob Herring 1 sibling, 0 replies; 3+ messages in thread From: Rob Herring @ 2017-12-04 22:30 UTC (permalink / raw) To: Linus Walleij Cc: netdev-u79uwXL29TY76Z2rM5mHXA, David S . Miller, Michał Mirosław, Janos Laube, Paulius Zaleckas, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r, Hans Ulli Kroll, Florian Fainelli, devicetree-u79uwXL29TY76Z2rM5mHXA, Tobias Waldvogel On Sat, Dec 02, 2017 at 12:06:39PM +0100, Linus Walleij wrote: > This adds the device tree bindings for the Gemini ethernet > controller. It is pretty straight-forward, using standard > bindings and modelling the two child ports as child devices > under the parent ethernet controller device. > > Cc: devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org > Cc: Tobias Waldvogel <tobias.waldvogel-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> > Cc: Michał Mirosław <mirq-linux-CoA6ZxLDdyEEUmgCuDUIdw@public.gmane.org> > Signed-off-by: Linus Walleij <linus.walleij-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org> > --- > .../bindings/net/cortina,gemini-ethernet.txt | 92 ++++++++++++++++++++++ > 1 file changed, 92 insertions(+) > create mode 100644 Documentation/devicetree/bindings/net/cortina,gemini-ethernet.txt > > diff --git a/Documentation/devicetree/bindings/net/cortina,gemini-ethernet.txt b/Documentation/devicetree/bindings/net/cortina,gemini-ethernet.txt > new file mode 100644 > index 000000000000..35fa3abd1c73 > --- /dev/null > +++ b/Documentation/devicetree/bindings/net/cortina,gemini-ethernet.txt > @@ -0,0 +1,92 @@ > +Cortina Systems Gemini Ethernet Controller > +========================================== > + > +This ethernet controller is found in the Gemini SoC family: > +StorLink SL3512 and SL3516, also known as Cortina Systems > +CS3512 and CS3516. > + > +Required properties: > +- compatible: must be "cortina,gemini-ethernet" > +- reg: must contain the global registers and the V-bit and A-bit > + memory areas, in total three register sets. > +- syscon: a phandle to the system controller > +- #address-cells: must be specified, must be <1> > +- #size-cells: must be specified, must be <1> > +- ranges: should be state like this giving a 1:1 address translation > + for the subnodes > + > +The subnodes represents the two ethernet ports in this device. > +They are not independent of each other since they share resources > +in the parent node, and are thus children. > + > +Required subnodes: > +- port0: contains the resources for ethernet port 0 > +- port1: contains the resources for ethernet port 1 > + > +Required subnode properties: > +- compatible: must be "cortina,gemini-ethernet-port" > +- reg: must contain two register areas: the DMA/TOE memory and > + the GMAC memory area of the port > +- interrupts: should contain the interrupt line of the port. > + this is nominally a level interrupt active high. > +- resets: this must provide an SoC-integrated reset line for > + the port. > +- clocks: this should contain a handle to the PCLK clock for > + clocking the silicon in this port > +- clock-names: must be "PCLK" > + > +Optional subnode properties: > +- phy-mode: see ethernet.txt > +- phy-handle: see ethernet.txt > + > +Example: > + > +mdio-bus { > + (...) > + phy0: ethernet-phy@1 { > + reg = <1>; > + device_type = "ethernet-phy"; > + }; > + phy1: ethernet-phy@3 { > + reg = <3>; > + device_type = "ethernet-phy"; > + }; > +}; > + > + > +ethernet@60000000 { > + compatible = "cortina,gemini-ethernet"; > + reg = <0x60000000 0x4000>, /* Global registers, queue */ > + <0x60004000 0x2000>, /* V-bit */ > + <0x60006000 0x2000>; /* A-bit */ > + syscon = <&syscon>; > + #address-cells = <1>; > + #size-cells = <1>; > + ranges; Would be better to define the actual range used by child nodes. > + > + gmac0: port0 { Needs a unit-address. Building with W=1 (or W=2) will tell you this. As port is used by the OF graph binding, use ethernet-port@... instead. > + compatible = "cortina,gemini-ethernet-port"; > + reg = <0x60008000 0x2000>, /* Port 0 DMA/TOE */ > + <0x6000a000 0x2000>; /* Port 0 GMAC */ > + interrupt-parent = <&intcon>; > + interrupts = <1 IRQ_TYPE_LEVEL_HIGH>; > + resets = <&syscon GEMINI_RESET_GMAC0>; > + clocks = <&syscon GEMINI_CLK_GATE_GMAC0>; > + clock-names = "PCLK"; > + phy-mode = "rgmii"; > + phy-handle = <&phy0>; > + }; > + > + gmac1: port1 { > + compatible = "cortina,gemini-ethernet-port"; > + reg = <0x6000c000 0x2000>, /* Port 1 DMA/TOE */ > + <0x6000e000 0x2000>; /* Port 1 GMAC */ > + interrupt-parent = <&intcon>; > + interrupts = <2 IRQ_TYPE_LEVEL_HIGH>; > + resets = <&syscon GEMINI_RESET_GMAC1>; > + clocks = <&syscon GEMINI_CLK_GATE_GMAC1>; > + clock-names = "PCLK"; > + phy-mode = "rgmii"; > + phy-handle = <&phy1>; > + }; > +}; > -- > 2.14.3 > > -- > To unsubscribe from this list: send the line "unsubscribe devicetree" in > the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org > More majordomo info at http://vger.kernel.org/majordomo-info.html -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html ^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2017-12-04 22:30 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-12-02 11:06 [PATCH net-next 1/2 v6] net: ethernet: Add DT bindings for the Gemini ethernet Linus Walleij
[not found] ` <20171202110640.5284-1-linus.walleij-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
2017-12-04 18:06 ` Hans Ulli Kroll
2017-12-04 22:30 ` Rob Herring
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).