Re: [PATCH 3/6] arm: dts: marvell: Add missing #phy-cells to usb-nop-xceiv

Gregory CLEMENT
2017-11-22T16:59:23Z

Hi Arnd,

On mar., nov. 21 2017, Arnd Bergmann <arnd-r2nGTMty4D4@public.gmane.org> wrote:

> On Tue, Nov 21, 2017 at 9:09 PM, Andrew Lunn <andrew-g2DYL2Zd6BY@public.gmane.org> wrote:
>> On Tue, Nov 21, 2017 at 12:29:48PM -0600, Rob Herring wrote:
>>> On Thu, Nov 9, 2017 at 4:26 PM, Rob Herring <robh-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org> wrote:
>>> > "usb-nop-xceiv" is using the phy binding, but is missing #phy-cells
>>> > property. This is probably because the binding was the precursor to the phy
>>> > binding.
>>> >
>>> > Fixes the following warning in Marvell dts files:
>>> >
>>> > Warning (phys_property): Missing property '#phy-cells' in node ...
>>> >
>>> > Signed-off-by: Rob Herring <robh-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
>>> > Cc: Jason Cooper <jason-NLaQJdtUoK4Be96aLqz0jA@public.gmane.org>
>>> > Cc: Andrew Lunn <andrew-g2DYL2Zd6BY@public.gmane.org>
>>> > Cc: Gregory Clement <gregory.clement-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org>
>>> > Cc: Sebastian Hesselbarth <sebastian.hesselbarth-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
>>> > ---
>>> > Please apply to Marvell tree.
>>>
>>> Ping.
>>>
>>> Arnd, can you apply if you'd like the warnings fixed and Marvell
>>> maintainers don't respond.
>>
>> Hi Rob
>>
>> Patches submitted a week before the merge window opens are generally
>> deferred to the next cycle. I expect that once -rc1 is out, Gregory
>> will pick up this patch.
>
> These are real bugfixes, I want them in 4.15, since we now get a
> loud warning for them. I'd rather not shut up that warning because
> it's not a false-positive.

As pointed by Andrew, I planned to take them once the 4.15-rc1 would be
released. It was not obvious for me that it was real fixes. Actually I
would have expected to have first the dts fixed in a release and then
the warning enabled.

I am fine if you take this patch, especially if it is merged in
4.15-rc1.

So for this patch:

Acked-by: Gregory CLEMENT <gregory.clement-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org>

Thanks,

Gregory

>
> Arnd

--
Gregory Clement, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.