devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Lothar Waßmann" <LW-bxm8fMRDkQLDiMYJYoSAnRvVK+yQ3ZXh@public.gmane.org>
To: Fabio Estevam <festevam-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
Cc: shawnguo-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org,
	linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
	robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org,
	devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	Fabio Estevam <fabio.estevam-3arQi8VN3Tc@public.gmane.org>
Subject: Re: [PATCH 04/12] ARM: dts: imx53-tx53-x03x: Move display node out of 'soc'
Date: Mon, 4 Dec 2017 12:10:19 +0100	[thread overview]
Message-ID: <20171204121019.486b4160@karo-electronics.de> (raw)
In-Reply-To: <1512156285-18451-4-git-send-email-festevam-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>

Hi,

On Fri,  1 Dec 2017 17:24:37 -0200 Fabio Estevam wrote:
> From: Fabio Estevam <fabio.estevam-3arQi8VN3Tc@public.gmane.org>
> 
> Move disp0 node from soc node to root node.
> 
> disp0 node does not have any register properties and thus
> shouldn't be placed on the bus.
> 
> This fixes the following build warnings with W=1:
> 
> arch/arm/boot/dts/imx53-tx53-x03x.dtb: Warning (simple_bus_reg): Node /soc/disp0 missing or empty reg/ranges property
> 
> Cc: Lothar Waßmann <LW-bxm8fMRDkQLDiMYJYoSAnRvVK+yQ3ZXh@public.gmane.org>
> Signed-off-by: Fabio Estevam <fabio.estevam-3arQi8VN3Tc@public.gmane.org>
> ---
>  arch/arm/boot/dts/imx53-tx53-x03x.dts | 232 +++++++++++++++++-----------------
>  1 file changed, 115 insertions(+), 117 deletions(-)
> 
> diff --git a/arch/arm/boot/dts/imx53-tx53-x03x.dts b/arch/arm/boot/dts/imx53-tx53-x03x.dts
> index 7eb53e4..fe15c95 100644
> --- a/arch/arm/boot/dts/imx53-tx53-x03x.dts
> +++ b/arch/arm/boot/dts/imx53-tx53-x03x.dts
> @@ -53,132 +53,130 @@
>  		display = &display;
>  	};
>  
> -	soc {
> -		display: disp0 {
> -			compatible = "fsl,imx-parallel-display";
> -			interface-pix-fmt = "rgb24";
> -			pinctrl-names = "default";
> -			pinctrl-0 = <&pinctrl_rgb24_vga1>;
> -			status = "okay";
> +	display: disp0 {
> +		compatible = "fsl,imx-parallel-display";
> +		interface-pix-fmt = "rgb24";
> +		pinctrl-names = "default";
> +		pinctrl-0 = <&pinctrl_rgb24_vga1>;
> +		status = "okay";
>  
> -			port {
> -				display0_in: endpoint {
> -					remote-endpoint = <&ipu_di0_disp0>;
> -				};
> +		port {
> +			display0_in: endpoint {
> +				remote-endpoint = <&ipu_di0_disp0>;
>  			};
> +		};
>  
> -			display-timings {
> -				VGA {
> -					clock-frequency = <25200000>;
> -					hactive = <640>;
> -					vactive = <480>;
> -					hback-porch = <48>;
> -					hsync-len = <96>;
> -					hfront-porch = <16>;
> -					vback-porch = <31>;
> -					vsync-len = <2>;
> -					vfront-porch = <12>;
> -					hsync-active = <0>;
> -					vsync-active = <0>;
> -					de-active = <1>;
> -					pixelclk-active = <0>;
> -				};
> +		display-timings {
> +			VGA {
> +				clock-frequency = <25200000>;
> +				hactive = <640>;
> +				vactive = <480>;
> +				hback-porch = <48>;
> +				hsync-len = <96>;
> +				hfront-porch = <16>;
> +				vback-porch = <31>;
> +				vsync-len = <2>;
> +				vfront-porch = <12>;
> +				hsync-active = <0>;
> +				vsync-active = <0>;
> +				de-active = <1>;
> +				pixelclk-active = <0>;
> +			};
>  
> -				ETV570 {
> -					clock-frequency = <25200000>;
> -					hactive = <640>;
> -					vactive = <480>;
> -					hback-porch = <114>;
> -					hsync-len = <30>;
> -					hfront-porch = <16>;
> -					vback-porch = <32>;
> -					vsync-len = <3>;
> -					vfront-porch = <10>;
> -					hsync-active = <0>;
> -					vsync-active = <0>;
> -					de-active = <1>;
> -					pixelclk-active = <0>;
> -				};
> +			ETV570 {
> +				clock-frequency = <25200000>;
> +				hactive = <640>;
> +				vactive = <480>;
> +				hback-porch = <114>;
> +				hsync-len = <30>;
> +				hfront-porch = <16>;
> +				vback-porch = <32>;
> +				vsync-len = <3>;
> +				vfront-porch = <10>;
> +				hsync-active = <0>;
> +				vsync-active = <0>;
> +				de-active = <1>;
> +				pixelclk-active = <0>;
> +			};
>  
> -				ET0350 {
> -					clock-frequency = <6413760>;
> -					hactive = <320>;
> -					vactive = <240>;
> -					hback-porch = <34>;
> -					hsync-len = <34>;
> -					hfront-porch = <20>;
> -					vback-porch = <15>;
> -					vsync-len = <3>;
> -					vfront-porch = <4>;
> -					hsync-active = <0>;
> -					vsync-active = <0>;
> -					de-active = <1>;
> -					pixelclk-active = <0>;
> -				};
> +			ET0350 {
> +				clock-frequency = <6413760>;
> +				hactive = <320>;
> +				vactive = <240>;
> +				hback-porch = <34>;
> +				hsync-len = <34>;
> +				hfront-porch = <20>;
> +				vback-porch = <15>;
> +				vsync-len = <3>;
> +				vfront-porch = <4>;
> +				hsync-active = <0>;
> +				vsync-active = <0>;
> +				de-active = <1>;
> +				pixelclk-active = <0>;
> +			};
>  
> -				ET0430 {
> -					clock-frequency = <9009000>;
> -					hactive = <480>;
> -					vactive = <272>;
> -					hback-porch = <2>;
> -					hsync-len = <41>;
> -					hfront-porch = <2>;
> -					vback-porch = <2>;
> -					vsync-len = <10>;
> -					vfront-porch = <2>;
> -					hsync-active = <0>;
> -					vsync-active = <0>;
> -					de-active = <1>;
> -					pixelclk-active = <1>;
> -				};
> +			ET0430 {
> +				clock-frequency = <9009000>;
> +				hactive = <480>;
> +				vactive = <272>;
> +				hback-porch = <2>;
> +				hsync-len = <41>;
> +				hfront-porch = <2>;
> +				vback-porch = <2>;
> +				vsync-len = <10>;
> +				vfront-porch = <2>;
> +				hsync-active = <0>;
> +				vsync-active = <0>;
> +				de-active = <1>;
> +				pixelclk-active = <1>;
> +			};
>  
> -				ET0500 {
> -					clock-frequency = <33264000>;
> -					hactive = <800>;
> -					vactive = <480>;
> -					hback-porch = <88>;
> -					hsync-len = <128>;
> -					hfront-porch = <40>;
> -					vback-porch = <33>;
> -					vsync-len = <2>;
> -					vfront-porch = <10>;
> -					hsync-active = <0>;
> -					vsync-active = <0>;
> -					de-active = <1>;
> -					pixelclk-active = <0>;
> -				};
> +			ET0500 {
> +				clock-frequency = <33264000>;
> +				hactive = <800>;
> +				vactive = <480>;
> +				hback-porch = <88>;
> +				hsync-len = <128>;
> +				hfront-porch = <40>;
> +				vback-porch = <33>;
> +				vsync-len = <2>;
> +				vfront-porch = <10>;
> +				hsync-active = <0>;
> +				vsync-active = <0>;
> +				de-active = <1>;
> +				pixelclk-active = <0>;
> +			};
>  
> -				ET0700 { /* same as ET0500 */
> -					clock-frequency = <33264000>;
> -					hactive = <800>;
> -					vactive = <480>;
> -					hback-porch = <88>;
> -					hsync-len = <128>;
> -					hfront-porch = <40>;
> -					vback-porch = <33>;
> -					vsync-len = <2>;
> -					vfront-porch = <10>;
> -					hsync-active = <0>;
> -					vsync-active = <0>;
> -					de-active = <1>;
> -					pixelclk-active = <0>;
> -				};
> +			ET0700 { /* same as ET0500 */
> +				clock-frequency = <33264000>;
> +				hactive = <800>;
> +				vactive = <480>;
> +				hback-porch = <88>;
> +				hsync-len = <128>;
> +				hfront-porch = <40>;
> +				vback-porch = <33>;
> +				vsync-len = <2>;
> +				vfront-porch = <10>;
> +				hsync-active = <0>;
> +				vsync-active = <0>;
> +				de-active = <1>;
> +				pixelclk-active = <0>;
> +			};
>  
> -				ETQ570 {
> -					clock-frequency = <6596040>;
> -					hactive = <320>;
> -					vactive = <240>;
> -					hback-porch = <38>;
> -					hsync-len = <30>;
> -					hfront-porch = <30>;
> -					vback-porch = <16>;
> -					vsync-len = <3>;
> -					vfront-porch = <4>;
> -					hsync-active = <0>;
> -					vsync-active = <0>;
> -					de-active = <1>;
> -					pixelclk-active = <0>;
> -				};
> +			ETQ570 {
> +				clock-frequency = <6596040>;
> +				hactive = <320>;
> +				vactive = <240>;
> +				hback-porch = <38>;
> +				hsync-len = <30>;
> +				hfront-porch = <30>;
> +				vback-porch = <16>;
> +				vsync-len = <3>;
> +				vfront-porch = <4>;
> +				hsync-active = <0>;
> +				vsync-active = <0>;
> +				de-active = <1>;
> +				pixelclk-active = <0>;
>  			};
>  		};
>  	};
Acked-by: Lothar Waßmann <LW-bxm8fMRDkQLDiMYJYoSAnRvVK+yQ3ZXh@public.gmane.org>


Lothar Waßmann
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

  parent reply	other threads:[~2017-12-04 11:10 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-12-01 19:24 [PATCH 01/12] ARM: dts: imx51-ts4800: Fix syscon and touschscreen nodes Fabio Estevam
2017-12-01 19:24 ` [PATCH 02/12] ARM: dts: imx51-zii-rdu1: Add the unit addresses in sysled Fabio Estevam
     [not found] ` <1512156285-18451-1-git-send-email-festevam-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2017-12-01 19:24   ` [PATCH 03/12] ARM: dts: imx53-m53: Remove unneeded reg property Fabio Estevam
2017-12-01 19:24   ` [PATCH 04/12] ARM: dts: imx53-tx53-x03x: Move display node out of 'soc' Fabio Estevam
     [not found]     ` <1512156285-18451-4-git-send-email-festevam-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2017-12-04 11:10       ` Lothar Waßmann [this message]
2017-12-01 19:24   ` [PATCH 05/12] ARM: dts: imx6qdl-apf6dev: Move regulators out of simple-bus Fabio Estevam
2017-12-01 19:24   ` [PATCH 06/12] ARM: dts: imx6qdl-aristainetos: " Fabio Estevam
     [not found]     ` <1512156285-18451-6-git-send-email-festevam-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2017-12-02  3:47       ` Heiko Schocher
2017-12-01 19:24   ` [PATCH 07/12] ARM: dts: imx6qdl-aristainetos: Move display node out of 'soc' Fabio Estevam
     [not found]     ` <1512156285-18451-7-git-send-email-festevam-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2017-12-02  3:48       ` Heiko Schocher
2017-12-01 19:24   ` [PATCH 08/12] ARM: dts: imx6qdl-apalis: Remove unneeded reg property Fabio Estevam
     [not found]     ` <1512156285-18451-8-git-send-email-festevam-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2017-12-03 22:48       ` Marcel Ziswiler
2017-12-01 19:24   ` [PATCH 09/12] ARM: dts: imx6qdl-colibri: " Fabio Estevam
     [not found]     ` <1512156285-18451-9-git-send-email-festevam-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2017-12-03 23:02       ` Marcel Ziswiler
2017-12-01 19:24   ` [PATCH 10/12] ARM: dts: imx6q-h100: Remove unneeded unit address Fabio Estevam
2017-12-01 19:24   ` [PATCH 11/12] ARM: dts: imx6qdl-nitrogen6_max: " Fabio Estevam
     [not found]     ` <1512156285-18451-11-git-send-email-festevam-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2017-12-04 11:19       ` Gary Bisson
     [not found]         ` <20171204111954.v7jexbtkjyaa6mhe-gtbVdJvtf7D/PtFMR13I2A@public.gmane.org>
2017-12-04 11:28           ` Fabio Estevam
     [not found]             ` <CAOMZO5C77f9mQQWJ5GJH3J+cj4Fxu3H-3yQYeFNDxm3xfpe8Gw-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2017-12-04 11:31               ` Gary Bisson
     [not found]                 ` <20171204113120.wbofrsoxl2ekd3ch-gtbVdJvtf7D/PtFMR13I2A@public.gmane.org>
2017-12-04 11:32                   ` Fabio Estevam
2017-12-01 19:24   ` [PATCH 12/12] ARM: dts: imx6ul-14x14-evk: Move regulators out of simple-bus Fabio Estevam
2017-12-01 19:45   ` [PATCH 01/12] ARM: dts: imx51-ts4800: Fix syscon and touschscreen nodes Damien Riegel
     [not found]     ` <20171201194516.ix2oa7waxy5ph55s-zEH/TkcsnG777SC2UrCW1FMQynFLKtET@public.gmane.org>
2017-12-01 19:48       ` Fabio Estevam
     [not found]         ` <CAOMZO5Cdp4g0QRC1S0w9P+Uv5TmoPoO7qsU3aJ+-1mXNGRPDeA-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2017-12-01 19:56           ` Damien Riegel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20171204121019.486b4160@karo-electronics.de \
    --to=lw-bxm8fmrdkqldimyjyosanrvvk+yq3zxh@public.gmane.org \
    --cc=devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=fabio.estevam-3arQi8VN3Tc@public.gmane.org \
    --cc=festevam-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
    --cc=linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
    --cc=robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
    --cc=shawnguo-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).