From: Benjamin Gaignard <benjamin.gaignard@linaro.org>
To: robh+dt@kernel.org, mark.rutland@arm.com, linux@armlinux.org.uk,
mcoquelin.stm32@gmail.com, alexandre.torgue@st.com,
daniel.lezcano@linaro.org, tglx@linutronix.de, arnd@arndb.de
Cc: devicetree@vger.kernel.org,
Benjamin Gaignard <benjamin.gaignard@linaro.org>,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org
Subject: [PATCH v9 2/6] clocksource: stm32: increase min delta value
Date: Fri, 8 Dec 2017 12:32:46 +0100 [thread overview]
Message-ID: <20171208113250.359-3-benjamin.gaignard@st.com> (raw)
In-Reply-To: <20171208113250.359-1-benjamin.gaignard@st.com>
From: Benjamin Gaignard <benjamin.gaignard@linaro.org>
The CPU is a CortexM4 @ 200MHZ and the clocks driving
the timers are at 90MHZ with a min delta at 1 you could
have an interrupt each 0.01 ms which is really to much.
By increase it to 0x60 it give more time (around 1 ms)
to CPU to handle the interrupt.
Signed-off-by: Benjamin Gaignard <benjamin.gaignard@linaro.org>
---
drivers/clocksource/timer-stm32.c | 9 ++++++++-
1 file changed, 8 insertions(+), 1 deletion(-)
diff --git a/drivers/clocksource/timer-stm32.c b/drivers/clocksource/timer-stm32.c
index fc61fd18a182..a45f1f1cd040 100644
--- a/drivers/clocksource/timer-stm32.c
+++ b/drivers/clocksource/timer-stm32.c
@@ -36,6 +36,12 @@
#define TIM_EGR_UG BIT(0)
+/*
+ * The clock driving the hardware is at 90MHZ with a MIN_DELTA
+ * at 0x60 it gives around 1 ms to the CPU to handle the interrupt
+ */
+#define MIN_DELTA 0x60
+
static int stm32_clock_event_shutdown(struct clock_event_device *evt)
{
struct timer_of *to = to_timer_of(evt);
@@ -129,7 +135,8 @@ static int __init stm32_clockevent_init(struct device_node *node)
writel_relaxed(0, timer_of_base(to) + TIM_SR);
clockevents_config_and_register(&to->clkevt,
- timer_of_period(to), 0x1, max_delta);
+ timer_of_period(to),
+ MIN_DELTA, max_delta);
pr_info("%pOF: STM32 clockevent driver initialized (%d bits)\n",
node, bits);
--
2.15.0
next prev parent reply other threads:[~2017-12-08 11:32 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-08 11:32 [PATCH v9 0/6] stm32 clocksource driver rework Benjamin Gaignard
2017-12-08 11:32 ` [PATCH v9 1/6] clocksource: stm32: convert driver to timer_of Benjamin Gaignard
2017-12-08 11:32 ` Benjamin Gaignard [this message]
[not found] ` <20171208113250.359-1-benjamin.gaignard-qxv4g6HH51o@public.gmane.org>
2017-12-08 11:32 ` [PATCH v9 3/6] clocksource: stm32: only use 32 bits timers Benjamin Gaignard
[not found] ` <20171208113250.359-4-benjamin.gaignard-qxv4g6HH51o@public.gmane.org>
2017-12-08 12:51 ` Daniel Lezcano
2017-12-08 13:05 ` Benjamin Gaignard
[not found] ` <CA+M3ks5CY79SHqcfhgySgsQuPVQyJWHQJ0=OT3Zvxvu2LfUOaA-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2017-12-08 13:47 ` Daniel Lezcano
2017-12-08 11:32 ` [PATCH v9 4/6] clocksource: stm32: add clocksource support Benjamin Gaignard
2017-12-08 13:46 ` Daniel Lezcano
2017-12-08 14:04 ` Benjamin Gaignard
[not found] ` <CA+M3ks6uWUQqD-c_FWETDLp097AfUEVs1srpH_C7kK-X8ADQ1Q-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2017-12-08 14:08 ` Daniel Lezcano
[not found] ` <810270c4-c6b4-ee05-2481-ced52f7d2685-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
2017-12-08 14:19 ` Benjamin Gaignard
2017-12-08 11:32 ` [PATCH v9 5/6] clocksource: stm32: Update license and copyright Benjamin Gaignard
[not found] ` <20171208113250.359-6-benjamin.gaignard-qxv4g6HH51o@public.gmane.org>
2017-12-08 13:46 ` Philippe Ombredanne
2017-12-08 11:32 ` [PATCH v9 6/6] arm: dts: stm32: remove useless clocksource nodes Benjamin Gaignard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171208113250.359-3-benjamin.gaignard@st.com \
--to=benjamin.gaignard@linaro.org \
--cc=alexandre.torgue@st.com \
--cc=arnd@arndb.de \
--cc=daniel.lezcano@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=mark.rutland@arm.com \
--cc=mcoquelin.stm32@gmail.com \
--cc=robh+dt@kernel.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).