From: David Miller <davem@davemloft.net>
To: hayashi.kunihiko@socionext.com
Cc: netdev@vger.kernel.org, andrew@lunn.ch, f.fainelli@gmail.com,
robh+dt@kernel.org, mark.rutland@arm.com,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, devicetree@vger.kernel.org,
yamada.masahiro@socionext.com, masami.hiramatsu@linaro.org,
jaswinder.singh@linaro.org
Subject: Re: [PATCH net-next v5 2/2] net: ethernet: socionext: add AVE ethernet driver
Date: Mon, 11 Dec 2017 09:35:20 -0500 (EST) [thread overview]
Message-ID: <20171211.093520.1509647114338216500.davem@davemloft.net> (raw)
In-Reply-To: <1512979049-15930-3-git-send-email-hayashi.kunihiko@socionext.com>
From: Kunihiko Hayashi <hayashi.kunihiko@socionext.com>
Date: Mon, 11 Dec 2017 16:57:29 +0900
> +static inline u32 ave_desc_read(struct net_device *ndev, enum desc_id id,
> + int entry, int offset)
Do not use inline functions in foo.c files, let the compiler decide what
to do.
Thank you.
prev parent reply other threads:[~2017-12-11 14:35 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-11 7:57 [PATCH net-next v5 0/2] add UniPhier AVE ethernet support Kunihiko Hayashi
2017-12-11 7:57 ` [PATCH net-next v5 1/2] dt-bindings: net: add DT bindings for Socionext UniPhier AVE Kunihiko Hayashi
2017-12-11 7:57 ` [PATCH net-next v5 2/2] net: ethernet: socionext: add AVE ethernet driver Kunihiko Hayashi
2017-12-11 9:19 ` Philippe Ombredanne
[not found] ` <CAOFm3uELNTgenR91-QGL1QQ08zA0N0rQbH4hzCzFKtRw6TckLw-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2017-12-11 12:04 ` Kunihiko Hayashi
[not found] ` <20171211210455.170A.4A936039-uWyLwvC0a2jby3iVrkZq2A@public.gmane.org>
2017-12-11 13:34 ` Masami Hiramatsu
2017-12-11 13:46 ` Russell King - ARM Linux
[not found] ` <20171211134627.GU10595-l+eeeJia6m9URfEZ8mYm6t73F7V6hmMc@public.gmane.org>
2017-12-12 2:29 ` Masami Hiramatsu
[not found] ` <CAA93ih0C-aMpFAhU+5x6P=QjiOVRPZ0UL1wyKh1oeXzC8UjPXQ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2017-12-12 9:14 ` Philippe Ombredanne
2017-12-11 14:35 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171211.093520.1509647114338216500.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=andrew@lunn.ch \
--cc=devicetree@vger.kernel.org \
--cc=f.fainelli@gmail.com \
--cc=hayashi.kunihiko@socionext.com \
--cc=jaswinder.singh@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=masami.hiramatsu@linaro.org \
--cc=netdev@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=yamada.masahiro@socionext.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox