Devicetree
 help / color / mirror / Atom feed
From: Peter Rosin <peda@axentia.se>
To: linux-kernel@vger.kernel.org
Cc: Mark Rutland <mark.rutland@arm.com>,
	devicetree@vger.kernel.org, alsa-devel@alsa-project.org,
	Liam Girdwood <lgirdwood@gmail.com>,
	Rob Herring <robh+dt@kernel.org>, Mark Brown <broonie@kernel.org>,
	Fabio Estevam <festevam@gmail.com>, Peter Rosin <peda@axentia.se>
Subject: [PATCH 1/2] ASoC: tfa9879: clean up bindings
Date: Mon, 11 Dec 2017 15:26:14 +0100	[thread overview]
Message-ID: <20171211142615.11440-2-peda@axentia.se> (raw)
In-Reply-To: <20171211142615.11440-1-peda@axentia.se>

Fix a couple of nitpicks:

- list #sound-dai-cells as a required property.
- The chip supports full speed I2C; don't indicate standard mode only.
- status = "okay" is just noise.
- The chip is an amplifier, not a codec.
- consistently indent with tabs.

Signed-off-by: Peter Rosin <peda@axentia.se>
---
 Documentation/devicetree/bindings/sound/tfa9879.txt | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/Documentation/devicetree/bindings/sound/tfa9879.txt b/Documentation/devicetree/bindings/sound/tfa9879.txt
index 23ba522d9e2b..1620e6848436 100644
--- a/Documentation/devicetree/bindings/sound/tfa9879.txt
+++ b/Documentation/devicetree/bindings/sound/tfa9879.txt
@@ -6,18 +6,18 @@ Required properties:
 
 - reg : the I2C address of the device
 
+- #sound-dai-cells : must be 0.
+
 Example:
 
 &i2c1 {
-	clock-frequency = <100000>;
 	pinctrl-names = "default";
 	pinctrl-0 = <&pinctrl_i2c1>;
-	status = "okay";
 
-	codec: tfa9879@6c {
+	amp: amp@6c {
 		#sound-dai-cells = <0>;
 		compatible = "nxp,tfa9879";
 		reg = <0x6c>;
-        };
+	};
 };
 
-- 
2.11.0

  reply	other threads:[~2017-12-11 14:26 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-12-11 14:26 [PATCH 0/2] ASoC: tfa9879: cleanup bindings and claim maintainership Peter Rosin
2017-12-11 14:26 ` Peter Rosin [this message]
     [not found]   ` <20171211142615.11440-2-peda-koto5C5qi+TLoDKTGw+V6w@public.gmane.org>
2017-12-12 11:16     ` Applied "ASoC: tfa9879: clean up bindings" to the asoc tree Mark Brown
2017-12-11 14:26 ` [PATCH 2/2] ASoC: tfa9879: add DT bindings to MAINTAINERS Peter Rosin
     [not found]   ` <20171211142615.11440-3-peda-koto5C5qi+TLoDKTGw+V6w@public.gmane.org>
2017-12-12 11:16     ` Applied "ASoC: tfa9879: add DT bindings to MAINTAINERS" to the asoc tree Mark Brown
     [not found] ` <20171211142615.11440-1-peda-koto5C5qi+TLoDKTGw+V6w@public.gmane.org>
2017-12-11 16:35   ` [PATCH 0/2] ASoC: tfa9879: cleanup bindings and claim maintainership Mark Brown
2017-12-11 16:45     ` Peter Rosin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20171211142615.11440-2-peda@axentia.se \
    --to=peda@axentia.se \
    --cc=alsa-devel@alsa-project.org \
    --cc=broonie@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=festevam@gmail.com \
    --cc=lgirdwood@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mark.rutland@arm.com \
    --cc=robh+dt@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox