From: Viresh Kumar <viresh.kumar@linaro.org>
To: Dave Gerlach <d-gerlach@ti.com>
Cc: Rob Herring <robh+dt@kernel.org>,
"Rafael J . Wysocki" <rjw@rjwysocki.net>,
linux-arm-kernel@lists.infradead.org, linux-omap@vger.kernel.org,
linux-pm@vger.kernel.org, devicetree@vger.kernel.org,
Tony Lindgren <tony@atomide.com>, Nishanth Menon <nm@ti.com>
Subject: Re: [PATCH 1/4] cpufreq: ti-cpufreq: Convert to module_platform_driver
Date: Thu, 14 Dec 2017 09:59:46 +0530 [thread overview]
Message-ID: <20171214042946.GR3322@vireshk-i7> (raw)
In-Reply-To: <20171213203358.20839-2-d-gerlach@ti.com>
On 13-12-17, 14:33, Dave Gerlach wrote:
> ti-cpufreq will be responsible for calling dev_pm_opp_set_regulators on
> platforms that require AVS and ABB regulator support so we must be
> able to defer probe if regulators are not yet available, so change
> ti-cpufreq to be a module_platform_driver to allow for probe defer.
>
> Signed-off-by: Dave Gerlach <d-gerlach@ti.com>
> ---
> drivers/cpufreq/ti-cpufreq.c | 23 +++++++++++++++++++++--
> 1 file changed, 21 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/cpufreq/ti-cpufreq.c b/drivers/cpufreq/ti-cpufreq.c
> index 923317f03b4b..b1c230a1e2aa 100644
> --- a/drivers/cpufreq/ti-cpufreq.c
> +++ b/drivers/cpufreq/ti-cpufreq.c
> @@ -17,6 +17,7 @@
> #include <linux/cpu.h>
> #include <linux/io.h>
> #include <linux/mfd/syscon.h>
> +#include <linux/module.h>
> #include <linux/init.h>
> #include <linux/of.h>
> #include <linux/of_platform.h>
> @@ -195,7 +196,7 @@ static const struct of_device_id ti_cpufreq_of_match[] = {
> {},
> };
>
> -static int ti_cpufreq_init(void)
> +static int ti_cpufreq_probe(struct platform_device *pdev)
> {
> u32 version[VERSION_COUNT];
> struct device_node *np;
> @@ -269,4 +270,22 @@ static int ti_cpufreq_init(void)
>
> return ret;
> }
> -device_initcall(ti_cpufreq_init);
> +
> +static int ti_cpufreq_init(void)
> +{
> + platform_device_register_simple("ti-cpufreq", -1, NULL, 0);
> + return 0;
> +}
> +module_init(ti_cpufreq_init);
> +
> +static struct platform_driver ti_cpufreq_driver = {
> + .probe = ti_cpufreq_probe,
> + .driver = {
> + .name = "ti-cpufreq",
> + },
> +};
> +module_platform_driver(ti_cpufreq_driver);
> +
> +MODULE_DESCRIPTION("TI CPUFreq/OPP hw-supported driver");
> +MODULE_AUTHOR("Dave Gerlach <d-gerlach@ti.com>");
> +MODULE_LICENSE("GPL v2");
Acked-by: Viresh Kumar <viresh.kumar@linaro.org>
--
viresh
next prev parent reply other threads:[~2017-12-14 4:29 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-13 20:33 [PATCH 0/4] PM / OPP: Introduce ti-opp-supply driver Dave Gerlach
[not found] ` <20171213203358.20839-1-d-gerlach-l0cyMroinI0@public.gmane.org>
2017-12-13 20:33 ` [PATCH 1/4] cpufreq: ti-cpufreq: Convert to module_platform_driver Dave Gerlach
2017-12-14 4:29 ` Viresh Kumar [this message]
2017-12-13 20:33 ` [PATCH 2/4] cpufreq: ti-cpufreq: Add support for multiple regulators Dave Gerlach
2017-12-14 4:31 ` Viresh Kumar
2017-12-13 20:33 ` [PATCH 3/4] dt-bindings: opp: Introduce ti-opp-supply bindings Dave Gerlach
2017-12-13 20:33 ` [PATCH 4/4] PM / OPP: Add ti-opp-supply driver Dave Gerlach
2017-12-14 4:34 ` Viresh Kumar
2017-12-14 16:31 ` Dave Gerlach
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171214042946.GR3322@vireshk-i7 \
--to=viresh.kumar@linaro.org \
--cc=d-gerlach@ti.com \
--cc=devicetree@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-omap@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=nm@ti.com \
--cc=rjw@rjwysocki.net \
--cc=robh+dt@kernel.org \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).