From mboxrd@z Thu Jan 1 00:00:00 1970 From: Baruch Siach Subject: Re: [PATCH v3 01/11] dt-bindings: thermal: Describe Armada AP806 and CP110 Date: Fri, 15 Dec 2017 10:44:17 +0200 Message-ID: <20171215084417.2vf77y4uvtixw252@tarshish> References: <20171214103011.24713-1-miquel.raynal@free-electrons.com> <20171214103011.24713-2-miquel.raynal@free-electrons.com> <20171215082759.7t24ka3lpkulcb7r@tarshish> <20171215093203.74b7a59c@xps13> Mime-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: 8bit Return-path: Content-Disposition: inline In-Reply-To: <20171215093203.74b7a59c@xps13> Sender: devicetree-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Miquel RAYNAL Cc: Zhang Rui , Eduardo Valentin , Rob Herring , Mark Rutland , Jason Cooper , Andrew Lunn , Gregory Clement , Sebastian Hesselbarth , Catalin Marinas , Will Deacon , linux-pm-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, Thomas Petazzoni , Antoine Tenart , Nadav Haklai , David Sniatkiwicz List-Id: devicetree@vger.kernel.org HI Miquèl On Fri, Dec 15, 2017 at 09:32:03AM +0100, Miquel RAYNAL wrote: > On Fri, 15 Dec 2017 10:27:59 +0200 > Baruch Siach wrote: > > > > On Thu, Dec 14, 2017 at 11:30:01AM +0100, Miquel Raynal wrote: > > > +- marvell,thermal-zone-name: The name to identify the thermal zone > > > + within the sysfs, useful when multiple > > > + thermal zones are registered (AP, > > > CPx...). > > > > I don't think that would be acceptable. DT is about describing the > > hardware. sysfs is a Linux implementation detail which is not tied to > > any specific hardware. If this is accepted, the property should be > > named 'linux,thermal-zone-name'. > > You are right the sysfs mention should not appear in the description. My comment was not about the description language. I don't think that this property is acceptable at all. But I'll let DT maintainers comment on that. > Otherwise for the naming I'm not sure "linux," is a valid prefix in > that case. We use the 'linux' prefix for input key names and led triggers, for example. baruch -- http://baruch.siach.name/blog/ ~. .~ Tk Open Systems =}------------------------------------------------ooO--U--Ooo------------{= - baruch-NswTu9S1W3P6gbPvEgmw2w@public.gmane.org - tel: +972.52.368.4656, http://www.tkos.co.il - -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html