devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH 12/25] arm: socfpga: dts: Remove leading 0x and 0s from bindings notation
  2017-12-15 11:15 ` [PATCH 01/25] arm: artpec: " Mathieu Malaterre
@ 2017-12-15 11:16   ` Mathieu Malaterre
  2018-01-11 14:38     ` Dinh Nguyen
  0 siblings, 1 reply; 3+ messages in thread
From: Mathieu Malaterre @ 2017-12-15 11:16 UTC (permalink / raw)
  To: Rob Herring
  Cc: Mathieu Malaterre, Benoît Cousson, Tony Lindgren,
	Mark Rutland, Russell King, Jesper Nilsson, Lars Persson,
	Niklas Cassel, Nicolas Ferre, Alexandre Belloni, Ray Jui,
	Scott Branden, Jon Mason, bcm-kernel-feedback-list,
	Florian Fainelli, Sekhar Nori, Kevin Hilman, Kukjin Kim,
	Krzysztof Kozlowski, Shawn Guo, Sascha Hauer, Fabio Estevam,
	Santosh Shilimkar, Jason Cooper, Andrew Lunn, Gregory Clement,
	Sebastian Hesselbarth, Vladimir Zapolskiy, Sylvain Lemieux,
	Matthias Brugger, Barry Song, Heiko Stuebner, Dinh Nguyen,
	Viresh Kumar, Shiraz Hashim, Maxime Coquelin, Alexandre Torgue,
	Jun Nie, Baoyou Xie, linux-omap, devicetree, linux-arm-kernel,
	linux-kernel, linux-arm-kernel, linux-samsung-soc, linux-mediatek,
	linux-rockchip

Improve the DTS files by removing all the leading "0x" and zeros to fix the
following dtc warnings:

Warning (unit_address_format): Node /XXX unit name should not have leading "0x"

and

Warning (unit_address_format): Node /XXX unit name should not have leading 0s

Converted using the following command:

find . -type f \( -iname *.dts -o -iname *.dtsi \) -exec sed -i -e "s/@\([0-9a-fA-FxX\.;:#]+\)\s*{/@\L\1 {/g" -e "s/@0x\(.*\) {/@\1 {/g" -e "s/@0+\(.*\) {/@\1 {/g" {} +^C

For simplicity, two sed expressions were used to solve each warnings separately.

To make the regex expression more robust a few other issues were resolved,
namely setting unit-address to lower case, and adding a whitespace before the
the opening curly brace:

https://elinux.org/Device_Tree_Linux#Linux_conventions

This will solve as a side effect warning:

Warning (simple_bus_reg): Node /XXX@<UPPER> simple-bus unit address format error, expected "<lower>"

This is a follow up to commit 4c9847b7375a ("dt-bindings: Remove leading 0x from bindings notation")

Reported-by: David Daney <ddaney@caviumnetworks.com>
Suggested-by: Rob Herring <robh@kernel.org>
Signed-off-by: Mathieu Malaterre <malat@debian.org>
---
 arch/arm/boot/dts/socfpga.dtsi | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/arm/boot/dts/socfpga.dtsi b/arch/arm/boot/dts/socfpga.dtsi
index 7e24dc8e82d4..36f87eb389b1 100644
--- a/arch/arm/boot/dts/socfpga.dtsi
+++ b/arch/arm/boot/dts/socfpga.dtsi
@@ -724,7 +724,7 @@
 			arm,prefetch-offset = <7>;
 		};
 
-		l3regs@0xff800000 {
+		l3regs@ff800000 {
 			compatible = "altr,l3regs", "syscon";
 			reg = <0xff800000 0x1000>;
 		};
-- 
2.11.0

^ permalink raw reply related	[flat|nested] 3+ messages in thread

* [PATCH 12/25] arm: socfpga: dts: Remove leading 0x and 0s from bindings notation
@ 2017-12-15 12:46 Mathieu Malaterre
  0 siblings, 0 replies; 3+ messages in thread
From: Mathieu Malaterre @ 2017-12-15 12:46 UTC (permalink / raw)
  To: Rob Herring
  Cc: Mark Rutland, devicetree, Mathieu Malaterre, Russell King,
	linux-kernel, Dinh Nguyen, linux-arm-kernel

Improve the DTS files by removing all the leading "0x" and zeros to fix the
following dtc warnings:

Warning (unit_address_format): Node /XXX unit name should not have leading "0x"

and

Warning (unit_address_format): Node /XXX unit name should not have leading 0s

Converted using the following command:

find . -type f \( -iname *.dts -o -iname *.dtsi \) -exec sed -i -e "s/@\([0-9a-fA-FxX\.;:#]+\)\s*{/@\L\1 {/g" -e "s/@0x\(.*\) {/@\1 {/g" -e "s/@0+\(.*\) {/@\1 {/g" {} +^C

For simplicity, two sed expressions were used to solve each warnings separately.

To make the regex expression more robust a few other issues were resolved,
namely setting unit-address to lower case, and adding a whitespace before the
the opening curly brace:

https://elinux.org/Device_Tree_Linux#Linux_conventions

This will solve as a side effect warning:

Warning (simple_bus_reg): Node /XXX@<UPPER> simple-bus unit address format error, expected "<lower>"

This is a follow up to commit 4c9847b7375a ("dt-bindings: Remove leading 0x from bindings notation")

Reported-by: David Daney <ddaney@caviumnetworks.com>
Suggested-by: Rob Herring <robh@kernel.org>
Signed-off-by: Mathieu Malaterre <malat@debian.org>
---
 arch/arm/boot/dts/socfpga.dtsi | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/arm/boot/dts/socfpga.dtsi b/arch/arm/boot/dts/socfpga.dtsi
index 7e24dc8e82d4..36f87eb389b1 100644
--- a/arch/arm/boot/dts/socfpga.dtsi
+++ b/arch/arm/boot/dts/socfpga.dtsi
@@ -724,7 +724,7 @@
 			arm,prefetch-offset = <7>;
 		};
 
-		l3regs@0xff800000 {
+		l3regs@ff800000 {
 			compatible = "altr,l3regs", "syscon";
 			reg = <0xff800000 0x1000>;
 		};
-- 
2.11.0

^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH 12/25] arm: socfpga: dts: Remove leading 0x and 0s from bindings notation
  2017-12-15 11:16   ` [PATCH 12/25] arm: socfpga: " Mathieu Malaterre
@ 2018-01-11 14:38     ` Dinh Nguyen
  0 siblings, 0 replies; 3+ messages in thread
From: Dinh Nguyen @ 2018-01-11 14:38 UTC (permalink / raw)
  To: Mathieu Malaterre, Rob Herring
  Cc: Mark Rutland, Andrew Lunn, Heiko Stuebner, Tony Lindgren,
	Sekhar Nori, linux-kernel, Matthias Brugger, Alexandre Belloni,
	linux-arm-kernel, Baoyou Xie, Jason Cooper, Jesper Nilsson,
	Florian Fainelli, Kevin Hilman, Viresh Kumar, Russell King,
	Krzysztof Kozlowski, linux-rockchip, Alexandre Torgue, Kukjin Kim,
	bcm-kernel-feedback-list, Niklas Cassel, Sebastian Hesselbarth,
	devicetree



On 12/15/2017 05:16 AM, Mathieu Malaterre wrote:
> Improve the DTS files by removing all the leading "0x" and zeros to fix the
> following dtc warnings:
> 
> Warning (unit_address_format): Node /XXX unit name should not have leading "0x"
> 
> and
> 
> Warning (unit_address_format): Node /XXX unit name should not have leading 0s
> 
> Converted using the following command:
> 
> find . -type f \( -iname *.dts -o -iname *.dtsi \) -exec sed -i -e "s/@\([0-9a-fA-FxX\.;:#]+\)\s*{/@\L\1 {/g" -e "s/@0x\(.*\) {/@\1 {/g" -e "s/@0+\(.*\) {/@\1 {/g" {} +^C
> 
> For simplicity, two sed expressions were used to solve each warnings separately.
> 
> To make the regex expression more robust a few other issues were resolved,
> namely setting unit-address to lower case, and adding a whitespace before the
> the opening curly brace:
> 
> https://elinux.org/Device_Tree_Linux#Linux_conventions
> 
> This will solve as a side effect warning:
> 
> Warning (simple_bus_reg): Node /XXX@<UPPER> simple-bus unit address format error, expected "<lower>"
> 
> This is a follow up to commit 4c9847b7375a ("dt-bindings: Remove leading 0x from bindings notation")
> 
> Reported-by: David Daney <ddaney@caviumnetworks.com>
> Suggested-by: Rob Herring <robh@kernel.org>
> Signed-off-by: Mathieu Malaterre <malat@debian.org>
> ---
>  arch/arm/boot/dts/socfpga.dtsi | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 

Acked-by: Dinh Nguyen <dinguyen@kernel.org>

Dinh

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2018-01-11 14:38 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-12-15 12:46 [PATCH 12/25] arm: socfpga: dts: Remove leading 0x and 0s from bindings notation Mathieu Malaterre
  -- strict thread matches above, loose matches on Subject: below --
2017-12-14 16:53 [PATCH] arm: " Mathieu Malaterre
2017-12-15 11:15 ` [PATCH 01/25] arm: artpec: " Mathieu Malaterre
2017-12-15 11:16   ` [PATCH 12/25] arm: socfpga: " Mathieu Malaterre
2018-01-11 14:38     ` Dinh Nguyen

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).