devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH 10/25] arm: orion5x: dts: Remove leading 0x and 0s from bindings notation
  2017-12-15 11:15 ` [PATCH 01/25] arm: artpec: " Mathieu Malaterre
@ 2017-12-15 11:16   ` Mathieu Malaterre
  0 siblings, 0 replies; 3+ messages in thread
From: Mathieu Malaterre @ 2017-12-15 11:16 UTC (permalink / raw)
  To: Rob Herring
  Cc: Mathieu Malaterre, Benoît Cousson, Tony Lindgren,
	Mark Rutland, Russell King, Jesper Nilsson, Lars Persson,
	Niklas Cassel, Nicolas Ferre, Alexandre Belloni, Ray Jui,
	Scott Branden, Jon Mason, bcm-kernel-feedback-list,
	Florian Fainelli, Sekhar Nori, Kevin Hilman, Kukjin Kim,
	Krzysztof Kozlowski, Shawn Guo, Sascha Hauer, Fabio Estevam,
	Santosh Shilimkar, Jason Cooper, Andrew Lunn, Gregory Clement,
	Sebastian Hesselbarth, Vladimir Zapolskiy, Sylvain Lemieux,
	Matthias Brugger, Barry Song, Heiko Stuebner, Dinh Nguyen,
	Viresh Kumar, Shiraz Hashim, Maxime Coquelin, Alexandre Torgue,
	Jun Nie, Baoyou Xie, linux-omap, devicetree, linux-arm-kernel,
	linux-kernel, linux-arm-kernel, linux-samsung-soc, linux-mediatek,
	linux-rockchip

Improve the DTS files by removing all the leading "0x" and zeros to fix the
following dtc warnings:

Warning (unit_address_format): Node /XXX unit name should not have leading "0x"

and

Warning (unit_address_format): Node /XXX unit name should not have leading 0s

Converted using the following command:

find . -type f \( -iname *.dts -o -iname *.dtsi \) -exec sed -i -e "s/@\([0-9a-fA-FxX\.;:#]+\)\s*{/@\L\1 {/g" -e "s/@0x\(.*\) {/@\1 {/g" -e "s/@0+\(.*\) {/@\1 {/g" {} +^C

For simplicity, two sed expressions were used to solve each warnings separately.

To make the regex expression more robust a few other issues were resolved,
namely setting unit-address to lower case, and adding a whitespace before the
the opening curly brace:

https://elinux.org/Device_Tree_Linux#Linux_conventions

This will solve as a side effect warning:

Warning (simple_bus_reg): Node /XXX@<UPPER> simple-bus unit address format error, expected "<lower>"

This is a follow up to commit 4c9847b7375a ("dt-bindings: Remove leading 0x from bindings notation")

Reported-by: David Daney <ddaney@caviumnetworks.com>
Suggested-by: Rob Herring <robh@kernel.org>
Signed-off-by: Mathieu Malaterre <malat@debian.org>
---
 arch/arm/boot/dts/orion5x-linkstation.dtsi | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/arm/boot/dts/orion5x-linkstation.dtsi b/arch/arm/boot/dts/orion5x-linkstation.dtsi
index e9991c83d7b7..7e418539fa54 100644
--- a/arch/arm/boot/dts/orion5x-linkstation.dtsi
+++ b/arch/arm/boot/dts/orion5x-linkstation.dtsi
@@ -126,7 +126,7 @@
 				read-only;
 			};
 
-			uboot_env@3F000 {
+			uboot_env@3f000 {
 				reg = <0x3F000 0x1000>;
 			};
 		};
-- 
2.11.0

^ permalink raw reply related	[flat|nested] 3+ messages in thread
* [PATCH 10/25] arm: orion5x: dts: Remove leading 0x and 0s from bindings notation
@ 2017-12-15 12:46 Mathieu Malaterre
  2017-12-15 13:01 ` Andrew Lunn
  0 siblings, 1 reply; 3+ messages in thread
From: Mathieu Malaterre @ 2017-12-15 12:46 UTC (permalink / raw)
  To: Rob Herring
  Cc: Mathieu Malaterre, Jason Cooper, Andrew Lunn,
	Sebastian Hesselbarth, Gregory Clement, Mark Rutland,
	Russell King, linux-arm-kernel, devicetree, linux-kernel

Improve the DTS files by removing all the leading "0x" and zeros to fix the
following dtc warnings:

Warning (unit_address_format): Node /XXX unit name should not have leading "0x"

and

Warning (unit_address_format): Node /XXX unit name should not have leading 0s

Converted using the following command:

find . -type f \( -iname *.dts -o -iname *.dtsi \) -exec sed -i -e "s/@\([0-9a-fA-FxX\.;:#]+\)\s*{/@\L\1 {/g" -e "s/@0x\(.*\) {/@\1 {/g" -e "s/@0+\(.*\) {/@\1 {/g" {} +^C

For simplicity, two sed expressions were used to solve each warnings separately.

To make the regex expression more robust a few other issues were resolved,
namely setting unit-address to lower case, and adding a whitespace before the
the opening curly brace:

https://elinux.org/Device_Tree_Linux#Linux_conventions

This will solve as a side effect warning:

Warning (simple_bus_reg): Node /XXX@<UPPER> simple-bus unit address format error, expected "<lower>"

This is a follow up to commit 4c9847b7375a ("dt-bindings: Remove leading 0x from bindings notation")

Reported-by: David Daney <ddaney@caviumnetworks.com>
Suggested-by: Rob Herring <robh@kernel.org>
Signed-off-by: Mathieu Malaterre <malat@debian.org>
---
 arch/arm/boot/dts/orion5x-linkstation.dtsi | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/arm/boot/dts/orion5x-linkstation.dtsi b/arch/arm/boot/dts/orion5x-linkstation.dtsi
index e9991c83d7b7..7e418539fa54 100644
--- a/arch/arm/boot/dts/orion5x-linkstation.dtsi
+++ b/arch/arm/boot/dts/orion5x-linkstation.dtsi
@@ -126,7 +126,7 @@
 				read-only;
 			};
 
-			uboot_env@3F000 {
+			uboot_env@3f000 {
 				reg = <0x3F000 0x1000>;
 			};
 		};
-- 
2.11.0

^ permalink raw reply related	[flat|nested] 3+ messages in thread
* Re: [PATCH 10/25] arm: orion5x: dts: Remove leading 0x and 0s from bindings notation
  2017-12-15 12:46 [PATCH 10/25] arm: orion5x: dts: Remove leading 0x and 0s from bindings notation Mathieu Malaterre
@ 2017-12-15 13:01 ` Andrew Lunn
  0 siblings, 0 replies; 3+ messages in thread
From: Andrew Lunn @ 2017-12-15 13:01 UTC (permalink / raw)
  To: Mathieu Malaterre
  Cc: Rob Herring, Jason Cooper, Sebastian Hesselbarth, Gregory Clement,
	Mark Rutland, Russell King, linux-arm-kernel, devicetree,
	linux-kernel

On Fri, Dec 15, 2017 at 01:46:42PM +0100, Mathieu Malaterre wrote:
> Improve the DTS files by removing all the leading "0x" and zeros to fix the

...

>  			};
>  
> -			uboot_env@3F000 {
> +			uboot_env@3f000 {
>  				reg = <0x3F000 0x1000>;

Hi Mathieu

Thanks for looking at this. But the commit message does not fit the
actual change.

       Andrew

^ permalink raw reply	[flat|nested] 3+ messages in thread
end of thread, other threads:[~2017-12-15 13:01 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-12-15 12:46 [PATCH 10/25] arm: orion5x: dts: Remove leading 0x and 0s from bindings notation Mathieu Malaterre
2017-12-15 13:01 ` Andrew Lunn
  -- strict thread matches above, loose matches on Subject: below --
2017-12-14 16:53 [PATCH] arm: " Mathieu Malaterre
2017-12-15 11:15 ` [PATCH 01/25] arm: artpec: " Mathieu Malaterre
2017-12-15 11:16   ` [PATCH 10/25] arm: orion5x: " Mathieu Malaterre

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).