From mboxrd@z Thu Jan 1 00:00:00 1970 From: Bjorn Andersson Subject: Re: [PATCH v2 05/10] arm64: dts: qcom: apq8016-sbc: sort nodes alphabetically Date: Fri, 15 Dec 2017 21:17:04 -0800 Message-ID: <20171216051704.GB4281@tuxbook> References: <20171207151942.5805-1-damien.riegel@savoirfairelinux.com> <20171207151942.5805-6-damien.riegel@savoirfairelinux.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <20171207151942.5805-6-damien.riegel-4ysUXcep3aM1wj+D4I0NRVaTQe2KTcn/@public.gmane.org> Sender: devicetree-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Damien Riegel Cc: linux-arm-msm-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-soc-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Andy Gross , David Brown , Rob Herring , Mark Rutland , Catalin Marinas , Will Deacon , kernel-4ysUXcep3aM1wj+D4I0NRVaTQe2KTcn/@public.gmane.org List-Id: devicetree@vger.kernel.org On Thu 07 Dec 07:19 PST 2017, Damien Riegel wrote: > Also, it was using whitespaces for indentation on some lines, fix that > while moving it. > > Signed-off-by: Damien Riegel Rather than extending single nodes like this I would prefer that we bring in the associated pmic node, by this we avoid just having a huge flat list of nodes. I.e. that we make this: &pm8916_1 { codec@f000 { status = "okay"; clocks = <&gcc GCC_CODEC_DIGCODEC_CLK>; clock-names = "mclk"; qcom,mbhc-vthreshold-low = <75 150 237 450 500>; qcom,mbhc-vthreshold-high = <75 150 237 450 500>; }; }; Regards, Bjorn -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html