From: Bjorn Andersson <bjorn.andersson@linaro.org>
To: Damien Riegel <damien.riegel@savoirfairelinux.com>
Cc: linux-arm-msm@vger.kernel.org, linux-soc@vger.kernel.org,
devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, Andy Gross <andy.gross@linaro.org>,
David Brown <david.brown@linaro.org>,
Rob Herring <robh+dt@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
Catalin Marinas <catalin.marinas@arm.com>,
Will Deacon <will.deacon@arm.com>,
kernel@savoirfairelinux.com
Subject: Re: [PATCH v2 06/10] arm64: dts: qcom: msm8916: move pinconfs to board files
Date: Fri, 15 Dec 2017 21:18:33 -0800 [thread overview]
Message-ID: <20171216051833.GC4281@tuxbook> (raw)
In-Reply-To: <20171207151942.5805-7-damien.riegel@savoirfairelinux.com>
On Thu 07 Dec 07:19 PST 2017, Damien Riegel wrote:
> Following a suggestion from Bjorn Andersson [1], this commit moves
> electrical specifications which were defined in mms8916-pins.dtsi to
> board files, where they actually belong.
>
> Pinmuxing is kept in the platform file because there are no alternative
> pins on which all these functions could be routed, so this part is
> indeed common to all boards using this SoC.
>
> [1] https://www.spinics.net/lists/devicetree/msg201764.html
>
> Signed-off-by: Damien Riegel <damien.riegel@savoirfairelinux.com>
> Suggested-by: Bjorn Andersson <bjorn.andersson@linaro.org>
I like the move, but I would prefer that you mimic the base structure,
rather than just appending properties based on labels.
Regards,
Bjorn
next prev parent reply other threads:[~2017-12-16 5:18 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-07 15:19 [PATCH v2 00/10] arm64: dts: qcom: dts improvements Damien Riegel
2017-12-07 15:19 ` [PATCH v2 01/10] arm64: dts: qcom: pm8916: fix wcd_codec indentation Damien Riegel
2017-12-07 15:19 ` [PATCH v2 02/10] arm64: dts: qcom: msm8916-pins: remove assignments to bias-disable Damien Riegel
2017-12-07 15:19 ` [PATCH v2 03/10] arm64: dts: qcom: msm8916-pins: keep cdc_dmic pins in suspend mode Damien Riegel
2017-12-07 15:19 ` [PATCH v2 04/10] arm64: dts: qcom: msm8916: drop unused board-specific nodes Damien Riegel
[not found] ` <20171207151942.5805-5-damien.riegel-4ysUXcep3aM1wj+D4I0NRVaTQe2KTcn/@public.gmane.org>
2017-12-16 5:12 ` Bjorn Andersson
[not found] ` <20171207151942.5805-1-damien.riegel-4ysUXcep3aM1wj+D4I0NRVaTQe2KTcn/@public.gmane.org>
2017-12-07 15:19 ` [PATCH v2 05/10] arm64: dts: qcom: apq8016-sbc: sort nodes alphabetically Damien Riegel
[not found] ` <20171207151942.5805-6-damien.riegel-4ysUXcep3aM1wj+D4I0NRVaTQe2KTcn/@public.gmane.org>
2017-12-16 5:17 ` Bjorn Andersson
2017-12-07 15:19 ` [PATCH v2 06/10] arm64: dts: qcom: msm8916: move pinconfs to board files Damien Riegel
2017-12-16 5:18 ` Bjorn Andersson [this message]
2017-12-07 15:19 ` [PATCH v2 08/10] arm64: dts: qcom: msm8916-pins: move sdhc2 cd node with its siblings Damien Riegel
[not found] ` <20171207151942.5805-9-damien.riegel-4ysUXcep3aM1wj+D4I0NRVaTQe2KTcn/@public.gmane.org>
2017-12-16 5:19 ` Bjorn Andersson
2017-12-07 15:19 ` [PATCH v2 07/10] arm64: dts: qcom: msm8916: drop remaining unused pinconfs Damien Riegel
2017-12-16 5:18 ` Bjorn Andersson
2017-12-07 15:19 ` [PATCH v2 09/10] arm64: dts: qcom: msm8916: normalize I2C and SPI nodes Damien Riegel
2017-12-16 5:20 ` Bjorn Andersson
2017-12-07 15:19 ` [PATCH v2 10/10] arm64: dts: qcom: msm8916: add nodes for i2c1, i2c3, i2c5 Damien Riegel
2017-12-16 5:23 ` Bjorn Andersson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171216051833.GC4281@tuxbook \
--to=bjorn.andersson@linaro.org \
--cc=andy.gross@linaro.org \
--cc=catalin.marinas@arm.com \
--cc=damien.riegel@savoirfairelinux.com \
--cc=david.brown@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=kernel@savoirfairelinux.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-soc@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=robh+dt@kernel.org \
--cc=will.deacon@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).