Re: [PATCH v2 6/7] i3c: master: Add driver for Cadence IP

Randy Dunlap
2017-12-14T22:10:06Z

On 12/14/2017 12:44 PM, Boris Brezillon wrote:
> On Thu, 14 Dec 2017 12:25:14 -0800
> Randy Dunlap <rdunlap-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org> wrote:
>
>> On 12/14/2017 12:17 PM, Boris Brezillon wrote:
>>>>> + events.events = I3C_CCC_EVENT_HJ | I3C_CCC_EVENT_MR;
>>>>> + ret = i3c_master_enec_locked(m, I3C_BROADCAST_ADDR, &events);
>>>>> + if (ret)
>>>>> + pr_info("Failed to re-enable H-J");
>>>> Not very good info...
>>> What do you mean? Is it the H-J that bothers you (I can replace it by
>>> 'Hot-Join'), or is it something else?
>>
>> Who is the message for? If it's for developers, you could use
>> pr_debug(). If it's for users, it needs more clarity.
>
> I think it's of interest to anyone including users. If we fail to
> re-enable Hot-Join that means hotplug is no longer working which is
> a bad news.
>
>>
>> Does it print the source of the message? (module name e.g.)
>
> I could replace it by
>
> dev_err(m->parent, "Failed to re-enable Hot-Join");
>

Yes, that's a good plan.

Thanks.

>
>
>> and yes, Hot-Join would be better IMO.

--
~Randy
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html