From: Simon Shields <simon@lineageos.org>
To: Rob Herring <robh@kernel.org>
Cc: linux-samsung-soc@vger.kernel.org,
"Kukjin Kim" <kgene@kernel.org>,
"Krzysztof Kozlowski" <krzk@kernel.org>,
devicetree@vger.kernel.org,
"Marek Szyprowski" <m.szyprowski@samsung.com>,
"Bartłomiej Żołnierkiewicz" <b.zolnierkie@samsung.com>
Subject: Re: [PATCH v3 1/4] dt-bindings: samsung: document bindings for Midas family boards
Date: Thu, 21 Dec 2017 12:42:46 +1100 [thread overview]
Message-ID: <20171221014246.GA23568@lineageos.org> (raw)
In-Reply-To: <20171220181759.6r4waz4seerh6q4i@rob-hp-laptop>
Hi Rob,
Thanks for the review.
On Wed, Dec 20, 2017 at 12:17:59PM -0600, Rob Herring wrote:
> On Mon, Dec 18, 2017 at 11:38:02PM +1100, Simon Shields wrote:
> > Document GT-I9300, GT-I9305, GT-N7100, and GT-N7105 bindings, along
> > with the shared "midas" binding.
> >
> > Signed-off-by: Simon Shields <simon@lineageos.org>
> > ---
> > Documentation/devicetree/bindings/arm/samsung/samsung-boards.txt | 4 ++++
> > 1 file changed, 4 insertions(+)
>
> My comment on v2 remains.
Do you have any example of a better description? All the other ARM board
descriptions seem similarly terse.
Alternatively, maybe changing the compatible strings is a better
solution? "samsung,n710x" for t0, "samsung,i9300" for m0, and
"samsung,i9305" for m3?
Cheers,
Simon
next prev parent reply other threads:[~2017-12-21 1:42 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-18 12:38 [PATCH v3 0/4] Add Exynos4412-based midas boards support Simon Shields
2017-12-18 12:38 ` [PATCH v3 2/4] ARM: dts: split trats2 DTS in preparation for midas boards Simon Shields
2017-12-20 14:05 ` Krzysztof Kozlowski
2017-12-20 15:27 ` Simon Shields
2017-12-20 15:38 ` Krzysztof Kozlowski
[not found] ` <CAJKOXPdzAvsaAOo6P+UA8VWYd7YjmtSqtkyKtNaz7jNdUXUH4A-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2017-12-20 18:19 ` Rob Herring
2017-12-21 1:54 ` Simon Shields
2017-12-21 7:57 ` Krzysztof Kozlowski
[not found] ` <20171218123805.26345-1-simon-WP75azK+jQYgsBAKwltoeQ@public.gmane.org>
2017-12-18 12:38 ` [PATCH v3 1/4] dt-bindings: samsung: document bindings for Midas family boards Simon Shields
2017-12-20 18:17 ` Rob Herring
2017-12-21 1:42 ` Simon Shields [this message]
[not found] ` <20171221014246.GA23568-WP75azK+jQYgsBAKwltoeQ@public.gmane.org>
2017-12-26 18:02 ` Rob Herring
2017-12-18 12:38 ` [PATCH v3 3/4] ARM: dts: add Samsung's exynos4412-based midas boards Simon Shields
2017-12-20 14:08 ` Krzysztof Kozlowski
2017-12-20 15:33 ` Simon Shields
[not found] ` <20171220153315.GB23127-WP75azK+jQYgsBAKwltoeQ@public.gmane.org>
2017-12-20 15:39 ` Krzysztof Kozlowski
2017-12-18 12:38 ` [PATCH v3 4/4] ARM: exynos: extend cpuidle support to " Simon Shields
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171221014246.GA23568@lineageos.org \
--to=simon@lineageos.org \
--cc=b.zolnierkie@samsung.com \
--cc=devicetree@vger.kernel.org \
--cc=kgene@kernel.org \
--cc=krzk@kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=m.szyprowski@samsung.com \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).