From mboxrd@z Thu Jan 1 00:00:00 1970 From: Simon Shields Subject: Re: [PATCH v3 1/4] dt-bindings: samsung: document bindings for Midas family boards Date: Thu, 21 Dec 2017 12:42:46 +1100 Message-ID: <20171221014246.GA23568@lineageos.org> References: <20171218123805.26345-1-simon@lineageos.org> <20171218123805.26345-2-simon@lineageos.org> <20171220181759.6r4waz4seerh6q4i@rob-hp-laptop> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <20171220181759.6r4waz4seerh6q4i@rob-hp-laptop> Sender: linux-samsung-soc-owner@vger.kernel.org To: Rob Herring Cc: linux-samsung-soc@vger.kernel.org, Kukjin Kim , Krzysztof Kozlowski , devicetree@vger.kernel.org, Marek Szyprowski , =?utf-8?Q?Bart=C5=82omiej_=C5=BBo=C5=82nierkiewicz?= List-Id: devicetree@vger.kernel.org Hi Rob, Thanks for the review. On Wed, Dec 20, 2017 at 12:17:59PM -0600, Rob Herring wrote: > On Mon, Dec 18, 2017 at 11:38:02PM +1100, Simon Shields wrote: > > Document GT-I9300, GT-I9305, GT-N7100, and GT-N7105 bindings, along > > with the shared "midas" binding. > > > > Signed-off-by: Simon Shields > > --- > > Documentation/devicetree/bindings/arm/samsung/samsung-boards.txt | 4 ++++ > > 1 file changed, 4 insertions(+) > > My comment on v2 remains. Do you have any example of a better description? All the other ARM board descriptions seem similarly terse. Alternatively, maybe changing the compatible strings is a better solution? "samsung,n710x" for t0, "samsung,i9300" for m0, and "samsung,i9305" for m3? Cheers, Simon