From mboxrd@z Thu Jan 1 00:00:00 1970 From: Johan Hovold Subject: Re: [PATCH v5 5/5] misc serdev: w2sg0004: add debugging code and Kconfig Date: Fri, 22 Dec 2017 13:51:50 +0100 Message-ID: <20171222125150.GJ3374@localhost> References: <5816bfb9e7cab68591c133e20696d6188ebe70de.1512114577.git.hns@goldelico.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <5816bfb9e7cab68591c133e20696d6188ebe70de.1512114577.git.hns-xXXSsgcRVICgSpxsJD1C4w@public.gmane.org> Sender: devicetree-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: "H. Nikolaus Schaller" Cc: Rob Herring , Mark Rutland , =?iso-8859-1?Q?Beno=EEt?= Cousson , Tony Lindgren , Russell King , Arnd Bergmann , Greg Kroah-Hartman , Kevin Hilman , Andreas =?iso-8859-1?Q?F=E4rber?= , Thierry Reding , Jonathan Cameron , devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-omap-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, letux-kernel-S0jZdbWzriLCfDggNXIi3w@public.gmane.org, kernel-Jl6IXVxNIMRxAtABVqVhTwC/G2K4zDHf@public.gmane.org, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org List-Id: devicetree@vger.kernel.org On Fri, Dec 01, 2017 at 08:49:38AM +0100, H. Nikolaus Schaller wrote: > This allows to set CONFIG_W2SG0004_DEBUG which will > make the driver report more activities and it will turn on the > GPS module during boot while the driver assumes that it > is off. This can be used to debug the correct functioning of > the hardware. Therefore we add it as an option to the driver > because we think it is of general use (and a little tricky to > add by system testers). > > Normally it should be off. > > Signed-off-by: H. Nikolaus Schaller > --- > drivers/misc/Kconfig | 8 ++++++++ > drivers/misc/w2sg0004.c | 37 +++++++++++++++++++++++++++++++++++++ > 2 files changed, 45 insertions(+) I'd say say this does not belong in the kernel at all. And even if the power-state test were to be allowed, most of the pr_debugs would need to go. You really should be using dev_dbg and friends, which can already be enabled selectively at run time using dynamic debugging. Johan -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html