From mboxrd@z Thu Jan 1 00:00:00 1970 From: Rob Herring Subject: Re: [PATCH V8 3/3] OPP: Allow "opp-hz" and "opp-microvolt" to contain magic values Date: Tue, 26 Dec 2017 14:29:55 -0600 Message-ID: <20171226202955.32j7gzonrixtwdpt@rob-hp-laptop> References: <476d7ae69184d787ccc6d99f8df6069007fd0a91.1513591822.git.viresh.kumar@linaro.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <476d7ae69184d787ccc6d99f8df6069007fd0a91.1513591822.git.viresh.kumar-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org> Sender: devicetree-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Viresh Kumar Cc: ulf.hansson-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org, Kevin Hilman , Viresh Kumar , Nishanth Menon , Stephen Boyd , Rafael Wysocki , linux-pm-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Vincent Guittot , rnayak-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org, sudeep.holla-5wv7dgnIgG8@public.gmane.org, devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-Id: devicetree@vger.kernel.org On Mon, Dec 18, 2017 at 03:51:30PM +0530, Viresh Kumar wrote: > On some platforms the exact frequency or voltage may be hidden from the > OS by the firmware. Allow such configurations to pass magic values in > the "opp-hz" or the "opp-microvolt" properties, which should be > interpreted in a platform dependent way. > > Reviewed-by: Ulf Hansson > Signed-off-by: Viresh Kumar > --- > Documentation/devicetree/bindings/opp/opp.txt | 6 ++++++ > 1 file changed, 6 insertions(+) > > diff --git a/Documentation/devicetree/bindings/opp/opp.txt b/Documentation/devicetree/bindings/opp/opp.txt > index 4e4f30288c8b..00a3bdbd0f1f 100644 > --- a/Documentation/devicetree/bindings/opp/opp.txt > +++ b/Documentation/devicetree/bindings/opp/opp.txt > @@ -167,6 +167,12 @@ properties. > functioning of the current device at the current OPP (where this property is > present). > > + > +On some platforms the exact frequency or voltage may be hidden from the OS by > +the firmware and the "opp-hz" or the "opp-microvolt" properties may contain > +magic values that represent the frequency or voltage in a firmware dependent > +way, for example an index of an array in the firmware. I'm still not convinced this is a good idea. If you have firmware partially managing things, then I think we should have platform specific bindings or drivers. This is complex enough I'm not taking silence from Stephen as an okay. Rob -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html