devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH v2 0/2] arm64: dts: r8a7795: r8a7796: add thermal cooling management
@ 2018-01-04 16:03 Niklas Söderlund
       [not found] ` <20180104160320.11514-1-niklas.soderlund+renesas-1zkq55x86MTxsAP9Fp7wbw@public.gmane.org>
                   ` (2 more replies)
  0 siblings, 3 replies; 4+ messages in thread
From: Niklas Söderlund @ 2018-01-04 16:03 UTC (permalink / raw)
  To: linux-pm, devicetree, Simon Horman, Magnus Damm
  Cc: linux-renesas-soc, Niklas Söderlund

Hi,

This series adds support for for using CPUFreq as a cooling device for
the A57 CUP:s on Renesas H3 and M3-W SoC:s. It depends on Simon Horman's
topic/rcar-gen3-cpufreq-v4 branch [1] and is tested on H3 and M3-W. For 
test results and test procedure please see:

   http://elinux.org/R-Car/Tests:rcar_gen3_thermal

Few notes on the specific values used in this series and why they might
need to be changed.

- The trip point temperature of 95000 used is the most conservative one
  from the BSP and maybe should be set at 110000 which is the most
  aggressive one in the BSP.

- The cooling states described in all cooling-maps nodes might be
  subject to change depending on the out-come of the ongoing review
  process of Simon's work. It should use the highest possible cooling
  state so if the number of states change due review of his work this
  should be reflected in this series.

1.  https://git.kernel.org/pub/scm/linux/kernel/git/horms/renesas.git

* Changes since v1
- Added acks from Eduardo Valentin.
- Rebased on top of the latest branch of Simons work.

Niklas Söderlund (2):
  arm64: dts: r8a7795: add thermal cooling management
  arm64: dts: r8a7796: add thermal cooling management

 arch/arm64/boot/dts/renesas/r8a7795.dtsi | 40 ++++++++++++++++++++++++++++++++
 arch/arm64/boot/dts/renesas/r8a7796.dtsi | 38 ++++++++++++++++++++++++++++++
 2 files changed, 78 insertions(+)

-- 
2.15.1

^ permalink raw reply	[flat|nested] 4+ messages in thread

* [PATCH v2 1/2] arm64: dts: r8a7795: add thermal cooling management
       [not found] ` <20180104160320.11514-1-niklas.soderlund+renesas-1zkq55x86MTxsAP9Fp7wbw@public.gmane.org>
@ 2018-01-04 16:03   ` Niklas Söderlund
  0 siblings, 0 replies; 4+ messages in thread
From: Niklas Söderlund @ 2018-01-04 16:03 UTC (permalink / raw)
  To: linux-pm-u79uwXL29TY76Z2rM5mHXA,
	devicetree-u79uwXL29TY76Z2rM5mHXA, Simon Horman, Magnus Damm
  Cc: linux-renesas-soc-u79uwXL29TY76Z2rM5mHXA, Niklas Söderlund

Add nodes and properties for thermal cooling management support.

Signed-off-by: Niklas Söderlund <niklas.soderlund+renesas-1zkq55x86MTxsAP9Fp7wbw@public.gmane.org>
Acked-by: Eduardo Valentin <edubezval-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
---
 arch/arm64/boot/dts/renesas/r8a7795.dtsi | 40 ++++++++++++++++++++++++++++++++
 1 file changed, 40 insertions(+)

diff --git a/arch/arm64/boot/dts/renesas/r8a7795.dtsi b/arch/arm64/boot/dts/renesas/r8a7795.dtsi
index 1485e6a8e11220fe..19b7de57704c67e8 100644
--- a/arch/arm64/boot/dts/renesas/r8a7795.dtsi
+++ b/arch/arm64/boot/dts/renesas/r8a7795.dtsi
@@ -43,6 +43,7 @@
 			enable-method = "psci";
 			clocks =<&cpg CPG_CORE R8A7795_CLK_Z>;
 			operating-points-v2 = <&cluster0_opp>;
+			#cooling-cells = <2>;
 		};
 
 		a57_1: cpu@1 {
@@ -54,6 +55,7 @@
 			enable-method = "psci";
 			clocks =<&cpg CPG_CORE R8A7795_CLK_Z>;
 			operating-points-v2 = <&cluster0_opp>;
+			#cooling-cells = <2>;
 		};
 
 		a57_2: cpu@2 {
@@ -65,6 +67,7 @@
 			enable-method = "psci";
 			clocks =<&cpg CPG_CORE R8A7795_CLK_Z>;
 			operating-points-v2 = <&cluster0_opp>;
+			#cooling-cells = <2>;
 		};
 
 		a57_3: cpu@3 {
@@ -76,6 +79,7 @@
 			enable-method = "psci";
 			clocks =<&cpg CPG_CORE R8A7795_CLK_Z>;
 			operating-points-v2 = <&cluster0_opp>;
+			#cooling-cells = <2>;
 		};
 
 		a53_0: cpu@100 {
@@ -2418,12 +2422,24 @@
 			thermal-sensors = <&tsc 0>;
 
 			trips {
+				sensor1_passive: sensor1-passive {
+					temperature = <95000>;
+					hysteresis = <2000>;
+					type = "passive";
+				};
 				sensor1_crit: sensor1-crit {
 					temperature = <120000>;
 					hysteresis = <2000>;
 					type = "critical";
 				};
 			};
+
+			cooling-maps {
+				map0 {
+					trip = <&sensor1_passive>;
+					cooling-device = <&a57_0 4 4>;
+				};
+			};
 		};
 
 		sensor_thermal2: sensor-thermal2 {
@@ -2432,12 +2448,24 @@
 			thermal-sensors = <&tsc 1>;
 
 			trips {
+				sensor2_passive: sensor2-passive {
+					temperature = <95000>;
+					hysteresis = <2000>;
+					type = "passive";
+				};
 				sensor2_crit: sensor2-crit {
 					temperature = <120000>;
 					hysteresis = <2000>;
 					type = "critical";
 				};
 			};
+
+			cooling-maps {
+				map0 {
+					trip = <&sensor2_passive>;
+					cooling-device = <&a57_0 4 4>;
+				};
+			};
 		};
 
 		sensor_thermal3: sensor-thermal3 {
@@ -2446,12 +2474,24 @@
 			thermal-sensors = <&tsc 2>;
 
 			trips {
+				sensor3_passive: sensor3-passive {
+					temperature = <95000>;
+					hysteresis = <2000>;
+					type = "passive";
+				};
 				sensor3_crit: sensor3-crit {
 					temperature = <120000>;
 					hysteresis = <2000>;
 					type = "critical";
 				};
 			};
+
+			cooling-maps {
+				map0 {
+					trip = <&sensor3_passive>;
+					cooling-device = <&a57_0 4 4>;
+				};
+			};
 		};
 	};
 
-- 
2.15.1

--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

^ permalink raw reply related	[flat|nested] 4+ messages in thread

* [PATCH v2 2/2] arm64: dts: r8a7796: add thermal cooling management
  2018-01-04 16:03 [PATCH v2 0/2] arm64: dts: r8a7795: r8a7796: add thermal cooling management Niklas Söderlund
       [not found] ` <20180104160320.11514-1-niklas.soderlund+renesas-1zkq55x86MTxsAP9Fp7wbw@public.gmane.org>
@ 2018-01-04 16:03 ` Niklas Söderlund
  2018-01-04 16:50 ` [PATCH v2 0/2] arm64: dts: r8a7795: " Simon Horman
  2 siblings, 0 replies; 4+ messages in thread
From: Niklas Söderlund @ 2018-01-04 16:03 UTC (permalink / raw)
  To: linux-pm, devicetree, Simon Horman, Magnus Damm
  Cc: linux-renesas-soc, Niklas Söderlund

Add nodes and properties for thermal cooling management support.

Signed-off-by: Niklas Söderlund <niklas.soderlund+renesas@ragnatech.se>
Acked-by: Eduardo Valentin <edubezval@gmail.com>
---
 arch/arm64/boot/dts/renesas/r8a7796.dtsi | 38 ++++++++++++++++++++++++++++++++
 1 file changed, 38 insertions(+)

diff --git a/arch/arm64/boot/dts/renesas/r8a7796.dtsi b/arch/arm64/boot/dts/renesas/r8a7796.dtsi
index e06bde6e28532b3a..ef10fb548681d36a 100644
--- a/arch/arm64/boot/dts/renesas/r8a7796.dtsi
+++ b/arch/arm64/boot/dts/renesas/r8a7796.dtsi
@@ -73,6 +73,7 @@
 			enable-method = "psci";
 			clocks =<&cpg CPG_CORE R8A7796_CLK_Z>;
 			operating-points-v2 = <&cluster0_opp>;
+			#cooling-cells = <2>;
 		};
 
 		a57_1: cpu@1 {
@@ -84,6 +85,7 @@
 			enable-method = "psci";
 			clocks =<&cpg CPG_CORE R8A7796_CLK_Z>;
 			operating-points-v2 = <&cluster0_opp>;
+			#cooling-cells = <2>;
 		};
 
 		a53_0: cpu@100 {
@@ -2060,12 +2062,24 @@
 			thermal-sensors = <&tsc 0>;
 
 			trips {
+				sensor1_passive: sensor1-passive {
+					temperature = <95000>;
+					hysteresis = <2000>;
+					type = "passive";
+				};
 				sensor1_crit: sensor1-crit {
 					temperature = <120000>;
 					hysteresis = <2000>;
 					type = "critical";
 				};
 			};
+
+			cooling-maps {
+				map0 {
+					trip = <&sensor1_passive>;
+					cooling-device = <&a57_0 5 5>;
+				};
+			};
 		};
 
 		sensor_thermal2: sensor-thermal2 {
@@ -2074,12 +2088,24 @@
 			thermal-sensors = <&tsc 1>;
 
 			trips {
+				sensor2_passive: sensor2-passive {
+					temperature = <95000>;
+					hysteresis = <2000>;
+					type = "passive";
+				};
 				sensor2_crit: sensor2-crit {
 					temperature = <120000>;
 					hysteresis = <2000>;
 					type = "critical";
 				};
 			};
+
+			cooling-maps {
+				map0 {
+					trip = <&sensor2_passive>;
+					cooling-device = <&a57_0 5 5>;
+				};
+			};
 		};
 
 		sensor_thermal3: sensor-thermal3 {
@@ -2088,12 +2114,24 @@
 			thermal-sensors = <&tsc 2>;
 
 			trips {
+				sensor3_passive: sensor3-passive {
+					temperature = <95000>;
+					hysteresis = <2000>;
+					type = "passive";
+				};
 				sensor3_crit: sensor3-crit {
 					temperature = <120000>;
 					hysteresis = <2000>;
 					type = "critical";
 				};
 			};
+
+			cooling-maps {
+				map0 {
+					trip = <&sensor3_passive>;
+					cooling-device = <&a57_0 5 5>;
+				};
+			};
 		};
 	};
 
-- 
2.15.1

^ permalink raw reply related	[flat|nested] 4+ messages in thread

* Re: [PATCH v2 0/2] arm64: dts: r8a7795: r8a7796: add thermal cooling management
  2018-01-04 16:03 [PATCH v2 0/2] arm64: dts: r8a7795: r8a7796: add thermal cooling management Niklas Söderlund
       [not found] ` <20180104160320.11514-1-niklas.soderlund+renesas-1zkq55x86MTxsAP9Fp7wbw@public.gmane.org>
  2018-01-04 16:03 ` [PATCH v2 2/2] arm64: dts: r8a7796: " Niklas Söderlund
@ 2018-01-04 16:50 ` Simon Horman
  2 siblings, 0 replies; 4+ messages in thread
From: Simon Horman @ 2018-01-04 16:50 UTC (permalink / raw)
  To: Niklas Söderlund
  Cc: linux-pm, devicetree, Magnus Damm, linux-renesas-soc

On Thu, Jan 04, 2018 at 05:03:18PM +0100, Niklas Söderlund wrote:
> Hi,
> 
> This series adds support for for using CPUFreq as a cooling device for
> the A57 CUP:s on Renesas H3 and M3-W SoC:s. It depends on Simon Horman's
> topic/rcar-gen3-cpufreq-v4 branch [1] and is tested on H3 and M3-W. For 
> test results and test procedure please see:
> 
>    http://elinux.org/R-Car/Tests:rcar_gen3_thermal
> 
> Few notes on the specific values used in this series and why they might
> need to be changed.
> 
> - The trip point temperature of 95000 used is the most conservative one
>   from the BSP and maybe should be set at 110000 which is the most
>   aggressive one in the BSP.
> 
> - The cooling states described in all cooling-maps nodes might be
>   subject to change depending on the out-come of the ongoing review
>   process of Simon's work. It should use the highest possible cooling
>   state so if the number of states change due review of his work this
>   should be reflected in this series.
> 
> 1.  https://git.kernel.org/pub/scm/linux/kernel/git/horms/renesas.git
> 
> * Changes since v1
> - Added acks from Eduardo Valentin.
> - Rebased on top of the latest branch of Simons work.
> 
> Niklas Söderlund (2):
>   arm64: dts: r8a7795: add thermal cooling management
>   arm64: dts: r8a7796: add thermal cooling management

Thanks, applied.

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2018-01-04 16:50 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-01-04 16:03 [PATCH v2 0/2] arm64: dts: r8a7795: r8a7796: add thermal cooling management Niklas Söderlund
     [not found] ` <20180104160320.11514-1-niklas.soderlund+renesas-1zkq55x86MTxsAP9Fp7wbw@public.gmane.org>
2018-01-04 16:03   ` [PATCH v2 1/2] arm64: dts: r8a7795: " Niklas Söderlund
2018-01-04 16:03 ` [PATCH v2 2/2] arm64: dts: r8a7796: " Niklas Söderlund
2018-01-04 16:50 ` [PATCH v2 0/2] arm64: dts: r8a7795: " Simon Horman

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).