devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Andrew F. Davis" <afd-l0cyMroinI0@public.gmane.org>
To: Santosh Shilimkar
	<ssantosh-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
	Rob Herring <robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
	Mark Rutland <mark.rutland-5wv7dgnIgG8@public.gmane.org>,
	Nishanth Menon <nm-l0cyMroinI0@public.gmane.org>,
	Suman Anna <s-anna-l0cyMroinI0@public.gmane.org>
Cc: linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
	devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	"Andrew F . Davis" <afd-l0cyMroinI0@public.gmane.org>
Subject: [PATCH v2 02/10] ARM: dts: keystone: Move reset-controller to under device-state-control
Date: Thu, 4 Jan 2018 13:56:53 -0600	[thread overview]
Message-ID: <20180104195701.4042-3-afd@ti.com> (raw)
In-Reply-To: <20180104195701.4042-1-afd-l0cyMroinI0@public.gmane.org>

The keystone_irq node describes a device that is a member of the device
state control module address space. As such, it should not be a member
of soc0 bus but instead a sub-node of device-state-control.

This move also fixes a warning about not having a reg property. Now
that this is a sub-node of device-state-control, a syscon type node,
we add this reg property but relative to the syscon base, this way
when the dt-binding/driver are updated we can drop the non-standard
ti,syscon-dev property completely and simply use get_resource() in
the driver.

Signed-off-by: Andrew F. Davis <afd-l0cyMroinI0@public.gmane.org>
Acked-by: Nishanth Menon <nm-l0cyMroinI0@public.gmane.org>
---
 arch/arm/boot/dts/keystone.dtsi | 13 +++++++------
 1 file changed, 7 insertions(+), 6 deletions(-)

diff --git a/arch/arm/boot/dts/keystone.dtsi b/arch/arm/boot/dts/keystone.dtsi
index d726896ffb38..5246042f522b 100644
--- a/arch/arm/boot/dts/keystone.dtsi
+++ b/arch/arm/boot/dts/keystone.dtsi
@@ -101,13 +101,14 @@
 				#interrupt-cells = <1>;
 				ti,syscon-dev = <&devctrl 0x2a0>;
 			};
-		};
 
-		rstctrl: reset-controller {
-			compatible = "ti,keystone-reset";
-			ti,syscon-pll = <&pllctrl 0xe4>;
-			ti,syscon-dev = <&devctrl 0x328>;
-			ti,wdt-list = <0>;
+			rstctrl: reset-controller@328 {
+				compatible = "ti,keystone-reset";
+				reg = <0x328 0x10>;
+				ti,syscon-pll = <&pllctrl 0xe4>;
+				ti,syscon-dev = <&devctrl 0x328>;
+				ti,wdt-list = <0>;
+			};
 		};
 
 		/include/ "keystone-clocks.dtsi"
-- 
2.15.1

--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

  parent reply	other threads:[~2018-01-04 19:56 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-01-04 19:56 [PATCH v2 00/10] ARM: dts: keystone*: Continued warnings cleanups Andrew F. Davis
     [not found] ` <20180104195701.4042-1-afd-l0cyMroinI0@public.gmane.org>
2018-01-04 19:56   ` [PATCH v2 01/10] ARM: dts: keystone: Move keystone_irq to under device-state-control Andrew F. Davis
2018-01-04 19:56   ` Andrew F. Davis [this message]
2018-01-04 19:56   ` [PATCH v2 03/10] ARM: dts: keystone-k2e: Move keystone_dsp_gpio " Andrew F. Davis
2018-01-04 19:56   ` [PATCH v2 04/10] ARM: dts: keystone-k2l: " Andrew F. Davis
2018-01-04 19:56   ` [PATCH v2 05/10] ARM: dts: keystone-k2hk: " Andrew F. Davis
2018-01-04 19:56   ` [PATCH v2 06/10] ARM: dts: keystone-k2g: Move keystone_irq " Andrew F. Davis
2018-01-04 19:56   ` [PATCH v2 07/10] ARM: dts: keystone-k2g: Move keystone_dsp_gpio " Andrew F. Davis
2018-01-04 19:56   ` [PATCH v2 08/10] ARM: dts: keystone-k2g: Move usb-phy nodes out of soc0 Andrew F. Davis
2018-01-04 19:57   ` [PATCH v2 09/10] ARM: dts: keystone-k2g: Fix unit-address formatting for serial nodes Andrew F. Davis
2018-01-04 19:57   ` [PATCH v2 10/10] ARM: dts: keystone-k2e-clocks: Fix missing unit address separator Andrew F. Davis
2018-01-19 22:54   ` [PATCH v2 00/10] ARM: dts: keystone*: Continued warnings cleanups Suman Anna

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180104195701.4042-3-afd@ti.com \
    --to=afd-l0cymroini0@public.gmane.org \
    --cc=devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
    --cc=mark.rutland-5wv7dgnIgG8@public.gmane.org \
    --cc=nm-l0cyMroinI0@public.gmane.org \
    --cc=robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
    --cc=s-anna-l0cyMroinI0@public.gmane.org \
    --cc=ssantosh-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).