* [PATCH v2 01/10] ARM: dts: keystone: Move keystone_irq to under device-state-control
[not found] ` <20180104195701.4042-1-afd-l0cyMroinI0@public.gmane.org>
@ 2018-01-04 19:56 ` Andrew F. Davis
2018-01-04 19:56 ` [PATCH v2 02/10] ARM: dts: keystone: Move reset-controller " Andrew F. Davis
` (9 subsequent siblings)
10 siblings, 0 replies; 12+ messages in thread
From: Andrew F. Davis @ 2018-01-04 19:56 UTC (permalink / raw)
To: Santosh Shilimkar, Rob Herring, Mark Rutland, Nishanth Menon,
Suman Anna
Cc: linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r,
devicetree-u79uwXL29TY76Z2rM5mHXA, Andrew F . Davis
The keystone_irq node describes a device that is a member of the device
state control module address space. As such, it should not be a member
of soc0 bus but instead a sub-node of device-state-control.
This move also fixes a warning about not having a reg property. Now
that this is a sub-node of device-state-control, a syscon type node,
we add this reg property but relative to the syscon base, this way
when the dt-binding/driver are updated we can drop the non-standard
ti,syscon-dev property completely and simply use get_resource() in
the driver.
Signed-off-by: Andrew F. Davis <afd-l0cyMroinI0@public.gmane.org>
Acked-by: Nishanth Menon <nm-l0cyMroinI0@public.gmane.org>
---
arch/arm/boot/dts/keystone.dtsi | 22 +++++++++++++---------
1 file changed, 13 insertions(+), 9 deletions(-)
diff --git a/arch/arm/boot/dts/keystone.dtsi b/arch/arm/boot/dts/keystone.dtsi
index 93ea5c69ea77..d726896ffb38 100644
--- a/arch/arm/boot/dts/keystone.dtsi
+++ b/arch/arm/boot/dts/keystone.dtsi
@@ -87,8 +87,20 @@
};
devctrl: device-state-control@2620000 {
- compatible = "ti,keystone-devctrl", "syscon";
+ compatible = "ti,keystone-devctrl", "syscon", "simple-mfd";
reg = <0x02620000 0x1000>;
+ #address-cells = <1>;
+ #size-cells = <1>;
+ ranges = <0x0 0x02620000 0x1000>;
+
+ kirq0: keystone_irq@2a0 {
+ compatible = "ti,keystone-irq";
+ reg = <0x2a0 0x4>;
+ interrupts = <GIC_SPI 4 IRQ_TYPE_EDGE_RISING>;
+ interrupt-controller;
+ #interrupt-cells = <1>;
+ ti,syscon-dev = <&devctrl 0x2a0>;
+ };
};
rstctrl: reset-controller {
@@ -282,14 +294,6 @@
1 0 0x21000A00 0x00000100>;
};
- kirq0: keystone_irq@26202a0 {
- compatible = "ti,keystone-irq";
- interrupts = <GIC_SPI 4 IRQ_TYPE_EDGE_RISING>;
- interrupt-controller;
- #interrupt-cells = <1>;
- ti,syscon-dev = <&devctrl 0x2a0>;
- };
-
pcie0: pcie@21800000 {
compatible = "ti,keystone-pcie", "snps,dw-pcie";
clocks = <&clkpcie>;
--
2.15.1
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply related [flat|nested] 12+ messages in thread* [PATCH v2 02/10] ARM: dts: keystone: Move reset-controller to under device-state-control
[not found] ` <20180104195701.4042-1-afd-l0cyMroinI0@public.gmane.org>
2018-01-04 19:56 ` [PATCH v2 01/10] ARM: dts: keystone: Move keystone_irq to under device-state-control Andrew F. Davis
@ 2018-01-04 19:56 ` Andrew F. Davis
2018-01-04 19:56 ` [PATCH v2 03/10] ARM: dts: keystone-k2e: Move keystone_dsp_gpio " Andrew F. Davis
` (8 subsequent siblings)
10 siblings, 0 replies; 12+ messages in thread
From: Andrew F. Davis @ 2018-01-04 19:56 UTC (permalink / raw)
To: Santosh Shilimkar, Rob Herring, Mark Rutland, Nishanth Menon,
Suman Anna
Cc: linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r,
devicetree-u79uwXL29TY76Z2rM5mHXA, Andrew F . Davis
The keystone_irq node describes a device that is a member of the device
state control module address space. As such, it should not be a member
of soc0 bus but instead a sub-node of device-state-control.
This move also fixes a warning about not having a reg property. Now
that this is a sub-node of device-state-control, a syscon type node,
we add this reg property but relative to the syscon base, this way
when the dt-binding/driver are updated we can drop the non-standard
ti,syscon-dev property completely and simply use get_resource() in
the driver.
Signed-off-by: Andrew F. Davis <afd-l0cyMroinI0@public.gmane.org>
Acked-by: Nishanth Menon <nm-l0cyMroinI0@public.gmane.org>
---
arch/arm/boot/dts/keystone.dtsi | 13 +++++++------
1 file changed, 7 insertions(+), 6 deletions(-)
diff --git a/arch/arm/boot/dts/keystone.dtsi b/arch/arm/boot/dts/keystone.dtsi
index d726896ffb38..5246042f522b 100644
--- a/arch/arm/boot/dts/keystone.dtsi
+++ b/arch/arm/boot/dts/keystone.dtsi
@@ -101,13 +101,14 @@
#interrupt-cells = <1>;
ti,syscon-dev = <&devctrl 0x2a0>;
};
- };
- rstctrl: reset-controller {
- compatible = "ti,keystone-reset";
- ti,syscon-pll = <&pllctrl 0xe4>;
- ti,syscon-dev = <&devctrl 0x328>;
- ti,wdt-list = <0>;
+ rstctrl: reset-controller@328 {
+ compatible = "ti,keystone-reset";
+ reg = <0x328 0x10>;
+ ti,syscon-pll = <&pllctrl 0xe4>;
+ ti,syscon-dev = <&devctrl 0x328>;
+ ti,wdt-list = <0>;
+ };
};
/include/ "keystone-clocks.dtsi"
--
2.15.1
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply related [flat|nested] 12+ messages in thread* [PATCH v2 03/10] ARM: dts: keystone-k2e: Move keystone_dsp_gpio to under device-state-control
[not found] ` <20180104195701.4042-1-afd-l0cyMroinI0@public.gmane.org>
2018-01-04 19:56 ` [PATCH v2 01/10] ARM: dts: keystone: Move keystone_irq to under device-state-control Andrew F. Davis
2018-01-04 19:56 ` [PATCH v2 02/10] ARM: dts: keystone: Move reset-controller " Andrew F. Davis
@ 2018-01-04 19:56 ` Andrew F. Davis
2018-01-04 19:56 ` [PATCH v2 04/10] ARM: dts: keystone-k2l: " Andrew F. Davis
` (7 subsequent siblings)
10 siblings, 0 replies; 12+ messages in thread
From: Andrew F. Davis @ 2018-01-04 19:56 UTC (permalink / raw)
To: Santosh Shilimkar, Rob Herring, Mark Rutland, Nishanth Menon,
Suman Anna
Cc: linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r,
devicetree-u79uwXL29TY76Z2rM5mHXA, Andrew F . Davis
The keystone_irq node describes a device that is a member of the device
state control module address space. As such, it should not be a member
of soc0 bus but instead a sub-node of device-state-control.
This move also fixes a warning about not having a reg property. Now
that this is a sub-node of device-state-control, a syscon type node,
we add this reg property but relative to the syscon base, this way
when the dt-binding/driver are updated we can drop the non-standard
gpio,syscon-dev property completely and simply use get_resource() in
the driver.
Signed-off-by: Andrew F. Davis <afd-l0cyMroinI0@public.gmane.org>
Acked-by: Nishanth Menon <nm-l0cyMroinI0@public.gmane.org>
---
arch/arm/boot/dts/keystone-k2e.dtsi | 13 ++++++++-----
1 file changed, 8 insertions(+), 5 deletions(-)
diff --git a/arch/arm/boot/dts/keystone-k2e.dtsi b/arch/arm/boot/dts/keystone-k2e.dtsi
index 0bcd3f8a9c45..085e7326ea8e 100644
--- a/arch/arm/boot/dts/keystone-k2e.dtsi
+++ b/arch/arm/boot/dts/keystone-k2e.dtsi
@@ -109,11 +109,14 @@
};
};
- dspgpio0: keystone_dsp_gpio@2620240 {
- compatible = "ti,keystone-dsp-gpio";
- gpio-controller;
- #gpio-cells = <2>;
- gpio,syscon-dev = <&devctrl 0x240>;
+ devctrl: device-state-control@2620000 {
+ dspgpio0: keystone_dsp_gpio@240 {
+ compatible = "ti,keystone-dsp-gpio";
+ reg = <0x240 0x4>;
+ gpio-controller;
+ #gpio-cells = <2>;
+ gpio,syscon-dev = <&devctrl 0x240>;
+ };
};
dsp0: dsp@10800000 {
--
2.15.1
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply related [flat|nested] 12+ messages in thread* [PATCH v2 04/10] ARM: dts: keystone-k2l: Move keystone_dsp_gpio to under device-state-control
[not found] ` <20180104195701.4042-1-afd-l0cyMroinI0@public.gmane.org>
` (2 preceding siblings ...)
2018-01-04 19:56 ` [PATCH v2 03/10] ARM: dts: keystone-k2e: Move keystone_dsp_gpio " Andrew F. Davis
@ 2018-01-04 19:56 ` Andrew F. Davis
2018-01-04 19:56 ` [PATCH v2 05/10] ARM: dts: keystone-k2hk: " Andrew F. Davis
` (6 subsequent siblings)
10 siblings, 0 replies; 12+ messages in thread
From: Andrew F. Davis @ 2018-01-04 19:56 UTC (permalink / raw)
To: Santosh Shilimkar, Rob Herring, Mark Rutland, Nishanth Menon,
Suman Anna
Cc: linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r,
devicetree-u79uwXL29TY76Z2rM5mHXA, Andrew F . Davis
The keystone_irq node describes a device that is a member of the device
state control module address space. As such, it should not be a member
of soc0 bus but instead a sub-node of device-state-control.
This move also fixes warnings about not having a reg property. Now
that this is a sub-node of device-state-control, a syscon type node,
we add this reg property but relative to the syscon base, this way
when the dt-binding/driver are updated we can drop the non-standard
gpio,syscon-dev property completely and simply use get_resource() in
the driver.
Signed-off-by: Andrew F. Davis <afd-l0cyMroinI0@public.gmane.org>
Acked-by: Nishanth Menon <nm-l0cyMroinI0@public.gmane.org>
---
arch/arm/boot/dts/keystone-k2l.dtsi | 52 +++++++++++++++++++++----------------
1 file changed, 29 insertions(+), 23 deletions(-)
diff --git a/arch/arm/boot/dts/keystone-k2l.dtsi b/arch/arm/boot/dts/keystone-k2l.dtsi
index b61a830f4a4d..374c80124c4e 100644
--- a/arch/arm/boot/dts/keystone-k2l.dtsi
+++ b/arch/arm/boot/dts/keystone-k2l.dtsi
@@ -289,32 +289,38 @@
clocks = <&clkosr>;
};
- dspgpio0: keystone_dsp_gpio@2620240 {
- compatible = "ti,keystone-dsp-gpio";
- gpio-controller;
- #gpio-cells = <2>;
- gpio,syscon-dev = <&devctrl 0x240>;
- };
+ devctrl: device-state-control@2620000 {
+ dspgpio0: keystone_dsp_gpio@240 {
+ compatible = "ti,keystone-dsp-gpio";
+ reg = <0x240 0x4>;
+ gpio-controller;
+ #gpio-cells = <2>;
+ gpio,syscon-dev = <&devctrl 0x240>;
+ };
- dspgpio1: keystone_dsp_gpio@2620244 {
- compatible = "ti,keystone-dsp-gpio";
- gpio-controller;
- #gpio-cells = <2>;
- gpio,syscon-dev = <&devctrl 0x244>;
- };
+ dspgpio1: keystone_dsp_gpio@244 {
+ compatible = "ti,keystone-dsp-gpio";
+ reg = <0x244 0x4>;
+ gpio-controller;
+ #gpio-cells = <2>;
+ gpio,syscon-dev = <&devctrl 0x244>;
+ };
- dspgpio2: keystone_dsp_gpio@2620248 {
- compatible = "ti,keystone-dsp-gpio";
- gpio-controller;
- #gpio-cells = <2>;
- gpio,syscon-dev = <&devctrl 0x248>;
- };
+ dspgpio2: keystone_dsp_gpio@248 {
+ compatible = "ti,keystone-dsp-gpio";
+ reg = <0x248 0x4>;
+ gpio-controller;
+ #gpio-cells = <2>;
+ gpio,syscon-dev = <&devctrl 0x248>;
+ };
- dspgpio3: keystone_dsp_gpio@262024c {
- compatible = "ti,keystone-dsp-gpio";
- gpio-controller;
- #gpio-cells = <2>;
- gpio,syscon-dev = <&devctrl 0x24c>;
+ dspgpio3: keystone_dsp_gpio@24c {
+ compatible = "ti,keystone-dsp-gpio";
+ reg = <0x24c 0x4>;
+ gpio-controller;
+ #gpio-cells = <2>;
+ gpio,syscon-dev = <&devctrl 0x24c>;
+ };
};
dsp0: dsp@10800000 {
--
2.15.1
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply related [flat|nested] 12+ messages in thread* [PATCH v2 05/10] ARM: dts: keystone-k2hk: Move keystone_dsp_gpio to under device-state-control
[not found] ` <20180104195701.4042-1-afd-l0cyMroinI0@public.gmane.org>
` (3 preceding siblings ...)
2018-01-04 19:56 ` [PATCH v2 04/10] ARM: dts: keystone-k2l: " Andrew F. Davis
@ 2018-01-04 19:56 ` Andrew F. Davis
2018-01-04 19:56 ` [PATCH v2 06/10] ARM: dts: keystone-k2g: Move keystone_irq " Andrew F. Davis
` (5 subsequent siblings)
10 siblings, 0 replies; 12+ messages in thread
From: Andrew F. Davis @ 2018-01-04 19:56 UTC (permalink / raw)
To: Santosh Shilimkar, Rob Herring, Mark Rutland, Nishanth Menon,
Suman Anna
Cc: linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r,
devicetree-u79uwXL29TY76Z2rM5mHXA, Andrew F . Davis
The keystone_irq node describes a device that is a member of the device
state control module address space. As such, it should not be a member
of soc0 bus but instead a sub-node of device-state-control.
This move also fixes warnings about not having a reg property. Now
that this is a sub-node of device-state-control, a syscon type node,
we add this reg property but relative to the syscon base, this way
when the dt-binding/driver are updated we can drop the non-standard
gpio,syscon-dev property completely and simply use get_resource() in
the driver.
Signed-off-by: Andrew F. Davis <afd-l0cyMroinI0@public.gmane.org>
Acked-by: Nishanth Menon <nm-l0cyMroinI0@public.gmane.org>
---
arch/arm/boot/dts/keystone-k2hk.dtsi | 104 +++++++++++++++++++----------------
1 file changed, 57 insertions(+), 47 deletions(-)
diff --git a/arch/arm/boot/dts/keystone-k2hk.dtsi b/arch/arm/boot/dts/keystone-k2hk.dtsi
index ed59474522cb..ca0f198ba627 100644
--- a/arch/arm/boot/dts/keystone-k2hk.dtsi
+++ b/arch/arm/boot/dts/keystone-k2hk.dtsi
@@ -87,60 +87,70 @@
};
};
- dspgpio0: keystone_dsp_gpio@2620240 {
- compatible = "ti,keystone-dsp-gpio";
- gpio-controller;
- #gpio-cells = <2>;
- gpio,syscon-dev = <&devctrl 0x240>;
- };
+ devctrl: device-state-control@2620000 {
+ dspgpio0: keystone_dsp_gpio@240 {
+ compatible = "ti,keystone-dsp-gpio";
+ reg = <0x240 0x4>;
+ gpio-controller;
+ #gpio-cells = <2>;
+ gpio,syscon-dev = <&devctrl 0x240>;
+ };
- dspgpio1: keystone_dsp_gpio@2620244 {
- compatible = "ti,keystone-dsp-gpio";
- gpio-controller;
- #gpio-cells = <2>;
- gpio,syscon-dev = <&devctrl 0x244>;
- };
+ dspgpio1: keystone_dsp_gpio@244 {
+ compatible = "ti,keystone-dsp-gpio";
+ reg = <0x244 0x4>;
+ gpio-controller;
+ #gpio-cells = <2>;
+ gpio,syscon-dev = <&devctrl 0x244>;
+ };
- dspgpio2: keystone_dsp_gpio@2620248 {
- compatible = "ti,keystone-dsp-gpio";
- gpio-controller;
- #gpio-cells = <2>;
- gpio,syscon-dev = <&devctrl 0x248>;
- };
+ dspgpio2: keystone_dsp_gpio@248 {
+ compatible = "ti,keystone-dsp-gpio";
+ reg = <0x248 0x4>;
+ gpio-controller;
+ #gpio-cells = <2>;
+ gpio,syscon-dev = <&devctrl 0x248>;
+ };
- dspgpio3: keystone_dsp_gpio@262024c {
- compatible = "ti,keystone-dsp-gpio";
- gpio-controller;
- #gpio-cells = <2>;
- gpio,syscon-dev = <&devctrl 0x24c>;
- };
+ dspgpio3: keystone_dsp_gpio@24c {
+ compatible = "ti,keystone-dsp-gpio";
+ reg = <0x24c 0x4>;
+ gpio-controller;
+ #gpio-cells = <2>;
+ gpio,syscon-dev = <&devctrl 0x24c>;
+ };
- dspgpio4: keystone_dsp_gpio@2620250 {
- compatible = "ti,keystone-dsp-gpio";
- gpio-controller;
- #gpio-cells = <2>;
- gpio,syscon-dev = <&devctrl 0x250>;
- };
+ dspgpio4: keystone_dsp_gpio@250 {
+ compatible = "ti,keystone-dsp-gpio";
+ reg = <0x250 0x4>;
+ gpio-controller;
+ #gpio-cells = <2>;
+ gpio,syscon-dev = <&devctrl 0x250>;
+ };
- dspgpio5: keystone_dsp_gpio@2620254 {
- compatible = "ti,keystone-dsp-gpio";
- gpio-controller;
- #gpio-cells = <2>;
- gpio,syscon-dev = <&devctrl 0x254>;
- };
+ dspgpio5: keystone_dsp_gpio@254 {
+ compatible = "ti,keystone-dsp-gpio";
+ reg = <0x254 0x4>;
+ gpio-controller;
+ #gpio-cells = <2>;
+ gpio,syscon-dev = <&devctrl 0x254>;
+ };
- dspgpio6: keystone_dsp_gpio@2620258 {
- compatible = "ti,keystone-dsp-gpio";
- gpio-controller;
- #gpio-cells = <2>;
- gpio,syscon-dev = <&devctrl 0x258>;
- };
+ dspgpio6: keystone_dsp_gpio@258 {
+ compatible = "ti,keystone-dsp-gpio";
+ reg = <0x258 0x4>;
+ gpio-controller;
+ #gpio-cells = <2>;
+ gpio,syscon-dev = <&devctrl 0x258>;
+ };
- dspgpio7: keystone_dsp_gpio@262025c {
- compatible = "ti,keystone-dsp-gpio";
- gpio-controller;
- #gpio-cells = <2>;
- gpio,syscon-dev = <&devctrl 0x25c>;
+ dspgpio7: keystone_dsp_gpio@25c {
+ compatible = "ti,keystone-dsp-gpio";
+ reg = <0x25c 0x4>;
+ gpio-controller;
+ #gpio-cells = <2>;
+ gpio,syscon-dev = <&devctrl 0x25c>;
+ };
};
dsp0: dsp@10800000 {
--
2.15.1
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply related [flat|nested] 12+ messages in thread* [PATCH v2 06/10] ARM: dts: keystone-k2g: Move keystone_irq to under device-state-control
[not found] ` <20180104195701.4042-1-afd-l0cyMroinI0@public.gmane.org>
` (4 preceding siblings ...)
2018-01-04 19:56 ` [PATCH v2 05/10] ARM: dts: keystone-k2hk: " Andrew F. Davis
@ 2018-01-04 19:56 ` Andrew F. Davis
2018-01-04 19:56 ` [PATCH v2 07/10] ARM: dts: keystone-k2g: Move keystone_dsp_gpio " Andrew F. Davis
` (4 subsequent siblings)
10 siblings, 0 replies; 12+ messages in thread
From: Andrew F. Davis @ 2018-01-04 19:56 UTC (permalink / raw)
To: Santosh Shilimkar, Rob Herring, Mark Rutland, Nishanth Menon,
Suman Anna
Cc: linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r,
devicetree-u79uwXL29TY76Z2rM5mHXA, Andrew F . Davis
The keystone_irq node describes a device that is a member of the device
state control module address space. As such, it should not be a member
of soc0 bus but instead a sub-node of device-state-control.
This move also fixes a warning about not having a reg property. Now
that this is a sub-node of device-state-control, a syscon type node,
we add this reg property but relative to the syscon base, this way
when the dt-binding/driver are updated we can drop the non-standard
ti,syscon-dev property completely and simply use get_resource() in
the driver.
Signed-off-by: Andrew F. Davis <afd-l0cyMroinI0@public.gmane.org>
Acked-by: Nishanth Menon <nm-l0cyMroinI0@public.gmane.org>
---
arch/arm/boot/dts/keystone-k2g.dtsi | 22 +++++++++++++---------
1 file changed, 13 insertions(+), 9 deletions(-)
diff --git a/arch/arm/boot/dts/keystone-k2g.dtsi b/arch/arm/boot/dts/keystone-k2g.dtsi
index fd061718dc0a..225175d14826 100644
--- a/arch/arm/boot/dts/keystone-k2g.dtsi
+++ b/arch/arm/boot/dts/keystone-k2g.dtsi
@@ -97,8 +97,20 @@
};
devctrl: device-state-control@2620000 {
- compatible = "ti,keystone-devctrl", "syscon";
+ compatible = "ti,keystone-devctrl", "syscon", "simple-mfd";
reg = <0x02620000 0x1000>;
+ #address-cells = <1>;
+ #size-cells = <1>;
+ ranges = <0x0 0x02620000 0x1000>;
+
+ kirq0: keystone_irq@2a0 {
+ compatible = "ti,keystone-irq";
+ reg = <0x2a0 0x10>;
+ interrupts = <GIC_SPI 1 IRQ_TYPE_EDGE_RISING>;
+ interrupt-controller;
+ #interrupt-cells = <1>;
+ ti,syscon-dev = <&devctrl 0x2a0>;
+ };
};
uart0: serial@2530c00 {
@@ -188,14 +200,6 @@
status = "disabled";
};
- kirq0: keystone_irq@26202a0 {
- compatible = "ti,keystone-irq";
- interrupts = <GIC_SPI 1 IRQ_TYPE_EDGE_RISING>;
- interrupt-controller;
- #interrupt-cells = <1>;
- ti,syscon-dev = <&devctrl 0x2a0>;
- };
-
dspgpio0: keystone_dsp_gpio@2620240 {
compatible = "ti,keystone-dsp-gpio";
gpio-controller;
--
2.15.1
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply related [flat|nested] 12+ messages in thread* [PATCH v2 07/10] ARM: dts: keystone-k2g: Move keystone_dsp_gpio to under device-state-control
[not found] ` <20180104195701.4042-1-afd-l0cyMroinI0@public.gmane.org>
` (5 preceding siblings ...)
2018-01-04 19:56 ` [PATCH v2 06/10] ARM: dts: keystone-k2g: Move keystone_irq " Andrew F. Davis
@ 2018-01-04 19:56 ` Andrew F. Davis
2018-01-04 19:56 ` [PATCH v2 08/10] ARM: dts: keystone-k2g: Move usb-phy nodes out of soc0 Andrew F. Davis
` (3 subsequent siblings)
10 siblings, 0 replies; 12+ messages in thread
From: Andrew F. Davis @ 2018-01-04 19:56 UTC (permalink / raw)
To: Santosh Shilimkar, Rob Herring, Mark Rutland, Nishanth Menon,
Suman Anna
Cc: linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r,
devicetree-u79uwXL29TY76Z2rM5mHXA, Andrew F . Davis
The keystone_irq node describes a device that is a member of the device
state control module address space. As such, it should not be a member
of soc0 bus but instead a sub-node of device-state-control.
This move also fixes a warning about not having a reg property. Now
that this is a sub-node of device-state-control, a syscon type node,
we add this reg property but relative to the syscon base, this way
when the dt-binding/driver are updated we can drop the non-standard
gpio,syscon-dev property completely and simply use get_resource() in
the driver.
Signed-off-by: Andrew F. Davis <afd-l0cyMroinI0@public.gmane.org>
Acked-by: Nishanth Menon <nm-l0cyMroinI0@public.gmane.org>
---
arch/arm/boot/dts/keystone-k2g.dtsi | 15 ++++++++-------
1 file changed, 8 insertions(+), 7 deletions(-)
diff --git a/arch/arm/boot/dts/keystone-k2g.dtsi b/arch/arm/boot/dts/keystone-k2g.dtsi
index 225175d14826..d83dbfe24b49 100644
--- a/arch/arm/boot/dts/keystone-k2g.dtsi
+++ b/arch/arm/boot/dts/keystone-k2g.dtsi
@@ -111,6 +111,14 @@
#interrupt-cells = <1>;
ti,syscon-dev = <&devctrl 0x2a0>;
};
+
+ dspgpio0: keystone_dsp_gpio@240 {
+ compatible = "ti,keystone-dsp-gpio";
+ reg = <0x240 0x4>;
+ gpio-controller;
+ #gpio-cells = <2>;
+ gpio,syscon-dev = <&devctrl 0x240>;
+ };
};
uart0: serial@2530c00 {
@@ -200,13 +208,6 @@
status = "disabled";
};
- dspgpio0: keystone_dsp_gpio@2620240 {
- compatible = "ti,keystone-dsp-gpio";
- gpio-controller;
- #gpio-cells = <2>;
- gpio,syscon-dev = <&devctrl 0x240>;
- };
-
dsp0: dsp@10800000 {
compatible = "ti,k2g-dsp";
reg = <0x10800000 0x00100000>,
--
2.15.1
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply related [flat|nested] 12+ messages in thread* [PATCH v2 08/10] ARM: dts: keystone-k2g: Move usb-phy nodes out of soc0
[not found] ` <20180104195701.4042-1-afd-l0cyMroinI0@public.gmane.org>
` (6 preceding siblings ...)
2018-01-04 19:56 ` [PATCH v2 07/10] ARM: dts: keystone-k2g: Move keystone_dsp_gpio " Andrew F. Davis
@ 2018-01-04 19:56 ` Andrew F. Davis
2018-01-04 19:57 ` [PATCH v2 09/10] ARM: dts: keystone-k2g: Fix unit-address formatting for serial nodes Andrew F. Davis
` (2 subsequent siblings)
10 siblings, 0 replies; 12+ messages in thread
From: Andrew F. Davis @ 2018-01-04 19:56 UTC (permalink / raw)
To: Santosh Shilimkar, Rob Herring, Mark Rutland, Nishanth Menon,
Suman Anna
Cc: linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r,
devicetree-u79uwXL29TY76Z2rM5mHXA, Andrew F . Davis
The two usb-phy nodes are not memory-mapped devices on the
SoC but rather dummy phys for SoCs with transparent autonomous
NOP phys. Move these to outside soc0 to their own node like
done elsewhere.
Signed-off-by: Andrew F. Davis <afd-l0cyMroinI0@public.gmane.org>
Acked-by: Nishanth Menon <nm-l0cyMroinI0@public.gmane.org>
---
arch/arm/boot/dts/keystone-k2g.dtsi | 28 ++++++++++++++++++----------
1 file changed, 18 insertions(+), 10 deletions(-)
diff --git a/arch/arm/boot/dts/keystone-k2g.dtsi b/arch/arm/boot/dts/keystone-k2g.dtsi
index d83dbfe24b49..cdaf519721b1 100644
--- a/arch/arm/boot/dts/keystone-k2g.dtsi
+++ b/arch/arm/boot/dts/keystone-k2g.dtsi
@@ -69,6 +69,24 @@
interrupts = <GIC_SPI 4 IRQ_TYPE_EDGE_RISING>;
};
+ usbphy {
+ #address-cells = <1>;
+ #size-cells = <0>;
+ compatible = "simple-bus";
+
+ usb0_phy: usb-phy@0 {
+ compatible = "usb-nop-xceiv";
+ reg = <0>;
+ status = "disabled";
+ };
+
+ usb1_phy: usb-phy@1 {
+ compatible = "usb-nop-xceiv";
+ reg = <1>;
+ status = "disabled";
+ };
+ };
+
soc0: soc@0 {
#address-cells = <1>;
#size-cells = <1>;
@@ -465,11 +483,6 @@
status = "disabled";
};
- usb0_phy: usb-phy@0 {
- compatible = "usb-nop-xceiv";
- status = "disabled";
- };
-
keystone_usb0: keystone-dwc3@2680000 {
compatible = "ti,keystone-dwc3";
#address-cells = <1>;
@@ -493,11 +506,6 @@
};
};
- usb1_phy: usb-phy@1 {
- compatible = "usb-nop-xceiv";
- status = "disabled";
- };
-
keystone_usb1: keystone-dwc3@2580000 {
compatible = "ti,keystone-dwc3";
#address-cells = <1>;
--
2.15.1
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply related [flat|nested] 12+ messages in thread* [PATCH v2 09/10] ARM: dts: keystone-k2g: Fix unit-address formatting for serial nodes
[not found] ` <20180104195701.4042-1-afd-l0cyMroinI0@public.gmane.org>
` (7 preceding siblings ...)
2018-01-04 19:56 ` [PATCH v2 08/10] ARM: dts: keystone-k2g: Move usb-phy nodes out of soc0 Andrew F. Davis
@ 2018-01-04 19:57 ` Andrew F. Davis
2018-01-04 19:57 ` [PATCH v2 10/10] ARM: dts: keystone-k2e-clocks: Fix missing unit address separator Andrew F. Davis
2018-01-19 22:54 ` [PATCH v2 00/10] ARM: dts: keystone*: Continued warnings cleanups Suman Anna
10 siblings, 0 replies; 12+ messages in thread
From: Andrew F. Davis @ 2018-01-04 19:57 UTC (permalink / raw)
To: Santosh Shilimkar, Rob Herring, Mark Rutland, Nishanth Menon,
Suman Anna
Cc: linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r,
devicetree-u79uwXL29TY76Z2rM5mHXA, Andrew F . Davis
From: Suman Anna <s-anna-l0cyMroinI0@public.gmane.org>
The unit addresses on couple of serial nodes have a leading 0 resulting
in couple of warning messages around simple-bus unit address format
errors when compiled with W=1. Fix the same.
Signed-off-by: Suman Anna <s-anna-l0cyMroinI0@public.gmane.org>
---
arch/arm/boot/dts/keystone-k2g.dtsi | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/arch/arm/boot/dts/keystone-k2g.dtsi b/arch/arm/boot/dts/keystone-k2g.dtsi
index cdaf519721b1..39f56054f319 100644
--- a/arch/arm/boot/dts/keystone-k2g.dtsi
+++ b/arch/arm/boot/dts/keystone-k2g.dtsi
@@ -151,7 +151,7 @@
status = "disabled";
};
- uart1: serial@02531000 {
+ uart1: serial@2531000 {
compatible = "ti,da830-uart", "ns16550a";
current-speed = <115200>;
reg-shift = <2>;
@@ -163,7 +163,7 @@
status = "disabled";
};
- uart2: serial@02531400 {
+ uart2: serial@2531400 {
compatible = "ti,da830-uart", "ns16550a";
current-speed = <115200>;
reg-shift = <2>;
--
2.15.1
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply related [flat|nested] 12+ messages in thread* [PATCH v2 10/10] ARM: dts: keystone-k2e-clocks: Fix missing unit address separator
[not found] ` <20180104195701.4042-1-afd-l0cyMroinI0@public.gmane.org>
` (8 preceding siblings ...)
2018-01-04 19:57 ` [PATCH v2 09/10] ARM: dts: keystone-k2g: Fix unit-address formatting for serial nodes Andrew F. Davis
@ 2018-01-04 19:57 ` Andrew F. Davis
2018-01-19 22:54 ` [PATCH v2 00/10] ARM: dts: keystone*: Continued warnings cleanups Suman Anna
10 siblings, 0 replies; 12+ messages in thread
From: Andrew F. Davis @ 2018-01-04 19:57 UTC (permalink / raw)
To: Santosh Shilimkar, Rob Herring, Mark Rutland, Nishanth Menon,
Suman Anna
Cc: linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r,
devicetree-u79uwXL29TY76Z2rM5mHXA, Andrew F . Davis
From: Suman Anna <s-anna-l0cyMroinI0@public.gmane.org>
Commit 95d8b41c765b ("ARM: dts: keystone-k2e-clocks: Add missing unit
name to clock nodes that have regs") fixed the unit names on various
clock nodes but missed out adding the unit address separator on the
clkhyperlink0 clock node. Fix the same.
Fixes: 95d8b41c765b ("ARM: dts: keystone-k2e-clocks: Add missing unit name to clock nodes that have regs")
Signed-off-by: Suman Anna <s-anna-l0cyMroinI0@public.gmane.org>
---
arch/arm/boot/dts/keystone-k2e-clocks.dtsi | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm/boot/dts/keystone-k2e-clocks.dtsi b/arch/arm/boot/dts/keystone-k2e-clocks.dtsi
index 5e0e7d232161..f7592155a740 100644
--- a/arch/arm/boot/dts/keystone-k2e-clocks.dtsi
+++ b/arch/arm/boot/dts/keystone-k2e-clocks.dtsi
@@ -42,7 +42,7 @@ clocks {
domain-id = <0>;
};
- clkhyperlink0: clkhyperlink02350030 {
+ clkhyperlink0: clkhyperlink0@2350030 {
#clock-cells = <0>;
compatible = "ti,keystone,psc-clock";
clocks = <&chipclk12>;
--
2.15.1
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply related [flat|nested] 12+ messages in thread* Re: [PATCH v2 00/10] ARM: dts: keystone*: Continued warnings cleanups
[not found] ` <20180104195701.4042-1-afd-l0cyMroinI0@public.gmane.org>
` (9 preceding siblings ...)
2018-01-04 19:57 ` [PATCH v2 10/10] ARM: dts: keystone-k2e-clocks: Fix missing unit address separator Andrew F. Davis
@ 2018-01-19 22:54 ` Suman Anna
10 siblings, 0 replies; 12+ messages in thread
From: Suman Anna @ 2018-01-19 22:54 UTC (permalink / raw)
To: Andrew F. Davis, Santosh Shilimkar, Rob Herring, Mark Rutland,
Nishanth Menon
Cc: linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r,
devicetree-u79uwXL29TY76Z2rM5mHXA
On 01/04/2018 01:56 PM, Andrew F. Davis wrote:
> Hello all,
>
> Just a couple cleanups for DT warnings when compiling with W=1.
>
> This clears up 51 more warnings when building keystone_defconfig.
>
> Based on Santosh's "for_4.16/keystone-dts" branch.
>
> Thanks,
> Andrew
>
> Changes from v1:
> - Added to more patches from Suman
> - Reworded commit message to include "address space" distinction
Thanks, you still have left in the "and simply use get_resource() in
the driver." part in the commit descriptions though, which is not right.
Otherwise, the changes look good.
> - Added "ranges" property
> - Reordered #address/size-cells
For the entire series,
Tested-by: Suman Anna <s-anna-l0cyMroinI0@public.gmane.org>
regards
Suman
>
> Andrew F. Davis (8):
> ARM: dts: keystone: Move keystone_irq to under device-state-control
> ARM: dts: keystone: Move reset-controller to under
> device-state-control
> ARM: dts: keystone-k2e: Move keystone_dsp_gpio to under
> device-state-control
> ARM: dts: keystone-k2l: Move keystone_dsp_gpio to under
> device-state-control
> ARM: dts: keystone-k2hk: Move keystone_dsp_gpio to under
> device-state-control
> ARM: dts: keystone-k2g: Move keystone_irq to under
> device-state-control
> ARM: dts: keystone-k2g: Move keystone_dsp_gpio to under
> device-state-control
> ARM: dts: keystone-k2g: Move usb-phy nodes out of soc0
>
> Suman Anna (2):
> ARM: dts: keystone-k2g: Fix unit-address formatting for serial nodes
> ARM: dts: keystone-k2e-clocks: Fix missing unit address separator
>
> arch/arm/boot/dts/keystone-k2e-clocks.dtsi | 2 +-
> arch/arm/boot/dts/keystone-k2e.dtsi | 13 ++--
> arch/arm/boot/dts/keystone-k2g.dtsi | 69 +++++++++++--------
> arch/arm/boot/dts/keystone-k2hk.dtsi | 104 ++++++++++++++++-------------
> arch/arm/boot/dts/keystone-k2l.dtsi | 52 ++++++++-------
> arch/arm/boot/dts/keystone.dtsi | 35 +++++-----
> 6 files changed, 156 insertions(+), 119 deletions(-)
>
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 12+ messages in thread