From mboxrd@z Thu Jan 1 00:00:00 1970 From: Leo Yan Subject: Re: [PATCH v4 2/3] mailbox: Add support for Hi3660 mailbox Date: Fri, 5 Jan 2018 16:08:55 +0800 Message-ID: <20180105080854.GB26855@leoy-linaro> References: <1513682145-19892-1-git-send-email-zhongkaihua@huawei.com> <1513682145-19892-3-git-send-email-zhongkaihua@huawei.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: Sender: devicetree-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Jassi Brar Cc: Kaihua Zhong , Rob Herring , Mark Rutland , Wei Xu , Catalin Marinas , Will Deacon , Devicetree List , Linux Kernel Mailing List , linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, Guodong Xu , Haojian Zhuang , suzhuangluan-C8/M+/jPZTeaMJb+Lgu22Q@public.gmane.org, xuezhiliang-C8/M+/jPZTeaMJb+Lgu22Q@public.gmane.org, kevin.wangtao-C8/M+/jPZTeaMJb+Lgu22Q@public.gmane.org List-Id: devicetree@vger.kernel.org Hi Jassi, On Fri, Jan 05, 2018 at 09:58:57AM +0530, Jassi Brar wrote: > On Tue, Dec 19, 2017 at 4:45 PM, Kaihua Zhong wrote: > > ..... > > diff --git a/drivers/mailbox/hi3660-mailbox.c b/drivers/mailbox/hi3660-mailbox.c > > new file mode 100644 > > index 0000000..3ceca40 > > --- /dev/null > > +++ b/drivers/mailbox/hi3660-mailbox.c > > @@ -0,0 +1,319 @@ > > +// SPDX-License-Identifier: GPL-2.0 > > +// Copyright (c) 2017 Hisilicon Limited. > > +// Copyright (c) 2017 Linaro Limited. > > A blank here please. Will fix. > > +#include > > +#include > > +#include > > +#include > > +#include > > +#include > > +#include Will add blank. > ..... > > + > > +static inline struct hi3660_mbox *to_hi3660_mbox(struct mbox_controller *mbox) > > > inline in .c is out of fasion these days Will remove 'inline'. > > +{ > > + return container_of(mbox, struct hi3660_mbox, controller); > > +} > > + > > .... > > + > > +static int hi3660_mbox_startup(struct mbox_chan *chan) > > +{ > > + int ret; > > + > > + ret = hi3660_mbox_check_state(chan); > > + if (ret) > > + return ret; > > + > > + ret = hi3660_mbox_unlock(chan); > > + if (ret) > > + return ret; > > + > > + ret = hi3660_mbox_acquire_channel(chan); > > + if (ret) > > + return ret; > > + > > + return 0; > > +} > Do you not need to do "release channel" for shutdown() ? >>From my testing, the driver don't need "release channel" operations. > ..... > > + > > +static int hi3660_mbox_send_data(struct mbox_chan *chan, void *msg) > > +{ > > + return hi3660_mbox_send(chan, msg); > > > Please directly have hi3660_mbox_send as .send_data Will fix. Thanks, Leo Yan -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html