From: Mark Brown <broonie@kernel.org>
To: Rob Herring <robh@kernel.org>
Cc: Chunyan Zhang <zhang.chunyan@linaro.org>,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
Ulf Hansson <ulf.hansson@linaro.org>,
Chunyan Zhang <zhang.lyra@gmail.com>
Subject: Re: [PATCH V2 1/5] bindings: regulator: added support for suspend states
Date: Fri, 5 Jan 2018 19:18:37 +0000 [thread overview]
Message-ID: <20180105191837.GI9076@sirena.org.uk> (raw)
In-Reply-To: <20180105185328.zmt33idv2cqled62@rob-hp-laptop>
[-- Attachment #1: Type: text/plain, Size: 1233 bytes --]
On Fri, Jan 05, 2018 at 12:53:28PM -0600, Rob Herring wrote:
> On Thu, Jan 04, 2018 at 03:22:44PM +0800, Chunyan Zhang wrote:
> > + - regulator-suspend-microvolt: the default voltage which regulator
> > + would be set in suspend. The voltage for suspend also can be
> > + adjusted among {regulator-suspend-min-microvolt,
> > + regulator-suspend-max-microvolt} by calling
> > + regulator_set_suspend_voltage(). This property is not deprecated,
> You mean "is deprecated", right?
I suspect "is now" but yeah.
> > + - regulator-changeable-in-suspend: whether the default voltage and
> > + the regulator on/off in suspend can be changed in runtime.
> Is this not implied by having the constraints? Or the driver should know
> this. The simply means you have some 2nd bank of registers for settings
> while in suspend mode, right?
No, it means that the software has permission to use those changes to
those registers - we only want to be changing things if the user has
permission to change them since some systems will have specific
constraints, we don't know if it's safe without being explicitly told.
You're right that we could infer this from a range being provided
though, let's do that.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2018-01-05 19:18 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-04 7:22 [PATCH V2 0/5] Add regulator suspend and resume support Chunyan Zhang
2018-01-04 7:22 ` [PATCH V2 1/5] bindings: regulator: added support for suspend states Chunyan Zhang
[not found] ` <1515050568-23876-2-git-send-email-zhang.chunyan-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
2018-01-05 18:53 ` Rob Herring
2018-01-05 19:18 ` Mark Brown [this message]
[not found] ` <20180105191837.GI9076-GFdadSzt00ze9xe1eoZjHA@public.gmane.org>
2018-01-08 6:36 ` Chunyan Zhang
[not found] ` <CAG2=9p-ec1oVe-+O0TGYFF-E5dGrP3FoRZXb1sCyjNScVvGNQg-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2018-01-08 12:35 ` Mark Brown
[not found] ` <20180108123533.GE11698-GFdadSzt00ze9xe1eoZjHA@public.gmane.org>
2018-01-09 6:08 ` Chunyan Zhang
2018-01-09 16:40 ` Mark Brown
[not found] ` <1515050568-23876-1-git-send-email-zhang.chunyan-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
2018-01-04 7:22 ` [PATCH V2 2/5] regulator: make regulator voltage be an array to support more states Chunyan Zhang
2018-01-04 7:22 ` [PATCH V2 4/5] drivers: regulator: empty the old suspend functions Chunyan Zhang
2018-01-04 7:22 ` [PATCH V2 3/5] drivers: regulator: leave one item to record whether regulator is enabled Chunyan Zhang
2018-01-04 7:22 ` [PATCH V2 5/5] regulator: add PM suspend and resume hooks Chunyan Zhang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180105191837.GI9076@sirena.org.uk \
--to=broonie@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh@kernel.org \
--cc=ulf.hansson@linaro.org \
--cc=zhang.chunyan@linaro.org \
--cc=zhang.lyra@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).