Re: [PATCH v17 0/5] ZII RAVE platform driver

Lee Jones
2018-01-03T09:46:21Z

Well I guess we better at least include them in the conversation.

Stephen and Andrew added.

On Tue, 02 Jan 2018, Andrey Smirnov wrote:
> On Tue, Jan 2, 2018 at 7:17 AM, Lee Jones <lee.jones-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org> wrote:
> > On Wed, 20 Dec 2017, Andrey Smirnov wrote:
> >
> >> Everyone:
> >>
> >> This patch series is v17 of the driver for supervisory processor found
> >> on RAVE series of devices from ZII. Supervisory processor is a PIC
> >> microcontroller connected to various electrical subsystems on RAVE
> >> devices whose firmware implements protocol to command/qery them.
> >>
> >> NOTE:
> >>
> >> * This driver dependends on crc_ccitt_false(), added by
> >> 2da9378d531f8cc6670c7497f20d936b706ab80b in 'linux-next', the patch
> >> was pulled in by Andrew Morton and is currently avaiting users, so
> >> this series might have to go in through Andrew's tree
> >
> > Hmm... well that's annoying! I just attempted to merge this set, but
> > early build tests fail due to a dependency already merged into -next.
> >
> > ../drivers/mfd/rave-sp.c:227:25: error:
> > implicit declaration of function ‘crc_ccitt_false’
> > [-Werror=implicit-function-declaration]
> >
> > We need to figure out if either of the following are true:
> >
> > - Patch [0] can be dropped from Andrew's tree
> > - ... and I can take it via the MFD tree instead

> FWIW, it seems to me that the path above should be doable (and might
> be simpler?). Let me know if any action needs to be taken on my part.
>
> Thanks,
> Andrey Smirnov

> > - Patch [0] is on an immutable branch I can pull in to my PR
> >
> > If not, it will have to wait until the next cycle.
> >
> > [0]:
> >
> > Author: Andrey Vostrikov <andrey.vostrikov-M4DtvfQ/ZS1MRgGoP+s0PdBPR1lH4CV8@public.gmane.org>
> > Date: Mon Dec 25 22:39:57 2017 +1100
> >
> > lib/crc-ccitt: add CCITT-FALSE CRC16 variant
> >
> > In support of a soon to be published MFD driver using serdev to talk to
> > a supervisory processor that uses the CCITT-FALSE CRC16 variant in it's
> > protocol, this patch was tested successfully on an i.MX6 ARM platform.
> >
> > Link: http://lkml.kernel.org/r/20170413142932.27287-1-andrew.smirnov-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org
> > Signed-off-by: Andrey Vostrikov <andrey.vostrikov-M4DtvfQ/ZS1MRgGoP+s0PdBPR1lH4CV8@public.gmane.org>
> > Signed-off-by: Andrey Smirnov <andrew.smirnov-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
> > Tested-by: Chris Healy <cphealy-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
> > Signed-off-by: Andrew Morton <akpm-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org>
> > Signed-off-by: Stephen Rothwell <sfr-3FnU+UHB4dNDw9hX6IcOSA@public.gmane.org>

--
Lee Jones
Linaro Services Technical Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog