devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Gary Bisson <gary.bisson@boundarydevices.com>
To: Stefan Agner <stefan@agner.ch>
Cc: linus.walleij@linaro.org, shawnguo@kernel.org,
	kernel@pengutronix.de, fabio.estevam@nxp.com,
	aisheng.dong@nxp.com, robh+dt@kernel.org, mark.rutland@arm.com,
	linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org,
	Arvind Yadav <arvind.yadav.cs@gmail.com>
Subject: Re: [PATCH v2 1/5] pinctrl: imx: use struct imx_pinctrl_soc_info as a const
Date: Mon, 8 Jan 2018 17:48:55 +0100	[thread overview]
Message-ID: <20180108164855.GA6504@t450s.lan> (raw)
In-Reply-To: <20180106142553.15322-2-stefan@agner.ch>

Hi Stefan,

On Sat, Jan 06, 2018 at 03:25:49PM +0100, Stefan Agner wrote:
> For some SoCs the struct imx_pinctrl_soc_info is passed through
> of_device_id.data which is const. Most variables are already const
> or otherwise not written. However, some fields are modified at
> runtime. Move those fields to the dynamically allocated struct
> imx_pinctrl.
> 
> Fixes: b3060044e495 ("pinctrl: freescale: imx7d: make of_device_ids const")
> Cc: Shawn Guo <shawnguo@kernel.org>
> Cc: Arvind Yadav <arvind.yadav.cs@gmail.com>
> Cc: Dong Aisheng <aisheng.dong@nxp.com>
> Cc: Gary Bisson <gary.bisson@boundarydevices.com>
> Signed-off-by: Stefan Agner <stefan@agner.ch>

This is actually more or less a revert of a previous commit:
b28742be4709 pinctrl: imx: remove const qualifier of imx_pinctrl_soc_info

Note that the idea for this commit was to get dt-overlays working and
able to do pinctrl changes using configfs interface to load an overlay
(using Pantelis patch). Not sure where we stand on loading such overlay
from user-space, is it still something that will happen?

Regards,
Gary

  reply	other threads:[~2018-01-08 16:48 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-01-06 14:25 [PATCH v2 0/5] constify struct imx_pinctrl_soc_info Stefan Agner
2018-01-06 14:25 ` [PATCH v2 1/5] pinctrl: imx: use struct imx_pinctrl_soc_info as a const Stefan Agner
2018-01-08 16:48   ` Gary Bisson [this message]
     [not found]     ` <20180108164855.GA6504-gtbVdJvtf7D/PtFMR13I2A@public.gmane.org>
2018-01-08 20:52       ` Stefan Agner
2018-01-09 14:33         ` Gary Bisson
     [not found]   ` <20180106142553.15322-2-stefan-XLVq0VzYD2Y@public.gmane.org>
2018-01-11  9:24     ` Linus Walleij
2018-01-06 14:25 ` [PATCH v2 2/5] pinctrl: imx7d: simplify imx7d_pinctrl_probe Stefan Agner
2018-01-11  9:25   ` Linus Walleij
     [not found] ` <20180106142553.15322-1-stefan-XLVq0VzYD2Y@public.gmane.org>
2018-01-06 14:25   ` [PATCH v2 3/5] pinctrl: imx: constify struct imx_pinctrl_soc_info Stefan Agner
2018-01-11  9:26     ` Linus Walleij
2018-01-06 14:25 ` [PATCH v2 4/5] pinctrl: imx7ulp: constify struct imx_cfg_params_decode Stefan Agner
2018-01-11  9:27   ` Linus Walleij
2018-01-06 14:25 ` [PATCH v2 5/5] pinctrl: imx6ul: add IOMUXC SNVS pinctrl driver for i.MX 6ULL Stefan Agner
2018-01-09 14:07   ` Linus Walleij
2018-01-09 14:11     ` Fabio Estevam
     [not found]       ` <CAOMZO5CjCv1Lg6sazyJWS_xZvD6bXhW=1poYMEFUbgodAST5Yg-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2018-01-09 14:33         ` Linus Walleij
     [not found]     ` <CACRpkdYJcS3Ng=uR-iPgJ22ABfbiVENjWGsaWwShUfbg1hU4+g-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2018-01-10  5:35       ` A.s. Dong
2018-01-08 10:32 ` [PATCH v2 0/5] constify struct imx_pinctrl_soc_info Dong Aisheng

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180108164855.GA6504@t450s.lan \
    --to=gary.bisson@boundarydevices.com \
    --cc=aisheng.dong@nxp.com \
    --cc=arvind.yadav.cs@gmail.com \
    --cc=devicetree@vger.kernel.org \
    --cc=fabio.estevam@nxp.com \
    --cc=kernel@pengutronix.de \
    --cc=linus.walleij@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mark.rutland@arm.com \
    --cc=robh+dt@kernel.org \
    --cc=shawnguo@kernel.org \
    --cc=stefan@agner.ch \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).