From: Dong Aisheng <dongas86-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
To: Stefan Agner <stefan-XLVq0VzYD2Y@public.gmane.org>
Cc: Rob Herring <robh-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
shawnguo-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org,
kernel-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org,
fabio.estevam-3arQi8VN3Tc@public.gmane.org,
mark.rutland-5wv7dgnIgG8@public.gmane.org,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
Bai Ping <ping.bai-3arQi8VN3Tc@public.gmane.org>,
linux-imx-3arQi8VN3Tc@public.gmane.org
Subject: Re: [PATCH 3/7] ARM: dts: imx6ull: add additional pinfunc defines for i.MX 6ULL
Date: Tue, 9 Jan 2018 17:30:15 +0800 [thread overview]
Message-ID: <20180109093015.GC26312@b29396-OptiPlex-7040> (raw)
In-Reply-To: <b183c2a38596cd3f3726777c79e027f9-XLVq0VzYD2Y@public.gmane.org>
On Sun, Jan 07, 2018 at 10:52:39AM +0100, Stefan Agner wrote:
> On 2018-01-05 17:49, Rob Herring wrote:
> > On Tue, Jan 02, 2018 at 05:42:19PM +0100, Stefan Agner wrote:
> >> From: Bai Ping <ping.bai-3arQi8VN3Tc@public.gmane.org>
> >>
> >> On i.MX 6ULL, the pin MUX and CTRL register of BOOT_MODEx and TAMPERx
> >> pins are available through IOMUXC_SNVS. Add additional pinfunc defines.
> >>
> >> Signed-off-by: Bai Ping <ping.bai-3arQi8VN3Tc@public.gmane.org>
> >> Signed-off-by: Stefan Agner <stefan-XLVq0VzYD2Y@public.gmane.org>
> >> ---
> >> arch/arm/boot/dts/imx6ull-pinfunc-snvs.h | 29 +++++++++++++++++++++++++++++
> >> arch/arm/boot/dts/imx6ull.dtsi | 1 +
> >> 2 files changed, 30 insertions(+)
> >> create mode 100644 arch/arm/boot/dts/imx6ull-pinfunc-snvs.h
> >>
> >> diff --git a/arch/arm/boot/dts/imx6ull-pinfunc-snvs.h b/arch/arm/boot/dts/imx6ull-pinfunc-snvs.h
> >> new file mode 100644
> >> index 000000000000..da3f412e4269
> >> --- /dev/null
> >> +++ b/arch/arm/boot/dts/imx6ull-pinfunc-snvs.h
> >> @@ -0,0 +1,29 @@
> >> +/*
> >> + * Copyright (C) 2016 Freescale Semiconductor, Inc.
> >
> > It's 2018 now.
> >
>
> I don't think you are supposed to chance copyright year unless you
> change it significantly.
>
> At least that article suggests so:
> https://www.copyrightlaws.com/copyright-notice-year/
>
> I took that patch from the downstream NXP kernel, so I guess 2016 was
> the year of first publication...
>
Can you help add below copyright if you keep NXP sign-off as Author?
Then you don't need delete the old one.
Copyright 2017 NXP.
And SPDX mentioned by Rob.
Otherwise,
Acked-by: Dong Aisheng <aisheng.dong-3arQi8VN3Tc@public.gmane.org>
Regards
Dong Aisheng
> >> + *
> >> + * This program is free software; you can redistribute it and/or modify
> >> + * it under the terms of the GNU General Public License version 2 as
> >> + * published by the Free Software Foundation.
> >
> > Use SPDX. With that,
>
> Agreed.
>
> >
> > Reviewed-by: Rob Herring <robh-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
>
> --
> Stefan
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2018-01-09 9:30 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-02 16:42 [PATCH 1/7] ARM: imx: add timer stop flag to ARM power off state Stefan Agner
2018-01-02 16:42 ` [PATCH 2/7] ARM: dts: imx6ul: update i.MX 6UltraLite iomux headers Stefan Agner
2018-01-05 16:45 ` Rob Herring
2018-01-06 10:47 ` Stefan Agner
2018-01-08 1:37 ` Andy Duan
2018-01-09 9:24 ` Dong Aisheng
2018-01-02 16:42 ` [PATCH 3/7] ARM: dts: imx6ull: add additional pinfunc defines for i.MX 6ULL Stefan Agner
[not found] ` <20180102164223.15230-3-stefan-XLVq0VzYD2Y@public.gmane.org>
2018-01-05 16:49 ` Rob Herring
2018-01-07 9:52 ` Stefan Agner
[not found] ` <b183c2a38596cd3f3726777c79e027f9-XLVq0VzYD2Y@public.gmane.org>
2018-01-09 9:30 ` Dong Aisheng [this message]
2018-01-02 16:42 ` [PATCH 4/7] ARM: dts: imx6ul: add interrupt of virt-capable GIC Stefan Agner
2018-01-02 16:42 ` [PATCH 5/7] ARM: dts: imx6ul: add ARM architected timer Stefan Agner
[not found] ` <20180102164223.15230-5-stefan-XLVq0VzYD2Y@public.gmane.org>
2018-01-09 9:34 ` Dong Aisheng
2018-01-09 13:18 ` Stefan Agner
2018-01-02 16:42 ` [PATCH 6/7] ARM: dts: imx6ull: add IOMUXC SNVS instance Stefan Agner
2018-01-09 9:35 ` Dong Aisheng
[not found] ` <20180102164223.15230-1-stefan-XLVq0VzYD2Y@public.gmane.org>
2018-01-02 16:42 ` [PATCH 7/7] ARM: dts: imx6ull: add UART8 support Stefan Agner
2018-01-09 9:38 ` Dong Aisheng
2018-01-09 9:22 ` [PATCH 1/7] ARM: imx: add timer stop flag to ARM power off state Dong Aisheng
2018-01-09 9:25 ` Anson Huang
2018-01-09 10:13 ` Lucas Stach
[not found] ` <1515492803.12538.29.camel-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
2018-01-09 13:37 ` Stefan Agner
2018-01-09 14:04 ` Lucas Stach
2018-01-09 22:21 ` Stefan Agner
2018-01-09 13:22 ` Stefan Agner
2018-01-10 17:48 ` Lucas Stach
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180109093015.GC26312@b29396-OptiPlex-7040 \
--to=dongas86-re5jqeeqqe8avxtiumwx3w@public.gmane.org \
--cc=devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=fabio.estevam-3arQi8VN3Tc@public.gmane.org \
--cc=kernel-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org \
--cc=linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
--cc=linux-imx-3arQi8VN3Tc@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=mark.rutland-5wv7dgnIgG8@public.gmane.org \
--cc=ping.bai-3arQi8VN3Tc@public.gmane.org \
--cc=robh-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
--cc=shawnguo-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
--cc=stefan-XLVq0VzYD2Y@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox